On 23 October 2015 at 06:00, Ben Widawsky wrote:
> @@ -57,13 +57,15 @@ piglit_display(void)
>
> piglit_draw_rect(-1, -1, 2, 2);
>
> - glReadPixels(0, 0, 3, 1, GL_STENCIL_INDEX, GL_FLOAT, p);
> + glReadPixels(0, 0, 256, 256, GL_STENCIL_INDEX, GL_UNSIGNED_BYTE, p);
As you use th
On Fri, Nov 06, 2015 at 04:47:02PM +, Emil Velikov wrote:
> Hi Ben,
>
> On 23 October 2015 at 06:00, Ben Widawsky wrote:
>
> > @@ -46,8 +46,8 @@ static GLint prog;
> > enum piglit_result
> > piglit_display(void)
> > {
> > - GLboolean pass = GL_TRUE;
> > - float p[4];
> > +
Hi Ben,
On 23 October 2015 at 06:00, Ben Widawsky wrote:
> @@ -46,8 +46,8 @@ static GLint prog;
> enum piglit_result
> piglit_display(void)
> {
> - GLboolean pass = GL_TRUE;
> - float p[4];
> + uint8_t p[256 * 256];
If you're reworking either of these two patches, can you th
Ben Widawsky writes:
> - glReadPixels(0, 0, 3, 1, GL_STENCIL_INDEX, GL_FLOAT, p);
> + glReadPixels(0, 0, 256, 256, GL_STENCIL_INDEX, GL_UNSIGNED_BYTE, p);
> piglit_present_results();
>
> /* we hardcode 129 in the shader */
> - if (p[0] != 129)
> - pass = GL_F
For certain hardware, the underlying memory format of the buffer is weird.
Comparing all the data is essential for finding bugs on that hardware.
Cc: Dave Airlie
Signed-off-by: Ben Widawsky
---
.../glsl-fs-shader-stencil-export.c| 14 --
1 file changed, 8 ins
