Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

2016-11-04 Thread Dylan Baker
Quoting Brian Paul (2016-11-04 16:02:38) > On 11/04/2016 02:49 PM, Dylan Baker wrote: > > Quoting Brian Paul (2016-11-04 13:18:21) > >> On 11/04/2016 01:49 PM, Dylan Baker wrote: > > [snip] > >> > >> This works, but > >> 1. seems like a lot of duplicated code. > >> 2. How about a simpler error mess

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

2016-11-04 Thread Brian Paul
On 11/04/2016 02:49 PM, Dylan Baker wrote: Quoting Brian Paul (2016-11-04 13:18:21) On 11/04/2016 01:49 PM, Dylan Baker wrote: [snip] This works, but 1. seems like a lot of duplicated code. 2. How about a simpler error message like: "Unable to open '%s'" But that's not the problem. The func

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

2016-11-04 Thread Dylan Baker
Quoting Brian Paul (2016-11-04 13:18:21) > On 11/04/2016 01:49 PM, Dylan Baker wrote: [snip] > > This works, but > 1. seems like a lot of duplicated code. > 2. How about a simpler error message like: "Unable to open '%s'" But that's not the problem. The function that it's failing in is responsibl

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

2016-11-04 Thread Brian Paul
On 11/04/2016 01:49 PM, Dylan Baker wrote: Currently if there is a typo in a filename (which piglit uses to determine if a particular result can be loaded) then a message about an unsupported backend will be generated. Obviously, the more common reason for this error is a typo or pointing at the

[Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

2016-11-04 Thread Dylan Baker
Currently if there is a typo in a filename (which piglit uses to determine if a particular result can be loaded) then a message about an unsupported backend will be generated. Obviously, the more common reason for this error is a typo or pointing at the wrong directory, not that you've tried to loa