On Wed, Oct 29, 2014 at 4:46 PM, Jose Fonseca wrote:
>> Don't cast malloc.
>
> I did it out of habit, as these casts are required on C++ code (or one you'd
> get "error: invalid conversion from ‘void*’ to ‘GLfloat*’").
Yep. It's a tell of a C++ programmer. :)
Along with preincrementing the iter
Sent: 29 October 2014 21:17
To: Jose Fonseca
Cc: piglit; Brian Paul
Subject: Re: [Piglit] [PATCH 2/2] gl-1.0-readpixsanity: Eliminate use of
variable length arrays.
On Wed, Oct 29, 2014 at 4:48 AM, wrote:
> From: José Fonseca
>
> Non-standard GCC extension.
>
On Wed, Oct 29, 2014 at 4:48 AM, wrote:
> From: José Fonseca
>
> Non-standard GCC extension.
> ---
> tests/spec/gl-1.0/readpix.c | 64
> ++---
> 1 file changed, 37 insertions(+), 27 deletions(-)
>
> diff --git a/tests/spec/gl-1.0/readpix.c b/tests/spec/g
On Wed, 2014-10-29 at 16:38 +, Jose Fonseca wrote:
> On 29/10/14 16:20, Jan Vesely wrote:
> > On Wed, 2014-10-29 at 11:48 +, jfons...@vmware.com wrote:
> >> From: José Fonseca
> >>
> >> Non-standard GCC extension.
> >
> > just FYI, it's not GCC extension, it's c99 standard.
>
> I think yo
On 29/10/14 16:20, Jan Vesely wrote:
On Wed, 2014-10-29 at 11:48 +, jfons...@vmware.com wrote:
From: José Fonseca
Non-standard GCC extension.
just FYI, it's not GCC extension, it's c99 standard.
I think you're right.
I assumed it was not standard because per
https://gcc.gnu.org/onlin
On Wed, 2014-10-29 at 11:48 +, jfons...@vmware.com wrote:
> From: José Fonseca
>
> Non-standard GCC extension.
just FYI, it's not GCC extension, it's c99 standard.
maybe we can use more msvc compatible set of gcc flags (-std=c89
-pedantic? ) for code that needs to compile in windows
jan
>
On 10/29/2014 05:48 AM, jfons...@vmware.com wrote:
From: José Fonseca
Non-standard GCC extension.
---
For both,
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
From: José Fonseca
Non-standard GCC extension.
---
tests/spec/gl-1.0/readpix.c | 64 ++---
1 file changed, 37 insertions(+), 27 deletions(-)
diff --git a/tests/spec/gl-1.0/readpix.c b/tests/spec/gl-1.0/readpix.c
index 7ee0be9..26f44a6 100644
--- a/tests/s
