Re: [Piglit] [PATCH 2/2] shader_runner: Fix get_ints on 32-bit systems.

2016-06-08 Thread Andres Gomez
On Mon, 2016-06-06 at 16:02 -0700, Kenneth Graunke wrote: > On Monday, June 6, 2016 3:56:09 PM PDT Mark Janes wrote: > > > > Kenneth Graunke writes: > > > > > > > > The new ARB_vertex_attrib_64bit tests specify integer uniform > > > values > > > as hex, such as 0xc21620c5.  As an integer value,

Re: [Piglit] [PATCH 2/2] shader_runner: Fix get_ints on 32-bit systems.

2016-06-07 Thread Antía Puentes
On lun, 2016-06-06 at 16:02 -0700, Kenneth Graunke wrote: > On Monday, June 6, 2016 3:56:09 PM PDT Mark Janes wrote: > > > > Kenneth Graunke writes: > > > > > > > > The new ARB_vertex_attrib_64bit tests specify integer uniform > > > values > > > as hex, such as 0xc21620c5.  As an integer value,

Re: [Piglit] [PATCH 2/2] shader_runner: Fix get_ints on 32-bit systems.

2016-06-06 Thread Kenneth Graunke
On Monday, June 6, 2016 3:56:09 PM PDT Mark Janes wrote: > Kenneth Graunke writes: > > > The new ARB_vertex_attrib_64bit tests specify integer uniform values > > as hex, such as 0xc21620c5. As an integer value, this is beyond LONG_MAX > > on 32-bit systems. The intent is to parse it as an unsig

Re: [Piglit] [PATCH 2/2] shader_runner: Fix get_ints on 32-bit systems.

2016-06-06 Thread Mark Janes
Kenneth Graunke writes: > The new ARB_vertex_attrib_64bit tests specify integer uniform values > as hex, such as 0xc21620c5. As an integer value, this is beyond LONG_MAX > on 32-bit systems. The intent is to parse it as an unsigned hex value and > bitcast it. > > However, we still need to handl

[Piglit] [PATCH 2/2] shader_runner: Fix get_ints on 32-bit systems.

2016-06-06 Thread Kenneth Graunke
The new ARB_vertex_attrib_64bit tests specify integer uniform values as hex, such as 0xc21620c5. As an integer value, this is beyond LONG_MAX on 32-bit systems. The intent is to parse it as an unsigned hex value and bitcast it. However, we still need to handle parsing values with negative signs.