Re: [Piglit] [PATCH 2/3] tests: Use FE_UPWARD only if its defined in fenv.h

2018-11-30 Thread Burton, Ross
Okay, revised patch submitted, which hopefully does the right thing this time. Ross On Fri, 30 Nov 2018 at 15:54, Burton, Ross wrote: > > Erm, yeah, sorry about that. Grabbing a patch that we've been > shipping without actually looking at it. > > Ross > On Fri, 30 Nov 2018 at 12:37, Eric Engestr

Re: [Piglit] [PATCH 2/3] tests: Use FE_UPWARD only if its defined in fenv.h

2018-11-30 Thread Burton, Ross
Erm, yeah, sorry about that. Grabbing a patch that we've been shipping without actually looking at it. Ross On Fri, 30 Nov 2018 at 12:37, Eric Engestrom wrote: > > On Friday, 2018-11-30 10:45:05 +, Ross Burton wrote: > > From: Khem Raj > > > > On ARM, musl does not define FE_* when arch doe

Re: [Piglit] [PATCH 2/3] tests: Use FE_UPWARD only if its defined in fenv.h

2018-11-30 Thread Eric Engestrom
On Friday, 2018-11-30 10:45:05 +, Ross Burton wrote: > From: Khem Raj > > On ARM, musl does not define FE_* when arch does not have > VFP, (which is right interpretation), therefore check if > it is defined before using it. > > Fixes errors like: > > tests/general/roundmode-pixelstore.c:82:

[Piglit] [PATCH 2/3] tests: Use FE_UPWARD only if its defined in fenv.h

2018-11-30 Thread Ross Burton
From: Khem Raj On ARM, musl does not define FE_* when arch does not have VFP, (which is right interpretation), therefore check if it is defined before using it. Fixes errors like: tests/general/roundmode-pixelstore.c:82:19: error: 'FE_UPWARD' undeclared (first use in this function) ret = fes