Re: [Piglit] [PATCH 3/3] ext_transform_feedback: use default window size

2014-06-05 Thread Jose Fonseca
- Original Message - > On 06/05/2014 05:51 AM, Jose Fonseca wrote: > > Looks ok. Though I still wonder if it wouldn't be to do as I suggested in > > another similar review request -- to treat config.window_width/height as > > "minimum" values, as opposed to maximum values. That is, some

Re: [Piglit] [PATCH 3/3] ext_transform_feedback: use default window size

2014-06-05 Thread Brian Paul
On 06/05/2014 05:51 AM, Jose Fonseca wrote: Looks ok. Though I still wonder if it wouldn't be to do as I suggested in another similar review request -- to treat config.window_width/height as "minimum" values, as opposed to maximum values. That is, something along the lines of diff --git a/te

Re: [Piglit] [PATCH 3/3] ext_transform_feedback: use default window size

2014-06-05 Thread Jose Fonseca
Looks ok. Though I still wonder if it wouldn't be to do as I suggested in another similar review request -- to treat config.window_width/height as "minimum" values, as opposed to maximum values. That is, something along the lines of diff --git a/tests/util/piglit-framework-gl.c b/tests/util/

[Piglit] [PATCH 3/3] ext_transform_feedback: use default window size

2014-06-04 Thread Brian Paul
These tests need no other changes. Again, this is to avoid the "spurious window resize" issue on Windows when the initial window size is too small. --- tests/spec/ext_transform_feedback/alignment.c |3 --- tests/spec/ext_transform_feedback/api-errors.c |3 --- tests/spe