Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 6:12 PM, Dylan Baker wrote: > [snip] > >> > > >> > > + for test_id, x in enumerate(test_vectors, 2): > >> > While I'm not totally against this, I'd like you to consider just > >> > adding the 2 below to test_id. I believe that I'm fairly knowledgeable > >> > about python bu

Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Dylan Baker
[snip] > > > > > +for test_id, x in enumerate(test_vectors, 2): > > While I'm not totally against this, I'd like you to consider just > > adding the 2 below to test_id. I believe that I'm fairly knowledgeable > > about python builtins, and I still had to look that up -- I had never > > come acr

Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Dylan Baker
On Monday, May 19, 2014 17:56:41 Ilia Mirkin wrote: > On Mon, May 19, 2014 at 5:43 PM, Dylan Baker wrote: > > This combines the two loops into a single loop using enumerate. This > > should be a little faster since we loop over the data only once, and > > since it uses enumerate instead of math. >

Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 5:43 PM, Dylan Baker wrote: > This combines the two loops into a single loop using enumerate. This > should be a little faster since we loop over the data only once, and > since it uses enumerate instead of math. > > Signed-off-by: Dylan Baker > --- > generated_tests/gen_

[Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Dylan Baker
This combines the two loops into a single loop using enumerate. This should be a little faster since we loop over the data only once, and since it uses enumerate instead of math. Signed-off-by: Dylan Baker --- generated_tests/gen_const_builtin_equal_tests.py | 17 +++-- 1 file change