Re: [Piglit] [PATCH 4/7] arb_shading_language_420pack: More multiple layout qualifiers in a single declaration tests

2016-10-24 Thread Andres Gomez
On Mon, 2016-10-24 at 11:44 +1100, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: [snip] > > diff --git a/tests/spec/arb_shading_language_420pack/compiler/layout- > > qualifiers/multiple-local_size-in-single-declaration-mismatch.co

Re: [Piglit] [PATCH 4/7] arb_shading_language_420pack: More multiple layout qualifiers in a single declaration tests

2016-10-23 Thread Timothy Arceri
On Mon, 2016-10-24 at 11:44 +1100, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri I forgot to point out I had one comment below :) > > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > > > > Added tests for the layout-qualifier-names "max_vertices", > > "invocations", "vertices" a

Re: [Piglit] [PATCH 4/7] arb_shading_language_420pack: More multiple layout qualifiers in a single declaration tests

2016-10-23 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > Added tests for the layout-qualifier-names "max_vertices", > "invocations", "vertices" and "local_size_[x|y|z]" which may have > redeclarations but all of them enforce that a redeclaration holds the > same value

[Piglit] [PATCH 4/7] arb_shading_language_420pack: More multiple layout qualifiers in a single declaration tests

2016-10-22 Thread Andres Gomez
Added tests for the layout-qualifier-names "max_vertices", "invocations", "vertices" and "local_size_[x|y|z]" which may have redeclarations but all of them enforce that a redeclaration holds the same value than in the previous declaration(s). These tests check that multiple appearances of a layout