Re: [Piglit] [PATCH 7/7] summary: Fold __generate_lists into __init__

2013-10-13 Thread Kenneth Graunke
On 09/27/2013 02:39 PM, Dylan Baker wrote: > Since there is nothign special about __generate_lists anymore (it just nothing > does the same thing all the time), just fold it back into the > constructor and save on having to call it. A trivial amount of cost, so not worth it from an optimization

Re: [Piglit] [PATCH 7/7] summary: Fold __generate_lists into __init__

2013-09-27 Thread Dylan Baker
On Friday, September 27, 2013 05:29:57 PM Ken Phillis Jr wrote: > This patch looks good. The only suggest I have is to double check spelling > on the commit logs and comments... For example, The word "nothign" should > be nothing. > > On Fri, Sep 27, 2013 at 4:39 PM, Dylan Baker wrote: > > Since

[Piglit] [PATCH 7/7] summary: Fold __generate_lists into __init__

2013-09-27 Thread Dylan Baker
Since there is nothign special about __generate_lists anymore (it just does the same thing all the time), just fold it back into the constructor and save on having to call it. Signed-off-by: Dylan Baker --- framework/summary.py | 26 -- 1 file changed, 4 insertions(+), 22