Re: [Piglit] [PATCH v2] Porting the two sided stencil extension tests from Glean to Piglit.

Hello, I am currently having this Compilation Error with this test. Can any one give me an idea on how to fix this? Thanks, Juliet On Fri, Sep 25, 2015 at 11:03 PM, Juliet Fru wrote: > This test replaces the original glean tstencil2.cpp test. >

[Piglit] [PATCH v2] Porting the two sided stencil extension tests from Glean to Piglit.

This test replaces the original glean tstencil2.cpp test. --- tests/spec/gl-2.0/ two-sided-stencil.c | 743 + tests/spec/gl-2.0/CMakeLists.gl.txt| 1 + 2 files changed, 744 insertions(+) create mode 100644 tests/spec/gl-2.0/ two-sided-stencil.c diff --git

Re: [Piglit] [PATCH v2] Porting the two sided stencil extension tests from Glean to Piglit.

On Fri, Sep 25, 2015 at 7:48 PM, Dylan Baker wrote: > On Fri, Sep 25, 2015 at 11:03:05PM +0100, Juliet Fru wrote: >> This test replaces the original glean tstencil2.cpp test. >> --- >> tests/spec/gl-2.0/ two-sided-stencil.c | 743 >> + >>

Re: [Piglit] [PATCH v2] Porting the two sided stencil extension tests from Glean to Piglit.

On Fri, Sep 25, 2015 at 11:03:05PM +0100, Juliet Fru wrote: > This test replaces the original glean tstencil2.cpp test. > --- > tests/spec/gl-2.0/ two-sided-stencil.c | 743 > + > tests/spec/gl-2.0/CMakeLists.gl.txt| 1 + > 2 files changed, 744 insertions(+)

Re: [Piglit] [PATCH v2] Porting the two sided stencil extension tests from Glean to Piglit.

Hi Juliet, This looks pretty good overall. Assorted comments below. Also, for Piglit we use 8-column tabs, not spaces, for indentation. Can you fix that too? Thanks! -Brian On Fri, Sep 25, 2015 at 4:03 PM, Juliet Fru wrote: > This test replaces the original glean