[Piglit] [PATCH v2 1/4] pbo-read-argb8888: make it endian-safe

2016-03-29 Thread Oded Gabbay
In this test we use GL_BGRA + GL_UNSIGNED_BYTE. However, the probe function receives two 4-byte values to compare, expected and observed. This is wrong as the correct way to compare array_of_bytes (GL_UNSIGNED_BYTE) in an endian-safe way is by comparing memory (and not values). This patch fixes th

Re: [Piglit] [PATCH v2 1/4] pbo-read-argb8888: make it endian-safe

2016-03-29 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Mar 29, 2016 at 5:06 AM, Oded Gabbay wrote: > In this test we use GL_BGRA + GL_UNSIGNED_BYTE. However, the probe > function receives two 4-byte values to compare, expected and > observed. This is wrong as the correct way to compare > array_of_bytes (GL_UNSIGNED_B

Re: [Piglit] [PATCH v2 1/4] pbo-read-argb8888: make it endian-safe

2016-03-30 Thread Michel Dänzer
On 29.03.2016 18:06, Oded Gabbay wrote: > In this test we use GL_BGRA + GL_UNSIGNED_BYTE. However, the probe > function receives two 4-byte values to compare, expected and > observed. This is wrong as the correct way to compare > array_of_bytes (GL_UNSIGNED_BYTE) in an endian-safe way is by compari

Re: [Piglit] [PATCH v2 1/4] pbo-read-argb8888: make it endian-safe

2016-03-31 Thread Oded Gabbay
On Wed, Mar 30, 2016 at 4:49 AM, Michel Dänzer wrote: > On 29.03.2016 18:06, Oded Gabbay wrote: >> In this test we use GL_BGRA + GL_UNSIGNED_BYTE. However, the probe >> function receives two 4-byte values to compare, expected and >> observed. This is wrong as the correct way to compare >> array_of