Re: [Piglit] [PATCH v2 8/8] profile.py: Don't allow accidental reassignments of TestDict keys

2015-04-01 Thread Dylan Baker
On Mon, Mar 30, 2015 at 03:14:17PM -0400, Ilia Mirkin wrote: Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Still unsure about whether the texture size stuff needs to be fixed up, but also can't bring myself to care about it. So, I had enough coffee this morning (and I've had enough

[Piglit] [PATCH v2 8/8] profile.py: Don't allow accidental reassignments of TestDict keys

2015-03-30 Thread Dylan Baker
A common error in all.py is that two different tests are assigned to the same key value in profile.test_list. This change prevents a key from being reassigned to a new value on accident, but provides a mechanism to allow reassignment, using a context manager. This allows tests like the

Re: [Piglit] [PATCH v2 8/8] profile.py: Don't allow accidental reassignments of TestDict keys

2015-03-30 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Still unsure about whether the texture size stuff needs to be fixed up, but also can't bring myself to care about it. On Mon, Mar 30, 2015 at 2:54 PM, Dylan Baker baker.dyla...@gmail.com wrote: A common error in all.py is that two