Thanks, Dylan, Eric and Juan!
I've just pushed this changed. ☺
PS: In my Travis-CI, the job is taking ~13 min. right now.
On Mon, 2018-02-05 at 09:29 -0800, Dylan Baker wrote:
> I haven't looked too closely at this, but I like the idea of using docker to
> allow running the cmake based job.
>
>
I haven't looked too closely at this, but I like the idea of using docker to
allow running the cmake based job.
Acked-by: Dylan Baker
Quoting Andres Gomez (2018-01-31 13:11:52)
> Until now we were only running the python unit tests.
>
> It seems desirable to also check that the CMake based buil
Andres Gomez writes:
> Until now we were only running the python unit tests.
>
> It seems desirable to also check that the CMake based build compiles
> successfully. We do that now using docker.
>
> The docker build can be tweaked with some environment variables and,
> also, be stored in the dock
Until now we were only running the python unit tests.
It seems desirable to also check that the CMake based build compiles
successfully. We do that now using docker.
The docker build can be tweaked with some environment variables and,
also, be stored in the docker hub if desired. Check the change