Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-03 Thread Timothy Arceri
On Mon, 2015-11-02 at 16:20 +, Emil Velikov wrote: > On 1 November 2015 at 22:53, Timothy Arceri > wrote: > > On Tue, 2015-10-27 at 15:34 +, Emil Velikov wrote: > > > Hi all, > > > > Hi Emil, > > > > A few comments: > > > > - Patches 1-4 all have extra

Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-02 Thread Emil Velikov
On 2 November 2015 at 16:20, Ilia Mirkin wrote: > On Mon, Nov 2, 2015 at 11:14 AM, Emil Velikov > wrote: >> On 1 November 2015 at 22:59, Ilia Mirkin wrote: >>> On Sun, Nov 1, 2015 at 5:53 PM, Timothy Arceri >>>

Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-02 Thread Emil Velikov
On 1 November 2015 at 22:59, Ilia Mirkin wrote: > On Sun, Nov 1, 2015 at 5:53 PM, Timothy Arceri > wrote: >> On Tue, 2015-10-27 at 15:34 +, Emil Velikov wrote: >> - Your a bunch or your tests require the extension and also the glsl verion

Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-02 Thread Ilia Mirkin
On Mon, Nov 2, 2015 at 11:14 AM, Emil Velikov wrote: > On 1 November 2015 at 22:59, Ilia Mirkin wrote: >> On Sun, Nov 1, 2015 at 5:53 PM, Timothy Arceri >> wrote: >>> On Tue, 2015-10-27 at 15:34 +, Emil Velikov

Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-02 Thread Emil Velikov
On 1 November 2015 at 22:53, Timothy Arceri wrote: > On Tue, 2015-10-27 at 15:34 +, Emil Velikov wrote: >> Hi all, > > Hi Emil, > > A few comments: > > - Patches 1-4 all have extra whitespace > Did not notice these. Thanks will fix. > - Your a bunch or your

Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-02 Thread Ilia Mirkin
On Mon, Nov 2, 2015 at 11:40 AM, Emil Velikov wrote: > On 2 November 2015 at 16:20, Ilia Mirkin wrote: >> On Mon, Nov 2, 2015 at 11:14 AM, Emil Velikov >> wrote: >>> On 1 November 2015 at 22:59, Ilia Mirkin

Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-01 Thread Timothy Arceri
On Tue, 2015-10-27 at 15:34 +, Emil Velikov wrote: > Hi all, Hi Emil, A few comments: - Patches 1-4 all have extra whitespace - Your a bunch or your tests require the extension and also the glsl verion to be 4.30 where we know the extension will exist. You should instead change the glsl

Re: [Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-11-01 Thread Ilia Mirkin
On Sun, Nov 1, 2015 at 5:53 PM, Timothy Arceri wrote: > On Tue, 2015-10-27 at 15:34 +, Emil Velikov wrote: > - Your a bunch or your tests require the extension and also the glsl verion to > be 4.30 where we know the extension will exist. You should instead change

[Piglit] [PATCHv2 0/5] arb-enhanced-layouts: explicit-offset piglits

2015-10-27 Thread Emil Velikov
Hi all, Some update over the previous round - Add the missing S in enhanced-layouts :) - The uniform tests are prefixed with UBO. - SSBO tests are added in the respective hunks. - The final (negative link) test has been added. Note: all of these are written based on the spec alone and