Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Brian Paul
On 02/07/2013 08:35 AM, Brian Paul wrote: OK, I thought you had git-write ability. I'll commit/push soon. Actually, I found a few more issues with the code. The piglit_swap_buffers() call should be moved after the probing code. And you should use piglit_present_results() instead. After a s

Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Brian Paul
OK, I thought you had git-write ability. I'll commit/push soon. -Brian On 02/07/2013 08:23 AM, Tom Gall wrote: Hi Brian, It has your reviewed by. Ideally I was looking for it to be committed unless of course there's something egregious about it that we both missed. On Thu, Feb 7, 2013 at 9:

Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Tom Gall
Hi Brian, It has your reviewed by. Ideally I was looking for it to be committed unless of course there's something egregious about it that we both missed. On Thu, Feb 7, 2013 at 9:04 AM, Brian Paul wrote: > LGTM. Are you asking for another review or do you need someone to > commit/push it for

Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Brian Paul
LGTM. Are you asking for another review or do you need someone to commit/push it for you? -Brian On 02/06/2013 03:38 PM, Tom Gall wrote: It was a little over two weeks ago when v2 of these 2 patches to port ttexrect to piglit and remove it from glean were posted. It has a Reviewed-by: Brian

[Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-06 Thread Tom Gall
It was a little over two weeks ago when v2 of these 2 patches to port ttexrect to piglit and remove it from glean were posted. It has a Reviewed-by: Brian Paul Any reason why this shouldn't go in? Thanks. -- Forwarded message -- From: Brian Paul Date: Mon, Jan 21, 2013 at 4:46