Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-08 Thread Andrea Canciani
On Sat, Jan 8, 2011 at 12:15 PM, Soeren Sandmann sandm...@cs.au.dk wrote: Iterators gets initialized with a buffer which can always contain at least width pixels. This is sufficient for current image types, but future image types might need additional space. Would it be possible to have the

Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-08 Thread Soeren Sandmann
Iterators gets initialized with a buffer which can always contain at least width pixels. This is sufficient for current image types, but future image types might need additional space. Would it be possible to have the general_composite_rect ask to the iterator about how much memory it will

Re: [Pixman] Making ref counting thread safe

2011-01-08 Thread Soeren Sandmann
Siarhei Siamashka siarhei.siamas...@gmail.com writes: This problem looks bad enough to me, or at least makes me feel uneasy. Changing how the caching works could also cause some weird problems in the future unless everything is carefully taken into account. Also various tools like helgrind

[Pixman] [PATCH 03/15] Eliminate the _pixman_image_store_scanline_32/64 functions.

2011-01-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com They were only called from next_line_write_narrow/wide, so they could simply be absorbed into those functions. --- pixman/pixman-bits-image.c | 79 pixman/pixman-private.h| 17 - 2 files

[Pixman] [PATCH 05/15] Virtualize iterator initialization

2011-01-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com Make src_iter_init() and dest_iter_init() virtual methods in the implementation struct. This allows individual implementations to plug in their own CPU specific scanline fetchers. --- pixman/pixman-general.c| 52 +++

[Pixman] [PATCH 06/15] Use an iterator in pixman_image_get_solid().

2011-01-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com This is a step towards getting rid of the _pixman_image_get_scanline_32/64() functions. --- pixman/pixman-arm-common.h |9 ++--- pixman/pixman-fast-path.c | 22 +++--- pixman/pixman-image.c | 12 +---

[Pixman] [PATCH 14/15] Turn on testing for destination transformation

2011-01-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com --- test/alphamap.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/test/alphamap.c b/test/alphamap.c index 9fb8969..554b309 100644 --- a/test/alphamap.c +++ b/test/alphamap.c @@ -165,20 +165,17 @@ run_test (int s,

[Pixman] [PATCH 15/15] Fix destination fetching.

2011-01-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com When fetching from destinations, we need to ignore transformations, repeat and filtering. Currently we don't ignore them, which means all kinds of bad things can happen. This bug fixes this problem by directly calling the scanline fetchers for