Søren Sandmann <sandm...@cs.au.dk> kirjoitti 14.7.2012 kello 12.02:
> Antti Lankila <alank...@bel.fi> writes: > >> From 693af3995b46d531342d68ac83b794113d0a7a90 Mon Sep 17 00:00:00 2001 >> From: "Antti S. Lankila" <alank...@bel.fi> >> Date: Sun, 10 Jun 2012 22:31:38 +0300 >> Subject: [PATCH] Add support for sRGB surfaces > > This mostly looks good to me. The main highlevel comment I have is that > I'd like the changes to composite.c and the addition of srgb-test.c to > happen in separate commits. Okay. I'll start splitting the work into pieces. I'll submit each as a separate mail/patch as I get the changes done. Here's the first, probably the least controversial change: >> - pixman_color_t fill; >> color_t expected, tdst, tsrc, tmsk; >> pixel_checker_t checker; >> - pixman_image_t *solid; >> - >> - /* Initialize dst */ >> - compute_pixman_color (dst->color, &fill); >> - solid = pixman_image_create_solid_fill (&fill); >> - pixman_image_composite32 (PIXMAN_OP_SRC, solid, NULL, dst->image, >> - 0, 0, 0, 0, 0, 0, dst->size, dst->size); >> - pixman_image_unref (solid); > > Where did this initialization go? If this is an unrelated bugfix, it > should go in its own commit. I noticed that the image_init() already performed these steps, so it was unnecessary. The dst is always initialized as a real surface instead of a fill thanks to the constant 1 passed as size, but perhaps that was not the case sometime earlier.
0001-Remove-unnecessary-dst-initialization.patch
Description: Binary data
-- Antti
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
