On Thu, Dec 19, 2013 at 5:20 PM, Nemanja Lukic wrote:
> Hi YunQiang Su,
>
> Yes, you are right, these symbols shouldn't be exported.
> This is due to the fact that some optimizations were compiled (not executed)
With this patch, if I use mips32r2 option to build for o32, will these
symbols still
Hi YunQiang Su,
Yes, you are right, these symbols shouldn't be exported.
This is due to the fact that some optimizations were compiled (not executed)
where they shouldn't.
Please find attached fix, that solves this issue.
In the mean time I'll submit this patch on main pixman repository.
Thanks
Hi YunQiang Su,
Yes, if you use mips32r2 option to build for o32, these symbols will be
exported (since optimizations will be compiled).
And, once again, you are right, these symbols are internal API and shouldn't
be exported. We need to fix this.
I'm maintaining MIPS optimizations for Pixman rep
Hi YunQiang Su,
Attached is solution for unwanted symbol visibility.
I'll upstream both patches soon.
Thanks,
Nemanja Lukic
-Original Message-
From: Nemanja Lukic [mailto:nemanja.lu...@rt-rk.com]
Sent: Thursday, December 19, 2013 12:30 PM
To: 'Yunqiang Su'
Cc: 'pixman@lists.freedesktop.
On Thu, 19 Dec 2013 17:21:16 +0100
"Nemanja Lukic" wrote:
> Hi YunQiang Su,
>
> Attached is solution for unwanted symbol visibility.
> I'll upstream both patches soon.
> diff --git a/pixman/pixman-mips-dspr2-asm.h b/pixman/pixman-mips-dspr2-asm.h
> index cab122d..718737e 100644
> --- a/pixman/p
Hi
I just analyzed some application using valgrind. I am getting warnings
like this:
==6514== Conditional jump or move depends on uninitialised value(s)
==6514==at 0x3C8DA72B04: sse2_combine_over_u (pixman-sse2.c:646)
==6514==by 0x3C8DA57CE3: general_composite_rect
(pixman-general.c:199)
On Thu, 19 Dec 2013 22:01:46 +0100
Christian Stadelmann wrote:
> Hi
>
> I just analyzed some application using valgrind. I am getting warnings
> like this:
>
> ==6514== Conditional jump or move depends on uninitialised value(s)
> ==6514==at 0x3C8DA72B04: sse2_combine_over_u (pixman-sse2.c:6
On Thu, 19 Dec 2013 19:08:26 +0200
Siarhei Siamashka wrote:
> On Thu, 19 Dec 2013 17:21:16 +0100
> "Nemanja Lukic" wrote:
>
> > Hi YunQiang Su,
> >
> > Attached is solution for unwanted symbol visibility.
> > I'll upstream both patches soon.
>
> > diff --git a/pixman/pixman-mips-dspr2-asm.h b
