Re: [Pixman] Pixman release schedule

2015-09-21 Thread Oded Gabbay
On Mon, Sep 21, 2015 at 8:52 AM, Siarhei Siamashka wrote: > On Fri, 18 Sep 2015 13:39:52 +0300 > Pekka Paalanen wrote: > >> On Fri, 18 Sep 2015 08:36:09 +0300 >> Oded Gabbay wrote: >> >> > On Fri, Sep 18, 2015 at 6:08 AM,

Re: [Pixman] [PATCH] Fix arithmetic overflow in pointer arithmetic in ‘general_composite_rect’

2015-09-21 Thread Søren Sandmann
Sure. The extra width check can't harm. Søren On Mon, Sep 21, 2015 at 10:10 PM, Siarhei Siamashka < siarhei.siamas...@gmail.com> wrote: > On Mon, 21 Sep 2015 16:43:46 -0400 > Søren Sandmann wrote: > > > Regardless of who ends up listed as the patch author, this is

Re: [Pixman] [PATCH] Fix arithmetic overflow in pointer arithmetic in ‘general_composite_rect’

2015-09-21 Thread Siarhei Siamashka
On Mon, 21 Sep 2015 21:34:51 +0200 l...@gnu.org (Ludovic Courtès) wrote: > Siarhei Siamashka skribis: > > > Sorry, I forgot to mention > > http://cgit.freedesktop.org/pixman/tree/README?id=pixman-0.33.2#n46 > > > > We would also need a commit message for the

Re: [Pixman] [PATCH] Fix arithmetic overflow in pointer arithmetic in ‘general_composite_rect’

2015-09-21 Thread Siarhei Siamashka
On Mon, 21 Sep 2015 16:43:46 -0400 Søren Sandmann wrote: > Regardless of who ends up listed as the patch author, this is > > Reviewed-by: soren.sandm...@gmail.com > > Søren Thanks! Is your Reviewed-by still valid after adding an extra "width <= 0" check to the patch?

[Pixman] [PATCH] Fix arithmetic overflow in pointer arithmetic in ‘general_composite_rect’

2015-09-21 Thread Ludovic Courtès
Hello, The patch below intends to fix an arithmetic overflow occurring in a pointer arithmetic context in ‘general_composite_rect’, as explained at: https://bugs.freedesktop.org/show_bug.cgi?id=92027#c6 The bug can most likely lead to a crash. In a preliminary review, Siarhei Siamashka notes

Re: [Pixman] [PATCH 1/2] Remove the 8e extra safety margin in COVER_CLIP analysis

2015-09-21 Thread Pekka Paalanen
On Mon, 21 Sep 2015 08:32:48 +0300 Siarhei Siamashka wrote: > On Fri, 11 Sep 2015 14:30:23 +0300 > Pekka Paalanen wrote: > > > From: Ben Avison > > > > As discussed in > >

Re: [Pixman] [PATCH] Fix arithmetic overflow in pointer arithmetic in ‘general_composite_rect’

2015-09-21 Thread Søren Sandmann
Regardless of who ends up listed as the patch author, this is Reviewed-by: soren.sandm...@gmail.com Søren On Sep 21, 2015 3:07 PM, "Siarhei Siamashka" wrote: > On Mon, 21 Sep 2015 17:10:36 +0200 > l...@gnu.org (Ludovic Courtès) wrote: > > > Hello, > > > > The patch

Re: [Pixman] [PATCH] vmx: implement fast path vmx_composite_over_n_8888

2015-09-21 Thread Oded Gabbay
On Thu, Sep 10, 2015 at 7:16 PM, Siarhei Siamashka wrote: > > On Thu, 10 Sep 2015 12:27:18 +0300 > Oded Gabbay wrote: > > > On Sat, Sep 5, 2015 at 10:03 PM, Oded Gabbay wrote: > > > > > > On Fri, Sep 4, 2015 at 3:39 PM,

Re: [Pixman] [PATCH] Fix arithmetic overflow in pointer arithmetic in ‘general_composite_rect’

2015-09-21 Thread Siarhei Siamashka
On Mon, 21 Sep 2015 17:10:36 +0200 l...@gnu.org (Ludovic Courtès) wrote: > Hello, > > The patch below intends to fix an arithmetic overflow occurring in a > pointer arithmetic context in ‘general_composite_rect’, as explained at: > > https://bugs.freedesktop.org/show_bug.cgi?id=92027#c6

Re: [Pixman] Benchmarked: [PATCH 1/4] Change conditions for setting FAST_PATH_SAMPLES_COVER_CLIP flags

2015-09-21 Thread Pekka Paalanen
On Sun, 20 Sep 2015 15:47:01 +0300 Oded Gabbay wrote: > On Sun, Sep 20, 2015 at 1:22 PM, Oded Gabbay wrote: > > On Wed, Sep 16, 2015 at 2:25 PM, Pekka Paalanen wrote: > >> The series as benchmarked is available at: > >>