On Mon, Sep 21, 2015 at 10:07 PM, Søren Sandmann
wrote:
> Sure. The extra width check can't harm.
>
Actually it can, because it implies that such values *can* arrive at this
function, leading programmers to add tests to the calling functions, thus
leading to a large
On Tue, 22 Sep 2015 12:43:25 +0100
Ben Avison wrote:
> Each of the aligns can only add a maximum of 15 bytes to the space
> requirement. This permits some edge cases to use the stack buffer where
> previously it would have deduced that a heap buffer was required.
> ---
>
On Tue, Sep 22, 2015 at 4:25 AM, Siarhei Siamashka
wrote:
> As https://bugs.freedesktop.org/show_bug.cgi?id=92027#c6 explains,
> the stack is allocated at the very top of the process address space
> in some configurations (32-bit x86 systems with ASLR disabled).
> And
Each of the aligns can only add a maximum of 15 bytes to the space
requirement. This permits some edge cases to use the stack buffer where
previously it would have deduced that a heap buffer was required.
---
This is an update of my previous patch (now posted over a year ago):
A new pixman release 0.32.8 is now available. This is a stable release that
contains an important bug fix (buffer overflow), which can affect 32-bit
systems.
I recommend to all the distributions that still use the 0.32.x version to
upgrade to this release as soon as possible.
For those
Oded Gabbay skribis:
> I tested the patch and it fixed the crash on my computer.
>
> I pushed it to master:
> 4297e90..8b49d4b master -> master
>
> and to 0.32 branch:
> d6a4a56..204fcd2 0.32 -> 0.32
Great, thanks to all of you.
Ludo’.
On Mon, 21 Sep 2015 06:32:48 +0100, Siarhei Siamashka
wrote:
Since we are trying to justify the 8e extra safety margin removal in
the context of this patch, this is what I wanted to see explained in
the commit message. But maybe I'm just bad at math and it was
On Mon, 21 Sep 2015 14:22:53 +0300
Oded Gabbay wrote:
> On Thu, Sep 10, 2015 at 7:16 PM, Siarhei Siamashka
> wrote:
> >
> > On Thu, 10 Sep 2015 12:27:18 +0300
> > Oded Gabbay wrote:
> >
> > > On Sat, Sep 5, 2015 at
On Tue, Sep 22, 2015 at 3:59 PM, Pekka Paalanen wrote:
> On Mon, 21 Sep 2015 14:22:53 +0300
> Oded Gabbay wrote:
>
>> On Thu, Sep 10, 2015 at 7:16 PM, Siarhei Siamashka
>> wrote:
>> >
>> > On Thu, 10 Sep 2015 12:27:18