Re: [Pixman] [PATCH 03/13] pixman-image: Added GNUPLOT_OUTPUT compile-time option to view filters in gnuplot

On Mon, Jan 4, 2016 at 7:34 PM, Bill Spitzak wrote: > > > On Mon, Jan 4, 2016 at 3:25 AM, Oded Gabbay wrote: >> >> On Mon, Jan 4, 2016 at 5:12 AM, wrote: >> > From: Bill Spitzak >> > >> > If GNUPLOT_OUTPUT is set,

Re: [Pixman] [PATCH 03/13] pixman-image: Added GNUPLOT_OUTPUT compile-time option to view filters in gnuplot

On Mon, Jan 4, 2016 at 5:12 AM, wrote: > From: Bill Spitzak > > If GNUPLOT_OUTPUT is set, then you can pipe the output of a pixman-using > program > to gnuplot and get a continuously-updated plot of the horizontal filter. This > works well with demos/scale

Re: [Pixman] [PATCH 01/13] demos/scale: Compute filter size using boundary of xformed ellipse, not rectangle

On Mon, Jan 4, 2016 at 5:12 AM, wrote: > From: Bill Spitzak > > This is much more accurate and less blurry. In particular the filtering does > not change as the image is rotated. You forgot to sign-off this patch. > --- > demos/scale.c | 102 >

Re: [Pixman] [PATCH 04/13] pixman-filter: Consistency in arg names to integral ()

On Mon, Jan 4, 2016 at 11:25 AM, Oded Gabbay wrote: > On Mon, Jan 4, 2016 at 5:12 AM, wrote: >> From: Bill Spitzak >> >> Rename kernel1/2 to reconstruct/sample and use 1/scale as the >> scale argument, thus matching the names in

Re: [Pixman] [PATCH 06/13] pixman-filter: Correct Simpsons integration

On Mon, Jan 4, 2016 at 5:12 AM, wrote: > From: Bill Spitzak > > Simpsons uses cubic curve fitting, with 3 samples defining each cubic. This > makes the weights of the samples be in a pattern of 1,4,2,4,2...4,1, and then > dividing the result by 3. > > The

Re: [Pixman] [PATCH pixman] V7 implement PIXMAN_FILTER_GOOD/BEST

Hi Bill, Thanks for v7. For future reference, when you resend a patch or a patch series, I recommend that you follow the following guidelines (taken from the Linux kernel community): 1. When creating the patches with git format-patch, add the following flag: "--subject-prefix="PATCH vX". That

Re: [Pixman] [PATCH 05/13] pixman-filter: reduce amount of malloc/free/memcpy to generate filter

On Mon, Jan 4, 2016 at 5:12 AM, wrote: > From: Bill Spitzak > > Rearranged so that the entire block of memory for the filter pair > is allocated first, and then filled in. Previous version allocated > and freed two temporary buffers for each filter and did

Re: [Pixman] [PATCH 04/13] pixman-filter: Consistency in arg names to integral ()

On Mon, Jan 4, 2016 at 5:12 AM, wrote: > From: Bill Spitzak > > Rename kernel1/2 to reconstruct/sample and use 1/scale as the > scale argument, thus matching the names in other functions. > --- > pixman/pixman-filter.c | 28 ++-- >

[Pixman] [PATCH v8 03/14] pixman-image: Added enable-gnuplot config to view filters in gnuplot

From: Bill Spitzak If enable-gnuplot is configured, then you can pipe the output of a pixman-using program to gnuplot and get a continuously-updated plot of the horizontal filter. This works well with demos/scale to test the filter generation. The plot is all the different

[Pixman] [PATCH v8 05/14] pixman-filter: reduce amount of malloc/free/memcpy to generate filter

From: Bill Spitzak Rearranged so that the entire block of memory for the filter pair is allocated first, and then filled in. Previous version allocated and freed two temporary buffers for each filter and did an extra memcpy. v8: small refactor to remove the filter_width

[Pixman] [PATCH v8 pixman] implement PIXMAN_FILTER_GOOD/BEST

Changes from previous version: - gnuplot output is now a config option - Adjustment to cutoff between BEST filters for better match - Reduced subsampling of GOOD/BEST from extreme value mistakenly used ___ Pixman mailing list

[Pixman] [PATCH v8 07/14] pixman-filter: Corrections to the integral() function

From: Bill Spitzak The IMPULSE special-cases did not sample the center of the of the region. This caused it to sample the filters outside their range, and produce assymetric filters and other errors. Fixing this required changing the arguments to integral() so the correct

[Pixman] [PATCH v8 09/14] pixman-filter: refactor cubic polynominal and don't range check

From: Bill Spitzak The other filters do not check for x being in range, so there is no reason for cubic to do so. v1: initial version Signed-off-by: Bill Spitzak --- pixman/pixman-filter.c | 16 +++- 1 file changed, 7 insertions(+), 9

[Pixman] [PATCH v8 11/14] pixman-filter: Turn off subsampling for width=1 filters

From: Bill Spitzak Due to normalization these filters must all be identical (a single 1.0). Also make IMPULSE.IMPULSE produce a width=1 filter, rather than zero (which did not work). v7: Replaced earlier tests for BOX.IMPULSE Signed-off-by: Bill Spitzak

[Pixman] [PATCH v8 02/14] demos/scale: Added pulldown to choose PIXMAN_FILTER_* value

From: Bill Spitzak This allows testing of GOOD/BEST and to do comparisons between the basic filters and PIXMAN_FILTER_SEPARABLE_CONVOLUTION settings. Signed-off-by: Bill Spitzak --- demos/scale.c | 14 +- demos/scale.ui | 40

[Pixman] [PATCH v8 08/14] pixman-filter: don't range-check impulse filter

From: Bill Spitzak The other filters don't range-check, so there is no need for this one to either. It is only called with x==0. v1: initial version Signed-off-by: Bill Spitzak --- pixman/pixman-filter.c | 2 +- 1 file changed, 1 insertion(+), 1

[Pixman] [PATCH v8 04/14] pixman-filter: Consistency in arg names to integral ()

From: Bill Spitzak Rename kernel1/2 to reconstruct/sample and use 1/scale as the scale argument, thus matching the names in other functions. Signed-off-by: Bill Spitzak --- pixman/pixman-filter.c | 28 ++-- 1 file changed, 14

[Pixman] [PATCH v8 01/14] demos/scale: Compute filter size using boundary of xformed ellipse, not rectangle

From: Bill Spitzak This is much more accurate and less blurry. In particular the filtering does not change as the image is rotated. Signed-off-by: Bill Spitzak --- demos/scale.c | 102 +++--- 1 file

[Pixman] [PATCH v8 10/14] pixman-filter: Gaussian fixes

From: Bill Spitzak The SIGMA term drops out on simplification. Expanded the size slightly (from ~4.25 to 5) to make the cutoff less noticable. The filter is truncated at a value of .001 instead of .006, this new value is less than 1/2 of 1/255, rather than greater than it.

[Pixman] [PATCH v8 06/14] pixman-filter: Correct Simpsons integration

From: Bill Spitzak Simpsons uses cubic curve fitting, with 3 samples defining each cubic. This makes the weights of the samples be in a pattern of 1,4,2,4,2...4,1, and then dividing the result by 3. The previous code was using weights of 1,2,6,6...6,2,1. Since it divided by 3

[Pixman] [PATCH v8 13/14] Added big comment to filter

From: Bill Spitzak v8: first version Signed-off-by: Bill Spitzak --- pixman/pixman-filter.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index 3237036..0961cfc

[Pixman] [PATCH v8 12/14] pixman-filter: Made reconstruct==impulse and scale < 1 set scale to 1

From: Bill Spitzak This replaces settings that don't work (because the filter cannot be normalized) with something that produces an image. v7: First version with this. Previously you got lots of strange garbage filters that depended on the implementation. Signed-off-by:

Re: [Pixman] Cleaning patchwork

On Tue, 22 Dec 2015 13:14:21 -, Oded Gabbay wrote: Hi Ben, I would like to clean pixman's patchwork and you have about 20 outstanding patches. [...] [4/4] pixman-fast-path: Make bilinear cover fetcher use COVER_CLIP_TIGHT flag [3/4] armv7/mips/sse2: Make bilinear

Re: [Pixman] [PATCH 03/13] pixman-image: Added GNUPLOT_OUTPUT compile-time option to view filters in gnuplot

On Mon, Jan 4, 2016 at 3:25 AM, Oded Gabbay wrote: > On Mon, Jan 4, 2016 at 5:12 AM, wrote: > > From: Bill Spitzak > > > > If GNUPLOT_OUTPUT is set, then you can pipe the output of a pixman-using > program > > to gnuplot and get a

Re: [Pixman] [PATCH 02/13] demos/scale: Added pulldown to choose PIXMAN_FILTER_* value

On Mon, Jan 4, 2016 at 1:24 AM, Oded Gabbay wrote: > On Mon, Jan 4, 2016 at 5:12 AM, wrote: > > From: Bill Spitzak > > > > This allows testing of GOOD/BEST and to do comparisons between > > the basic filters and

Re: [Pixman] [PATCH 02/13] demos/scale: Added pulldown to choose PIXMAN_FILTER_* value

On Mon, Jan 4, 2016 at 7:37 PM, Bill Spitzak wrote: > > > On Mon, Jan 4, 2016 at 1:24 AM, Oded Gabbay wrote: >> >> On Mon, Jan 4, 2016 at 5:12 AM, wrote: >> > From: Bill Spitzak >> > >> > This allows testing of