[Pixman] [RFC 1/2] Remove seemingly unneeded comparison(s)

2016-04-24 Thread Emil Velikov
With commit ed39992564b "Use pixman_transform_point_31_16() from pixman_transform_point()" we added some strange hunks. Namely: we copy the data from the internal storage to the user vector only to compare them immediately after. Cc: Siarhei Siamashka --- Siarhei,

[Pixman] [RFC 2/2] sse2: use uintptr_t for vx/unit_x

2016-04-24 Thread Emil Velikov
Strictly speaking this is not correct, as the value itself can be signed based on the definition of pixman_fixed_t. At the same time we check if vx can be negative in some places, while in others we directly ">> 16" and use the result as an index. Obviously something isn't right here - should we

[Pixman] [PATCH 4/4] Hide the final internal function from global namespace

2016-04-24 Thread Emil Velikov
Namely _pixman_internal_only_get_implementation. This workaround is no longer needed as of last commit, so let's rename the function and make it truly internal only. Signed-off-by: Emil Velikov --- pixman/pixman-private.h | 7 ++- pixman/pixman-utils.c | 7

[Pixman] [PATCH 3/4] test: static link pixman in combiner-test

2016-04-24 Thread Emil Velikov
Analogous to an earlier commit about matrix-test Signed-off-by: Emil Velikov --- test/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/test/Makefile.am b/test/Makefile.am index f70440e..d963071 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -6,6

[Pixman] [PATCH 1/4] test: static link pixman in matrix-test

2016-04-24 Thread Emil Velikov
The test uses pixman internal symbols, which we currently export. To resolve that static link the pixman library. This is an internal only test ran at `make check' thus we are fine with the bloated binary and alike. Signed-off-by: Emil Velikov --- Afaics the Windows

[Pixman] [PATCH 2/4] Remove pixman_transform_point_31_16* from global namespace

2016-04-24 Thread Emil Velikov
These internal functions were needed by matrix-test. With the test static linking pixman (as of last commit) we no longer need to export these and we can move them back to being internal only. Signed-off-by: Emil Velikov --- pixman/pixman-matrix.c | 6 +++--- 1 file