Re: [Pixman] [PATCH 1/4] Implement floating point gradient computation

2018-12-06 Thread Maarten Lankhorst
Op 06-12-2018 om 12:03 schreef Maarten Lankhorst: > Op 05-12-2018 om 11:24 schreef Basile Clement: >> Hi, >> >> On 12/5/18 9:08 AM, Pekka Paalanen wrote: >>> On Tue, 4 Dec 2018 17:36:18 +0100 >>> Maarten Lankhorst wrote: Series looks sane, 1/4 is cleaner than my version. I would change Bpp >>

Re: [Pixman] [PATCH 1/4] Implement floating point gradient computation

2018-12-06 Thread Maarten Lankhorst
Op 05-12-2018 om 11:24 schreef Basile Clement: > Hi, > > On 12/5/18 9:08 AM, Pekka Paalanen wrote: >> On Tue, 4 Dec 2018 17:36:18 +0100 >> Maarten Lankhorst wrote: >>> Series looks sane, 1/4 is cleaner than my version. I would change Bpp >>> to cpp, or multiply by 8, since Bpp usually means bits p