[Pixman] [PATCH] Ordered dithering with blue noise, v2

2019-04-22 Thread basile-pixman
From: Basile Clement On some screens (typically low quality laptop screens), using Bayer ordered dithering has been observed to cause color changes depending on *where the gradient is rendered on the screen*, causing visible flickering when moving an image on the screen. To alleviate the issue,

Re: [Pixman] Dithering patches, v2

2019-04-22 Thread Basile Clement
There is less calculation, but the noise matrix takes up cache space (about half a modern CPU's L1) and hence increases memory pressure.  The actual performance relationship is probably hardware dependent, but on my laptop doing a quick check with patched lowlevel-blt-bench:  - Bayer is ~8% faster

Re: [Pixman] Dithering patches, v2

2019-04-22 Thread Bill Spitzak
Is the "blue noise" version actually slower than the Bayer? Seems to be doing a bit less calculation but it reading the array of weights. The removal of the need for the pattern offset seems like a win. On Mon, Apr 22, 2019 at 9:27 AM Matt Turner wrote: > On Fri, Apr 19, 2019 at 4:52 PM Bryce Ha

Re: [Pixman] Dithering patches, v2

2019-04-22 Thread Matt Turner
On Fri, Apr 19, 2019 at 4:52 PM Bryce Harrington wrote: > Inkscape would love to see Basile's dithering patches included. Our > testing shows that they make a huge quality difference for our users; > this solves a critical need. > > Mc and I have done some preliminary investigation into how to pl