[Pixman] [PATCH] build: Distinguish SKIP and FAIL on Win32

2015-12-24 Thread Andrea Canciani
: Andrea Canciani --- test/Makefile.win32 | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/test/Makefile.win32 b/test/Makefile.win32 index bdd9b7f..d38f0c0 100644 --- a/test/Makefile.win32 +++ b/test/Makefile.win32 @@ -19,26 +19,35 @@ OTHERS

Re: [Pixman] [PATCH] Allow building on Windows with cmd.exe

2015-12-23 Thread Andrea Canciani
On Wed, Dec 23, 2015 at 12:10 PM, Oded Gabbay wrote: > On Wed, Dec 23, 2015 at 1:05 PM, Andrea Canciani > wrote: > > On Tue, Dec 22, 2015 at 2:19 PM, Oded Gabbay > wrote: > >> > >> On Thu, Jun 4, 2015 at 12:02 PM, Andrea Canciani > >> wrote: > &g

[Pixman] [PATCH 4/4] build: Use `del` instead of `rm` on `cmd.exe` shells

2015-12-23 Thread Andrea Canciani
` and using the MSYS environment. Signed-off-by: Simon Richter Signed-off-by: Andrea Canciani --- Makefile.win32.common | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.win32.common b/Makefile.win32.common index a759ddc..756fc94 100644 --- a/Makefile.win32

[Pixman] [PATCH 3/4] build: Do not use `mkdir -p` on Windows

2015-12-23 Thread Andrea Canciani
` shell, except for the `clean` targets. Signed-off-by: Andrea Canciani --- Makefile.win32.common | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile.win32.common b/Makefile.win32.common index b498c2f..a759ddc 100644 --- a/Makefile.win32.common +++ b/Makefile.win32.common

[Pixman] [PATCH 1/4] build: Remove use of BUILT_SOURCES from Makefile.win32

2015-12-23 Thread Andrea Canciani
Since 3d81d89c292058522cce91338028d9b4c4a23c24 BUILT_SOURCES is not used anymore, but it was unintentionally left in Win32 Makefiles. Signed-off-by: Andrea Canciani --- Makefile.win32.common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.win32.common b

[Pixman] [PATCH 2/4] build: Avoid phony `pixman` target in test/Makefile.win32

2015-12-23 Thread Andrea Canciani
Instead of explicitly depending on "pixman" for the "all" and "check" targets, rely on the dependency to the .lib file Signed-off-by: Andrea Canciani --- test/Makefile.win32 | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/Makefi

Re: [Pixman] [PATCH] Allow building on Windows with cmd.exe

2015-12-23 Thread Andrea Canciani
On Tue, Dec 22, 2015 at 2:19 PM, Oded Gabbay wrote: > On Thu, Jun 4, 2015 at 12:02 PM, Andrea Canciani > wrote: > > The patch does not regress the mingw-based build (basically that used in > > http://cairographics.org/end_to_end_build_for_win32/ ) > > I did not manage

[Pixman] [PATCH] test: Fix fence-image-self-test on Mac

2015-10-13 Thread Andrea Canciani
On MacOS X, according to the manpage of mprotect(), "When a program violates the protections of a page, it gets a SIGBUS or SIGSEGV signal.", but fence-image-self-test was only accepting a SIGSEGV as notification of invalid access. Fixes fence-image-self-test Reviewed-by: Pekka Paalanen --- tes

[Pixman] [PATCH] test: Fix fence-image-self-test on Mac

2015-10-13 Thread Andrea Canciani
On MacOS X an out-of-bounds access to an mmap-ed region typically results in a SIGBUS, but fence-image-self-test was only accepting a SIGSEGV as notification of invalid access. Fixes fence-image-self-test --- test/fence-image-self-test.c | 12 +++- test/utils.c | 6 +++---

Re: [Pixman] Pixman not building on MacOS X 10.11

2015-10-11 Thread Andrea Canciani
On Sun, Oct 11, 2015 at 5:30 AM, Siarhei Siamashka < siarhei.siamas...@gmail.com> wrote: > On Sun, 11 Oct 2015 04:53:08 +0300 > Siarhei Siamashka wrote: > > > On Sat, 10 Oct 2015 16:03:53 -0700 > > Jeremy Huddleston Sequoia wrote: > > > > > > On Oct

[Pixman] Pixman not building on MacOS X 10.11

2015-10-10 Thread Andrea Canciani
It looks like the latest XCode cannot build pixman: $ clang --version Apple LLVM version 7.0.0 (clang-700.0.72) Target: x86_64-apple-darwin14.5.0 Thread model: posix pixman-mmx.c:100:20: error: constraint 'K' expects an integer constant expression : "y" (__A), "K" (__N)

Re: [Pixman] [PATCH] Allow building on Windows with cmd.exe

2015-06-04 Thread Andrea Canciani
t;> > --- >> > Makefile.win32.common | 14 -- >> > 1 file changed, 12 insertions(+), 2 deletions(-) >> >> Thanks for the patch. >> >> But it is a bit difficult for non-Windows folks to see if >> it makes any sense or not. So it would b

Re: [Pixman] [PATCH] Allow building on Windows with cmd.exe

2015-05-31 Thread Andrea Canciani
changed, 12 insertions(+), 2 deletions(-) > > Thanks for the patch. > > But it is a bit difficult for non-Windows folks to see if > it makes any sense or not. So it would be best if some other > Windows user could review and confirm that it works. > > I have added And

Re: [Pixman] Windows XP delay-loaded dll patch

2013-12-12 Thread Andrea Canciani
On Thu, Dec 12, 2013 at 1:11 AM, Alex Christensen < alex.christen...@flexsim.com> wrote: > My coworker Anthony and I have been working on the WinCairo port of WebKit > which includes pixman. We were having it crash when delay loading the dlls > on Windows XP because of improper usage of __declspe

[Pixman] [PATCH] test: Fix the win32 build

2013-11-11 Thread Andrea Canciani
The win32 build has no config.h, so HAVE_CONFIG_H should be checked before including it, as in utils.h. --- test/thread-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/thread-test.c b/test/thread-test.c index fa21933..0b07b26 100644 --- a/test/thread-test.c +++ b/

Re: [Pixman] [PATCH 2/2] test: Add new thread-test program

2013-10-09 Thread Andrea Canciani
0 > sandm...@cs.au.dk (Søren Sandmann) wrote: > > > Siarhei Siamashka writes: > > > > > On Wed, 09 Oct 2013 17:06:06 +0200 > > > sandm...@cs.au.dk (Søren Sandmann) wrote: > > > > > >> Andrea Canciani writes: > > >> > &g

[Pixman] [PATCH] Fix thread-test on non-OpenMP systems

2013-10-09 Thread Andrea Canciani
The non-reentrant versions of prng_* functions are thread-safe only in OpenMP-enabled builds. Fixes thread-test failing when compiled with Clang (both on Linux and on MacOS). --- test/thread-test.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/test/thread-tes

Re: [Pixman] [PATCH 2/2] test: Add new thread-test program

2013-10-09 Thread Andrea Canciani
Sorry, I didn't realize it beforehand, but I just noticed that thread-test fails on MacOS. This happens because it relies on the availability of OpenMP to have a thread-local state for the prng. Would it be ok to have each thread explicitly keep the state of its prng or is this another element that

Re: [Pixman] [PATCH 2/2] test: Add new thread-test program

2013-10-02 Thread Andrea Canciani
On Sun, Sep 29, 2013 at 10:02 PM, Søren Sandmann wrote: > Andrea Canciani writes: > > > I have some work on memleak related issues: > > > > > http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-master&id=77db90242f7b7f12c5792480a10e

Re: [Pixman] [PATCH 2/2] test: Add new thread-test program

2013-09-28 Thread Andrea Canciani
I have some work on memleak related issues: http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-master&id=77db90242f7b7f12c5792480a10eb3a448e6c55f and http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-master&id=ca41228a66fe9bbec354cdef034c144ce1619793 Do yo

[Pixman] [PATCH 2/4] Fix building of "other" programs on MSVC

2013-09-26 Thread Andrea Canciani
In d1434d112ca5cd325e4fb85fc60afd1b9e902786 the benchmarks have been extended to include other programs as well and the variable names have been updated accordingly in the autotools-based build system, but not in the MSVC one. --- test/Makefile.win32 | 6 +++--- 1 file changed, 3 insertions(+), 3

[Pixman] [PATCH 1/4] Fix build on MSVC

2013-09-26 Thread Andrea Canciani
After a4c79d695d52c94647b1aff78548e5892d616b70 the MMX and SSE2 code has some declarations after the beginning of a block, which is not allowed by MSVC. Fixes multiple errors like: pixman-mmx.c(3625) : error C2275: '__m64' : illegal use of this type as an expression pixman-sse2.c(5708) : error C

[Pixman] [PATCH 3/4] Fix build of check-formats on MSVC

2013-09-26 Thread Andrea Canciani
Fixes check-formats.obj : error LNK2019: unresolved external symbol _strcasecmp referenced in function _format_from_string check-formats.obj : error LNK2019: unresolved external symbol _snprintf referenced in function _list_operators --- test/utils.h | 5 + 1 file changed, 5 insertions(+) d

[Pixman] [PATCH 4/4] Add support for SSSE3 to the MSVC build system

2013-09-26 Thread Andrea Canciani
Handle SSSE3 just like MMX and SSE2. --- pixman/Makefile.win32 | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/pixman/Makefile.win32 b/pixman/Makefile.win32 index 57ed7a5..7b64033 100644 --- a/pixman/Makefile.win32 +++ b/pixman/Makefile.win32 @@ -

Re: [Pixman] 0.30.2 release (Was Re: [PATCH] test: Fix build on MSVC)

2013-08-01 Thread Andrea Canciani
if you want the MSVC test fix in, you should push it to master > and 0.30 very soon. > Pushed (thank you for the reminder!). Andrea > > > Søren > > > Andrea Canciani writes: > > > The MSVC compiler is very strict about variable declarations after > > st

Re: [Pixman] [cairo] help building cairo on windows

2012-09-13 Thread Andrea Canciani
On Thu, Sep 13, 2012 at 2:08 AM, Siarhei Siamashka wrote: > On Tue, 11 Sep 2012 23:45:47 +0200 > Andrea Canciani wrote: > >> On Tue, Sep 11, 2012 at 10:44 PM, Siarhei Siamashka >> wrote: >> > On Tue, 11 Sep 2012 22:25:15 +0200 >> > Andrea Canciani wrote:

Re: [Pixman] [cairo] help building cairo on windows

2012-09-11 Thread Andrea Canciani
On Tue, Sep 11, 2012 at 10:44 PM, Siarhei Siamashka wrote: > On Tue, 11 Sep 2012 22:25:15 +0200 > Andrea Canciani wrote: > >> On Tue, Sep 11, 2012 at 7:34 PM, Søren Sandmann >> wrote: >> > Andrea Canciani writes: >> > >> >> This remi

Re: [Pixman] [cairo] help building cairo on windows

2012-09-11 Thread Andrea Canciani
On Tue, Sep 11, 2012 at 7:34 PM, Søren Sandmann wrote: > Andrea Canciani writes: > >> This reminds me that I have some patches to improve building pixman on win32: >> http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-master >> >> Soren, i

Re: [Pixman] [cairo] help building cairo on windows

2012-09-11 Thread Andrea Canciani
(&name) > > -#elif defined(__MINGW32__) > +#elif defined(__MINGW32__) || defined(_MSC_VER) /* XP Support */ > > # define _NO_W32_PSEUDO_MODIFIERS > # include > +# ifdef IN > +# undef IN /* Window.h defines IN, OUT, IN_OUT */ > > +# endif >

Re: [Pixman] [cairo] help building cairo on windows

2012-09-10 Thread Andrea Canciani
This reminds me that I have some patches to improve building pixman on win32: http://cgit.freedesktop.org/~ranma42/pixman/commit/?h=wip/simpleops-to-master Soren, is it ok if I push the attached patches? I will work a little more on simpleops before proposing it again (in particular, I'd like to

Re: [Pixman] [PATCH 1/1] Disable implementations mentioned in the PIXMAN_DISABLE environment variable.

2012-02-26 Thread Andrea Canciani
On Sun, Feb 26, 2012 at 4:12 PM, Matt Turner wrote: > On Sat, Feb 25, 2012 at 9:39 PM, Søren Sandmann wrote: >> From: Søren Sandmann Pedersen >> >> With this, it becomes possible to do >> >>     PIXMAN_DISABLE="sse2 mmx" some_app >> >> which will run some_app without SSE2 and MMX enabled. This i

Re: [Pixman] pixman on iOS

2012-02-19 Thread Andrea Canciani
On Sun, Feb 19, 2012 at 10:21 AM, Siarhei Siamashka wrote: > On Sun, Feb 19, 2012 at 6:37 AM, cu wrote: >> Siarhei Siamashka wrote: >>> It should be not necessary to compile on linux. Having no OS X, I have >>> never tried it, but chances should be good for successful compilation >>> of crossbinu

[Pixman] [PATCH 3/3] gradient-walker: Use appropriate size for left and right offset

2012-01-05 Thread Andrea Canciani
Otherwise if pos cannot be represented as an int32_t, the gradient is reset at every step. --- pixman/pixman-gradient-walker.c | 13 +++-- pixman/pixman-private.h |4 ++-- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/pixman/pixman-gradient-walker.c b/pixman

[Pixman] [PATCH 2/3] gradient-walker: Fix wraparound when using NONE/PAD

2012-01-05 Thread Andrea Canciani
When the pos parameter cannot be represented as int32_t (i.e. it is outside [INT32_MIN, INT32_MAX]), truncating it to 32 bits can make it belong to the [0,1] range. For the NONE and PAD repeat modes, this can result in an incorrect color. --- pixman/pixman-gradient-walker.c |9 - 1 fi

[Pixman] [PATCH 1/3] gradient-walker: Remove need_reset field

2012-01-05 Thread Andrea Canciani
A reset can be forced by making left_x > right_x, because no pos will satisfy left <= pos < right. --- pixman/pixman-gradient-walker.c | 17 ++--- pixman/pixman-private.h |2 -- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/pixman/pixman-gradient-walker.

Re: [Pixman] pixman non POSIX test

2011-11-24 Thread Andrea Canciani
On Thu, Nov 24, 2011 at 3:47 AM, Naohiro Aota wrote: > pixman configure.ac has this line: > >   test "$test_CFLAGS" == "" &&         \ > > which may cause an error on some POSIX shells. > > This can be fixed as the follwing like $MMX_CFLAGS is checked in the > same file. > > I've also reported thi

Re: [Pixman] pixman make error

2011-11-17 Thread Andrea Canciani
On Thu, Nov 17, 2011 at 7:16 AM, wrote: > hi Sir, Madam: >         When I compiled , the system show  a error message as the > attachment. Please kindly advise me how to fix the problem. Thanks Can you check if your "make" command is a GNU Make? $ make --version GNU Make 3.81 Copyright (C) 2006

[Pixman] [PATCH] test: Produce autotools-looking report in the win32 build system

2011-11-08 Thread Andrea Canciani
Tweak the commands used to run the tests on win32 to make the output look mostly like that produced by the autotools test system. In addition to this, make sure that the exit status of the test target is success (0) if and only if no failure occurred. --- test/Makefile.win32 | 21 ++

[Pixman] [PATCH 5/5] demos: Consistently use G_N_ELEMENTS()

2011-11-04 Thread Andrea Canciani
Instead of open-coding G_N_ELEMENTS(), just use it. --- demos/composite-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/demos/composite-test.c b/demos/composite-test.c index f5f352f..bba90c5 100644 --- a/demos/composite-test.c +++ b/demos/composite-test.c @@ -123,7

[Pixman] [PATCH 4/5] test: Reuse the ARRAY_LENGTH() macro

2011-11-04 Thread Andrea Canciani
It is provided by utils.h, there is no need to redefine it. --- test/alphamap.c |2 -- test/scaling-crash-test.c |5 ++--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/test/alphamap.c b/test/alphamap.c index 554b309..24a350e 100644 --- a/test/alphamap.c +++ b/te

[Pixman] [PATCH 3/5] Use the ARRAY_LENGTH() macro when possible

2011-11-04 Thread Andrea Canciani
This patch has been generated by the following Coccinelle semantic patch: // Use the ARRAY_LENGTH() macro when possible // // Replace open-coded array length computations with the // ARRAY_LENGTH() macro @@ type T; T[] E; @@ - (sizeof(E)/sizeof(T)) + ARRAY_LENGTH (E) --- test/blitters-test.c

[Pixman] [PATCH 2/5] test: Cleanup includes

2011-11-04 Thread Andrea Canciani
All the tests are linked to libutil, hence it makes sence to always include utils.h and reuse what it provides (config.h inclusion, access to private pixman APIs, ARRAY_LENGTH, ...). --- test/a1-trap-test.c |2 +- test/blitters-test.c |1 - test/composite-traps-test.c |

[Pixman] [PATCH 1/5] Remove useless checks for NULL before freeing

2011-11-04 Thread Andrea Canciani
This patch has been generated by the following Coccinelle semantic patch: // Remove useless checks for NULL before freeing // // free (NULL) is a no-op, so there is no need to avoid it @@ expression E; @@ + free (E); + E = NULL; - if (unlikely (E != NULL)) { - free(E); ( - E = NULL; | - E =

[Pixman] Code cleanup

2011-11-04 Thread Andrea Canciani
This patchset should simply cleanup some code, mostly in the tests. The patchset is also available in http://cgit.freedesktop.org/~ranma42/pixman/log/?h=wip/cocci As they are not fixes, it might be a good idea to wait for 0.24 to be released before merging them (as usual, if nobody raises objecti

Re: [Pixman] [RFC] Performance statistics analyzer

2011-09-14 Thread Andrea Canciani
On Wed, Sep 7, 2011 at 6:46 AM, Maarten Bosmans wrote: > 2011/9/6 Taekyun Kim : >> Hi, >> >> Currently pixman is used as a lowlevel backend for various applications. >> For doing analysis on performance, it might be desirable to provide some >> performance statistics information to developers. >>

Re: [Pixman] [PATCH] Only link with -lpng when libpng is actually available

2011-09-11 Thread Andrea Canciani
How about using pkg-config to detect the availability of libpng and the flags required to use it? Andrea On Sun, Sep 11, 2011 at 1:09 PM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > Fixes build on systems that don't have libpng > --- >  configure.ac     |    1 + >  test/Makefile.a

[Pixman] [PATCH 7/7] build-win32: Add 'check' target

2011-09-04 Thread Andrea Canciani
On win32 the tests are built but they are not run automatically by the build system. A minimal 'check' target (depending on the tests being built) can simply run them and log to the console their success/failure. --- Makefile.win32 |5 + test/Makefile.win32 |3 +++ 2 files change

[Pixman] [PATCH 6/7] test: Do not include config.h unless HAVE_CONFIG_H is defined

2011-09-04 Thread Andrea Canciani
The win32 build system does not generate config.h and correctly runs the compiler without defining HAVE_CONFIG_H. Nevertheless some files include config.h without checking for its availability, breaking the build from a clean directory: test\utils.h(2) : fatal error C1083: Cannot open include file

[Pixman] [PATCH 5/7] build-win32: Add root Makefile.win32

2011-09-04 Thread Andrea Canciani
Add Makefile.win32 to the pixman root. This makefile can recursively run the other ones to compile the library or the test suite. --- Makefile.win32 | 20 1 files changed, 20 insertions(+), 0 deletions(-) create mode 100644 Makefile.win32 diff --git a/Makefile.win32 b/Make

[Pixman] [PATCH 4/7] build-win32: Share targets and variables across win32 makefiles

2011-09-04 Thread Andrea Canciani
The win32 build system repeatedly defines some basic variables (notably program names and flags) and C sources compilation rules. They can be factored out to a common Makefile, to be included in every other Makefile.win32. --- Makefile.win32.common | 54 +

[Pixman] [PATCH 3/7] build: Reuse test sources

2011-09-04 Thread Andrea Canciani
Makefile.am and Makefile.win32 should not duplicate content, as this leads to breaking the build when they are not kept in sync. This can be avoided by listing sources, headers and common build variables/rules in a Makefile.sources file. In order to further simplify the test makefiles, the utilit

[Pixman] [PATCH 2/7] build: Reuse sources and pixman-combine build rules

2011-09-04 Thread Andrea Canciani
Makefile.am and Makefile.win32 should not duplicate content, as this leads to breaking the build when they are not kept in sync. This can be avoided by listing sources, headers and common build variables/rules in a Makefile.sources file. --- pixman/Makefile.am | 61 ++--

[Pixman] [PATCH 1/7] test: Fix compilation on win32

2011-09-04 Thread Andrea Canciani
Adding scaling-helpers-test to the testsuite on win32 makes MSVC complain about int64_t being used as an expression: scaling-helpers-test.c(27) : error C2275: 'int64_t' : illegal use of this type as an expression --- test/scaling-helpers-test.c |2 +- 1 files changed, 1 insertions(+), 1 delet

Re: [Pixman] [PATCH] Workaround bug in llvm-gcc

2011-08-22 Thread Andrea Canciani
On Mon, Aug 22, 2011 at 3:24 PM, Soeren Sandmann wrote: > Andrea Canciani writes: > >> llvm-gcc (shipped in Apple XCode 4.1.1 as the default compiler or in >> the 2.9 release of LLVM) performs an invalid optimization which >> unifies the empty_region and the bad_region

[Pixman] [PATCH] Workaround bug in llvm-gcc

2011-08-20 Thread Andrea Canciani
llvm-gcc (shipped in Apple XCode 4.1.1 as the default compiler or in the 2.9 release of LLVM) performs an invalid optimization which unifies the empty_region and the bad_region structures because they have the same content. A bug has been filed against Apple Developers Tool for this issue. This co

[Pixman] [PATCH] Workaround bug in llvm-gcc

2011-08-16 Thread Andrea Canciani
llvm-gcc (shipped in Apple XCode 4.1.1) as the default compiler performs an invalid optimization which unifies the empty_region and the bad_region structures because they have the same content. A bug has been filed against Apple Developers Tool for this issue. This commit works around this bug by

Re: [Pixman] [PATCH] Don't include stdint.h in lowlevel-blt-bench.c

2011-08-09 Thread Andrea Canciani
On Mon, Aug 8, 2011 at 4:20 PM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > Some systems don't have the file, and the types are already defined in > pixman.h. Tested on macosx, linux and win32 (after http://lists.freedesktop.org/archives/pixman/2011-August/001380.html ) Andrea >

[Pixman] [PATCH] win32: Build benchmarks

2011-08-09 Thread Andrea Canciani
Add the makefile rules needed to compile lowlevel-blt-bench on win32 and fix the compilation errors. --- test/Makefile.win32 |5 - test/lowlevel-blt-bench.c |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/test/Makefile.win32 b/test/Makefile.win32 index c

Re: [Pixman] [PATCH 2/4] New test of pixman_region_contains_{rectangle, point}

2011-08-05 Thread Andrea Canciani
On Sat, Aug 6, 2011 at 2:12 AM, Soeren Sandmann wrote: > Andrea Canciani writes: > >> On Thu, Aug 4, 2011 at 6:32 AM, Soeren Sandmann wrote: >>> Søren Sandmann writes: >>> >>>> From: Søren Sandmann Pedersen >>>> >>>> This

Re: [Pixman] [PATCH 3/4] Speed up pixman_region{, 32}_contains_rectangle()

2011-08-04 Thread Andrea Canciani
On Thu, Aug 4, 2011 at 4:21 AM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > When someone selects some text in Firefox under a non-composited X > server and initiates a drag, a shaped window is created with a complex > shape corresponding to the outline of the text. Then, on every mo

Re: [Pixman] [PATCH 2/4] New test of pixman_region_contains_{rectangle, point}

2011-08-03 Thread Andrea Canciani
7;m not saying it's wrong, I'm just saying I don't understand it) Apart from this and some trailing whitespace, Reviewed-by: Andrea Canciani Andrea > > > Soren > > > commit 55edc9eb4c9041b4ed9639b6428ee215e5412ea0 > Author: Søren Sandmann Pedersen > Date:  

Re: [Pixman] [PATCH 1/4] Fix lcg_rand_u32() to return 32 random bits.

2011-08-03 Thread Andrea Canciani
On Thu, Aug 4, 2011 at 4:21 AM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > The lcg_rand() function only returns 15 random bits, so lcg_rand_u32() > would always have 0 in bit 31 and bit 15. Fix that by calling > lcg_rand() three times, to generate 15, 15, and 2 random bits > respec

[Pixman] [PATCH] radial: Fix typos and trailing whitespace

2011-07-24 Thread Andrea Canciani
Correct a typo reported by James Cloos and some reported by automatic spellchecking. Remove trailing whitespace. --- pixman/pixman-radial-gradient.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/pixman/pixman-radial-gradient.c b/pixman/pixman-radial-gradie

Re: [Pixman] [PATCH 3/3] BILINEAR->NEAREST filter optimization for simple rotation and translation

2011-05-23 Thread Andrea Canciani
On Mon, May 23, 2011 at 3:16 PM, Siarhei Siamashka wrote: > On Mon, May 23, 2011 at 9:48 AM, Andrea Canciani wrote: >> On Mon, May 23, 2011 at 8:43 AM, Andrea Canciani wrote: >>> On Sun, May 22, 2011 at 11:15 PM, Siarhei Siamashka >>> wrote: >>>> Fr

[Pixman] [PATCH] Include noop in win32 builds

2011-05-23 Thread Andrea Canciani
--- pixman/Makefile.win32 |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/pixman/Makefile.win32 b/pixman/Makefile.win32 index b5f9397..7c92722 100644 --- a/pixman/Makefile.win32 +++ b/pixman/Makefile.win32 @@ -49,6 +49,7 @@ SOURCES = \ p

Re: [Pixman] [PATCH 3/3] BILINEAR->NEAREST filter optimization for simple rotation and translation

2011-05-22 Thread Andrea Canciani
On Mon, May 23, 2011 at 8:43 AM, Andrea Canciani wrote: > On Sun, May 22, 2011 at 11:15 PM, Siarhei Siamashka > wrote: >> From: Siarhei Siamashka >> >> Simple rotation and translation are the additional cases when BILINEAR >> filter can be safely reduced to NE

Re: [Pixman] [PATCH 3/3] BILINEAR->NEAREST filter optimization for simple rotation and translation

2011-05-22 Thread Andrea Canciani
On Sun, May 22, 2011 at 11:15 PM, Siarhei Siamashka wrote: > From: Siarhei Siamashka > > Simple rotation and translation are the additional cases when BILINEAR > filter can be safely reduced to NEAREST. I believe that this reduction is valid for any matrix which describes a unit transform follow

[Pixman] [PATCH] test: Fix compilation on win32

2011-05-05 Thread Andrea Canciani
MSVC complains about uint32_t being used as an expression: composite.c(902) : error C2275: 'uint32_t' : illegal use of this type as an expression --- test/composite.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/test/composite.c b/test/composite.c index 9a001e5..ede

Re: [Pixman] Pixman on iOS

2011-03-07 Thread Andrea Canciani
On Mon, Mar 7, 2011 at 8:09 PM, cu wrote: >> >>> I'm actually more worried that if this build for iPhone ends up being >>> a one shot experiment without any maintainer to keep it alive, then it >>> is going to bitrot soon. IMHO adding support for more marginal >>> platforms (in cairo/pixman contex

Re: [Pixman] [cairo] Planar YUV support

2011-03-04 Thread Andrea Canciani
On Thu, Mar 3, 2011 at 6:58 PM, Siarhei Siamashka wrote: > On Wed, Mar 2, 2011 at 4:16 PM, Soeren Sandmann wrote: >> Siarhei Siamashka writes: >> >>> I'm not a big fan of "let's make this totally universal and future >>> proof" approach if only a very small fraction of this functionality is >>>

Re: [Pixman] [cairo] Planar YUV support

2011-03-02 Thread Andrea Canciani
On Wed, Mar 2, 2011 at 3:16 PM, Soeren Sandmann wrote: > Siarhei Siamashka writes: > >> I'm not a big fan of "let's make this totally universal and future >> proof" approach if only a very small fraction of this functionality is >> going to be actually used. Moreover, I suspect that trying to be

Re: [Pixman] Win32 fixes and improvements

2011-02-26 Thread Andrea Canciani
On Thu, Feb 24, 2011 at 6:43 PM, Soeren Sandmann wrote: > Andrea Canciani writes: > >> I improved the patchset a little (I fixed the library makefile for real >> and silenced the test warnings) and pushed it as a git branch here: >> http://cgit.freedesktop.org/~ranma42

Re: [Pixman] [cairo] Planar YUV support

2011-02-25 Thread Andrea Canciani
On Fri, Feb 25, 2011 at 2:00 PM, Siarhei Siamashka wrote: > On Tuesday 09 March 2010 18:09:57 Benjamin Otte wrote: >> Hey, >> >> Here's an update on my work on YUV planar support, also known as "what >> we got from the gstreamer-cairo hackfest". I've reworked my experimental >> code from back then

Re: [Pixman] Win32 fixes and improvements

2011-02-24 Thread Andrea Canciani
On Tue, Feb 22, 2011 at 11:07 PM, Andrea Canciani wrote: > In order to make pixman more maintainable on windows, having working > Makefiles for the library and the tests is probably needed. Today I > took the Makefile attached to > https://bugs.freedesktop.org/show_bug.cgi?id=33069 &g

Re: [Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-23 Thread Andrea Canciani
On Wed, Feb 23, 2011 at 6:26 PM, Brent Fulgham wrote: > Thanks for making these fixes -- they look great! > > I have one small suggestion regarding your update to "composite.c"; > while MSVC does not provide an "snprintf" symbol, it does provide > "_snprintf". The documentation states that it is

[Pixman] [PATCH 3/3] test: add Makefile for Win32

2011-02-22 Thread Andrea Canciani
--- test/Makefile.win32 | 73 +++ 1 files changed, 73 insertions(+), 0 deletions(-) create mode 100644 test/Makefile.win32 diff --git a/test/Makefile.win32 b/test/Makefile.win32 new file mode 100644 index 000..c71afe1 --- /dev/null +++ b/test

[Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-22 Thread Andrea Canciani
The Microsoft C compiler cannot handle subobject initialization and Win32 does not provide snprintf. Work around these limitations by using normal struct initailization and directly using printf. --- test/composite.c| 48 +++--- test/fetch-test.c |

[Pixman] [PATCH 1/3] Fix compilation on Win32

2011-02-22 Thread Andrea Canciani
Building the library from a clean git repository fails with: pixman-image.c(33) : fatal error C1083: Cannot open include file: 'pixman-combine32.h': No such file or directory pixman-combine32.h is not used by pixman-image.c, so its inclusion can simply be removed. --- pixman/pixman-image.c |1

[Pixman] Win32 fixes and improvements

2011-02-22 Thread Andrea Canciani
In order to make pixman more maintainable on windows, having working Makefiles for the library and the tests is probably needed. Today I took the Makefile attached to https://bugs.freedesktop.org/show_bug.cgi?id=33069 and tried to use it to build but it didn't build all the tests because of some in

Re: [Pixman] [PATCH] Avoid marking images dirty when properties are reset

2011-02-15 Thread Andrea Canciani
On Tue, Feb 15, 2011 at 10:55 AM, Soeren Sandmann wrote: > When an image property is set to the same value that it already is, > there is no reason to mark the image dirty and incur a recomputation > of the flags. > --- >  pixman/pixman-image.c |   20 +++- >  1 files changed, 19 in

Re: [Pixman] [cairo] pixman: New ARM NEON optimizations

2011-02-12 Thread Andrea Canciani
On Fri, Feb 11, 2011 at 11:30 AM, Soeren Sandmann wrote: > Chris Wilson writes: > >> But at the moment, about the only thing I truly want to add to the API >> is a LERP operator. > >> Cairo has a slightly different definition for [clip-] masked operators >> where the operation is defined as: >> >

Re: [Pixman] [PATCHv3 0/3] Faster 90/270 degrees rotation

2011-02-08 Thread Andrea Canciani
On Tue, Feb 8, 2011 at 1:39 AM, Siarhei Siamashka wrote: > On Friday 04 February 2011 13:42:42 Andrea Canciani wrote: >> On Fri, Feb 4, 2011 at 11:52 AM, Siarhei Siamashka >> >> wrote: >> > From: Siarhei Siamashka >> > >> > Changes since the

Re: [Pixman] [cairo] LCD Alpha Blending Formulas [Repost from AGG]

2011-02-07 Thread Andrea Canciani
On Mon, Feb 7, 2011 at 1:30 PM, Petr Kobalíček wrote: > Hi devs, > > [Repost from the AGG mailing list] > > this post is not strictly related to agg. I'm playing with one problem > related to image compositing and I only need to confirm whether my > solution is correct. > > I abstracted image comp

Re: [Pixman] [PATCHv3 0/3] Faster 90/270 degrees rotation

2011-02-04 Thread Andrea Canciani
On Fri, Feb 4, 2011 at 7:34 PM, Bill Spitzak wrote: > I would think that rather than a flag for each rotation, you can use 3 flags > to get all the unit rotations and flipping, and avoid the annoying > possibility of setting the flags to invalid combinations: Uhm... that's not how fast path flags

Re: [Pixman] [PATCHv3 0/3] Faster 90/270 degrees rotation

2011-02-04 Thread Andrea Canciani
On Fri, Feb 4, 2011 at 11:52 AM, Siarhei Siamashka wrote: > From: Siarhei Siamashka > > Changes since the previous sumbission: > 1. coding style fixes > 2. sligthly tweaked flags setting code to make it a bit faster > > Siarhei Siamashka (3): >  New flags for 90/180/270 rotation >  C fast paths f

Re: [Pixman] warnings in pixman 0.21.4

2011-01-25 Thread Andrea Canciani
On Tue, Jan 25, 2011 at 4:38 PM, Rolland Dudemaine wrote: > - *max_vx.diff corrects the initialization of max_vx. Contrary to what you mention, the variable is declared in a local block, so the scope of the variable is restricted to that block, regardless of whether it is part

Re: [Pixman] warnings in pixman 0.21.4

2011-01-25 Thread Andrea Canciani
On Tue, Jan 25, 2011 at 3:23 PM, Siarhei Siamashka wrote: > On Monday 24 January 2011 11:51:39 Rolland Dudemaine wrote: >> Hi, >> >> Granted, the patch was somewhat too big and contained many things. >> >> Attached the patch splitted in five parts : >> - *fence_prototype.diff resolves the incorrec

Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-21 Thread Andrea Canciani
On Fri, Jan 21, 2011 at 11:56 PM, Soeren Sandmann wrote: > Andrea Canciani writes: > >> > The old code had more lines of code for this part, but on the other hand >> > all >> > this code was in a single place as opposed to being spread around. In some >

Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-15 Thread Andrea Canciani
On Fri, Jan 14, 2011 at 1:46 PM, Siarhei Siamashka wrote: > On Wednesday 12 January 2011 12:46:39 Soeren Sandmann wrote: >> Siarhei Siamashka writes: >> > >  15 files changed, 743 insertions(+), 470 deletions(-) >> > >> > On the other hand, I'm not so happy about the implementation. The number >>

Re: [Pixman] [PATCH] Improve handling of tangent circles

2011-01-14 Thread Andrea Canciani
On Fri, Jan 14, 2011 at 11:10 AM, Siarhei Siamashka wrote: > On Wednesday 12 January 2011 23:58:55 Andrea Canciani wrote: >> On Wed, Jan 12, 2011 at 6:36 PM, Andrea Canciani >> wrote: >> > Attached is a patch which adds radial-test to the GTK pixman tests. >> >

Re: [Pixman] [PATCH] Improve handling of tangent circles

2011-01-12 Thread Andrea Canciani
On Wed, Jan 12, 2011 at 6:36 PM, Andrea Canciani wrote: > On Tue, Jan 4, 2011 at 11:12 AM, Andrea Canciani wrote: >> On Tue, Jan 4, 2011 at 10:59 AM, Siarhei Siamashka >> wrote: >>> On Monday 03 January 2011 10:15:09 Andrea Canciani wrote: >>>> When b is 0,

Re: [Pixman] [PATCH] Improve handling of tangent circles

2011-01-12 Thread Andrea Canciani
On Tue, Jan 4, 2011 at 11:12 AM, Andrea Canciani wrote: > On Tue, Jan 4, 2011 at 10:59 AM, Siarhei Siamashka > wrote: >> On Monday 03 January 2011 10:15:09 Andrea Canciani wrote: >>> When b is 0, avoid the division by zero and just return transparent >>> black. >

Re: [Pixman] [PATCH 0/3] ARM: fixes and workarounds for using pixman with QEMU

2011-01-11 Thread Andrea Canciani
On Tue, Jan 11, 2011 at 5:10 PM, Siarhei Siamashka wrote: > From: Siarhei Siamashka > > The intention of this patchset is to make it easier to test changes > to pixman code for the possible ARM related regressions without the > need to run it on real ARM hardware. > > When having ARM crosscompile

Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-08 Thread Andrea Canciani
On Sat, Jan 8, 2011 at 12:15 PM, Soeren Sandmann wrote: >> Iterators gets initialized with a buffer which can always contain at >> least "width" pixels. This is sufficient for current image types, >> but future image types might need additional space. >> >> Would it be possible to have the general

Re: [Pixman] [PATCH 15/18] Add direct-write optimization back

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:27 AM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > Introduce a new ITER_LOCALIZED_ALPHA flag that indicates that the > alpha value computed is used only for the alpha channel of the output; > it doesn't affect the RGB channels. > > Then in pixman-bits-image.

Re: [Pixman] [PATCH 18/18] Fix destination fetching.

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:28 AM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > When fetching from destinations, we need to ignore transformations, > repeat and filtering. Currently we don't ignore them, which means all > kinds of bad things can happen. > > This bug fixes this problem b

Re: [Pixman] [PATCH 14/18] Get rid of the classify methods.

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:27 AM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > They are not used anymore, and the linear gradient is now doing the > optimization in a different way. > --- >  pixman/pixman-image.c           |   14 -- >  pixman/pixman-linear-gradient.c |   28

Re: [Pixman] [PATCH 0/18] Add iterators to images

2011-01-07 Thread Andrea Canciani
On Thu, Jan 6, 2011 at 3:43 AM, Soeren Sandmann wrote: > Søren Sandmann writes: > >> The following patch series changes the scanline access to be based on >> iterators instead of direct calls to virtual functions. There are >> several benefits to this: It also provides a natural place to initial

Re: [Pixman] [PATCH] Improve handling of tangent circles

2011-01-07 Thread Andrea Canciani
On Fri, Jan 7, 2011 at 11:54 AM, Siarhei Siamashka wrote: > On Tuesday 04 January 2011 16:33:18 Andrea Canciani wrote: >> On Tue, Jan 4, 2011 at 11:12 AM, Andrea Canciani wrote: >> > On Tue, Jan 4, 2011 at 10:59 AM, Siarhei Siamashka >> >> I just wonder if it would

Re: [Pixman] [PATCH] Improve handling of tangent circles

2011-01-04 Thread Andrea Canciani
On Tue, Jan 4, 2011 at 11:12 AM, Andrea Canciani wrote: > On Tue, Jan 4, 2011 at 10:59 AM, Siarhei Siamashka > wrote: >> On Monday 03 January 2011 10:15:09 Andrea Canciani wrote: >>> When b is 0, avoid the division by zero and just return transparent >>> black. >

  1   2   >