Re: [Pixman] [PATCH 1/2] Add test for _intersect_rect(, )

2016-02-04 Thread Bill McCloskey
is easily fixable for small patches like > this, but may become a problem for larger patch sets. > > > On Tue, 2 Feb 2016 17:35:28 -0800 > Bill McCloskey wrote: > > > This test ensures that calling _intersect_rect on an empty > > rectangle produces an empty region. >

[Pixman] [PATCH 2/2] _intersect_rect should return an empty region when intersecting with an empty rect

2016-02-02 Thread Bill McCloskey
When you call _intersect_rect and pass it an empty rectangle, it creates an invalid region from that rectangle. The only valid empty region is the one where the data pointer points to pixman_region_empty_data. The region created by _intersect_rect has a null data pointer, and so _not_empty returns

[Pixman] [PATCH 1/2] Add test for _intersect_rect(, )

2016-02-02 Thread Bill McCloskey
This test ensures that calling _intersect_rect on an empty rectangle produces an empty region. Reviewed-by: Siarhei Siamashka --- test/region-test.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/region-test.c b/test/region-test.c index bfc219b..e5743e8 100644 --- a/test/regio

[Pixman] [PATCH] _intersect_rect should return an empty region when intersecting with an empty rect

2016-01-13 Thread Bill McCloskey
When you call _intersect_rect and pass it an empty rectangle, it creates an invalid region from that rectangle. The only valid empty region is the one where the data pointer points to pixman_region_empty_data. The region created by _intersect_rect has a null data pointer, and so _not_empty returns