Re: [Pixman] Giving out commit access

Hi Pekka, Have you considered reusing the wayland commit access/review criteria ? Personally it seems that using it as a draft, could be fairly good start. Quick look at a Ubuntu machine shows multiple users of pixman, so keeping it alive is a worthy goal. - xservers - xorg, nested, wayland,

Re: [Pixman] Crash during stress-test

On 19 November 2017 at 18:26, LE GARREC Vincent wrote: > I made a clone on https://github.com/bansan85/pixman/tree/stress_test_file > I tried to make lots of small commits to make review easier. A lot better, thank you. There are some whitespace fixes alongside the

Re: [Pixman] [Patch] Fix pixman build with clang

On 8 December 2017 at 23:32, Manoj Gupta wrote: > Hi, > > I am encountering a build issue in pixman when compiling with with clang. > > pixman-mmx.c:100:20: error: constraint 'K' expects an integer constant > expression > : "y" (__A), "K" (__N) > Seems like you

Re: [Pixman] Crash during stress-test

Hi Vincent, On 15 November 2017 at 21:37, LE GARREC Vincent wrote: > Dear, > > I ran stress-test under fuzzing and I found a crash. > > I'm not really comfortable with pixman so I don't really know how to report > you the problem. > > Please find enclosed

Re: [Pixman] [PATCH] Add destructor function to free pixman_implementation_t structs on exit

ler has support for > __attribute__((constructor)) and __attribute__((destructor)) > function attributes. > > Reported-by: Emil Velikov <emil.l.veli...@gmail.com> > Signed-off-by: Siarhei Siamashka <siarhei.siamas...@gmail.com> Looks and works like a charm. FWIW Reviewed-by

Re: [Pixman] [BUG REPORT] pixman_glyph_cache_create leaks memory that it allocates

On 17 September 2017 at 22:25, Yuri wrote: >> What you reported seems like an user error. Although without a proper >> log nobody can tell you for sure. >> The leak I've spotted is a genuine leak in pixman. > > > Failure to call a destructor in C code could be interpreted as a

Re: [Pixman] [BUG REPORT] pixman_glyph_cache_create leaks memory that it allocates

Yuri, please don't use HTML emails. It completely messes up the quotation. On 17 September 2017 at 21:17, Yuri <y...@rawbw.com> wrote: > On 09/17/17 13:07, Emil Velikov wrote: > >> Having the opposite - a destructor [1] should provide symmetry and >> consistency. >

Re: [Pixman] [BUG REPORT] pixman_glyph_cache_create leaks memory that it allocates

On 17 September 2017 at 17:46, Yuri wrote: >> Maybe the right solution is to add explicit pixman_init() and >> pixman_destroy() functions. But we need to support existing >> applications too and we can't expect them to start using these >> new functions without enforcing some

Re: [Pixman] [BUG REPORT] pixman_glyph_cache_create leaks memory that it allocates

Hi Yuri, On 15 September 2017 at 22:41, Yuri wrote: > google-perftools memory profile on a gtkmm-based app shows that there is > 0.3MB of memory left by pixman_glyph_cache_create. > > > pixman should free all memory that it allocates. For example, if the app > will load the gtkmm

Re: [Pixman] [PATCH] Add CMake build rules

On 22 May 2016 at 10:47, whitequark wrote: > On 2016-05-22 09:20, Pekka Paalanen wrote: >> >> [snip] >> >> Assuming people were happy adding a new build system, which I very >> much doubt, > > > I've checked the mailing list of Cairo before starting this work. > There

Re: [Pixman] [RFC 1/2] Remove seemingly unneeded comparison(s)

On 29 April 2016 at 11:35, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 29 Apr 2016 10:15:37 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 27 April 2016 at 18:46, Bill Spitzak <spit...@gmail.com> wrote: >> > On Wed, Apr 2

Re: [Pixman] [RFC 1/2] Remove seemingly unneeded comparison(s)

On 27 April 2016 at 18:46, Bill Spitzak <spit...@gmail.com> wrote: > On Wed, Apr 27, 2016 at 2:03 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: >> >> On Wed, 27 Apr 2016 09:56:44 +0100 >> Emil Velikov <emil.l.veli...@gmail.com> wrote: >> >&

Re: [Pixman] [PATCH 1/4] test: static link pixman in matrix-test

Hello Siarhei, On 26 April 2016 at 19:32, Siarhei Siamashka <siarhei.siamas...@gmail.com> wrote: > Hello Emil, > > On Sun, 24 Apr 2016 19:20:58 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> The test uses pixman internal symbols, which we currently

[Pixman] [RFC 1/2] Remove seemingly unneeded comparison(s)

With commit ed39992564b "Use pixman_transform_point_31_16() from pixman_transform_point()" we added some strange hunks. Namely: we copy the data from the internal storage to the user vector only to compare them immediately after. Cc: Siarhei Siamashka --- Siarhei,

[Pixman] [RFC 2/2] sse2: use uintptr_t for vx/unit_x

Strictly speaking this is not correct, as the value itself can be signed based on the definition of pixman_fixed_t. At the same time we check if vx can be negative in some places, while in others we directly ">> 16" and use the result as an index. Obviously something isn't right here - should we

[Pixman] [PATCH 4/4] Hide the final internal function from global namespace

Namely _pixman_internal_only_get_implementation. This workaround is no longer needed as of last commit, so let's rename the function and make it truly internal only. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- pixman/pixman-private.h | 7 ++- pixman/pixman-utils.c

[Pixman] [PATCH 3/4] test: static link pixman in combiner-test

Analogous to an earlier commit about matrix-test Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- test/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/test/Makefile.am b/test/Makefile.am index f70440e..d963071 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @

[Pixman] [PATCH 1/4] test: static link pixman in matrix-test

The test uses pixman internal symbols, which we currently export. To resolve that static link the pixman library. This is an internal only test ran at `make check' thus we are fine with the bloated binary and alike. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- Afaics the W

[Pixman] [PATCH 2/4] Remove pixman_transform_point_31_16* from global namespace

These internal functions were needed by matrix-test. With the test static linking pixman (as of last commit) we no longer need to export these and we can move them back to being internal only. Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- pixman/pixman-matrix.c | 6 +++---

Re: [Pixman] [Mesa-stable] [PATCH] configure.ac: fix test for SSE4.1 assembler support

On 9 December 2015 at 11:39, Oded Gabbay <oded.gab...@gmail.com> wrote: > On Wed, Dec 9, 2015 at 1:09 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 9 December 2015 at 05:37, Jonathan Gray <j...@jsg.id.au> wrote: >>> Change the __m128i variables to b