Re: [Pixman] [PATCH] Make the combiner macros less likely to cause name collisions.

2010-07-07 Thread Soeren Sandmann
Alexander Shulgin writes: > Are you aware that double leading underscore is reserved for C > compiler's internal use in any context? And especially with names > like __r1 you are more likely to trigger the theoretical undefined > behavior here, as these look like x64 registers names. Good point

Re: [Pixman] [PATCH] Make the combiner macros less likely to cause name collisions.

2010-07-06 Thread Alexander Shulgin
On Wed, Jul 7, 2010 at 02:18, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > Protect the arguments to the combiner macros with parentheses, and > prefix their temporary variables with underscores to avoid name space > collisions with the surrounding code. > --- >  pixman/pixman-combine

[Pixman] [PATCH] Make the combiner macros less likely to cause name collisions.

2010-07-06 Thread Søren Sandmann
From: Søren Sandmann Pedersen Protect the arguments to the combiner macros with parentheses, and prefix their temporary variables with underscores to avoid name space collisions with the surrounding code. --- pixman/pixman-combine.h.template | 152 +++--- 1 files