Re: [Pixman] [PATCH] sse2: Skip src pixels that are zero in sse2_composite_over_8888_n_8888()

2010-12-25 Thread Rodrigo Kumpera
On Wed, Dec 22, 2010 at 12:11 PM, Soeren Sandmann wrote: > Rodrigo Kumpera writes: > > > This patch doesn't handle cases where alpha is zero but components are > not. > > Not sure > > if this is either possible or frequent. > > It's certainly supposed to handle this case, though it's probably not

Re: [Pixman] [PATCH] sse2: Skip src pixels that are zero in sse2_composite_over_8888_n_8888()

2010-12-23 Thread Jonathan Morton
On Thu, 2010-12-23 at 17:05 +0100, Krzysztof Kosiński wrote: > > This patch doesn't handle cases where alpha is zero but components > are not. Not sure if this is either possible or frequent. > > Pixman uses premultiplied alpha so such values are not possible. No, they are possible, and they hav

Re: [Pixman] [PATCH] sse2: Skip src pixels that are zero in sse2_composite_over_8888_n_8888()

2010-12-23 Thread Krzysztof Kosiński
2010/12/22 Rodrigo Kumpera : > This patch doesn't handle cases where alpha is zero but components are not. > Not sure > if this is either possible or frequent. Pixman uses premultiplied alpha so such values are not possible. Regards, Krzysztof ___ Pixma

Re: [Pixman] [PATCH] sse2: Skip src pixels that are zero in sse2_composite_over_8888_n_8888()

2010-12-22 Thread Soeren Sandmann
Rodrigo Kumpera writes: > This patch doesn't handle cases where alpha is zero but components are not. > Not sure > if this is either possible or frequent. It's certainly supposed to handle this case, though it's probably not frequent. I don't see the bug, though - if any part of the source is no

Re: [Pixman] [PATCH] sse2: Skip src pixels that are zero in sse2_composite_over_8888_n_8888()

2010-12-21 Thread Rodrigo Kumpera
This patch doesn't handle cases where alpha is zero but components are not. Not sure if this is either possible or frequent. On Mon, Dec 20, 2010 at 8:50 PM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > This is a big speed-up in the SVG helicopter game: > > http://ie.microsoft.c

[Pixman] [PATCH] sse2: Skip src pixels that are zero in sse2_composite_over_8888_n_8888()

2010-12-20 Thread Søren Sandmann
From: Søren Sandmann Pedersen This is a big speed-up in the SVG helicopter game: http://ie.microsoft.com/testdrive/Performance/Helicopter/Default.xhtml when rendered by Firefox 4 since it is compositing big images consisting almost entirely of zeros. --- pixman/pixman-sse2.c | 75