Re: [Pixman] [PATCH 08/10] Cleanups and simplifications in x86 CPU feature detection

2012-06-29 Thread Alan Coopersmith
On 06/29/12 01:44 PM, Søren Sandmann Pedersen wrote: > typedef enum > { > -NO_FEATURES = 0, > -MMX = 0x1, > -MMX_EXTENSIONS = 0x2, > -SSE = 0x6, > -SSE2 = 0x8, > -CMOV = 0x10 > +X86_MMX = (1 << 0), > +X86_MMX_EXTENSIONS = (1 << 1), >

Re: [Pixman] [PATCH 08/10] Cleanups and simplifications in x86 CPU feature detection

2012-06-29 Thread Søren Sandmann
Alan Coopersmith writes: > Don't you need to update the feature flags set in the getisax code to match > the renaming you did to cpu_features_t ? Yes, I do, and I also need to initialize features to 0 and reinstate the results variable. Thanks, Soren ___

[Pixman] [PATCH 08/10] Cleanups and simplifications in x86 CPU feature detection

2012-06-29 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen A new function pixman_cpuid() is added that runs the cpuid instruction and returns the results. On GCC this function uses inline assembly that is written such that it will work on both 32 and 64 bit. Compared to the old code, the only difference is %ebx is saved in