Re: [Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-23 Thread Brent Fulgham
HI, On Wed, Feb 23, 2011 at 9:32 AM, Andrea Canciani wrote: > The documentation states that it is deprecated and that it does not behave > as snprintf: > "The _snprintf function formats and stores count or fewer characters > in buffer, and appends a terminating null character if the formatted > s

Re: [Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-23 Thread Andrea Canciani
On Wed, Feb 23, 2011 at 6:26 PM, Brent Fulgham wrote: > Thanks for making these fixes -- they look great! > > I have one small suggestion regarding your update to "composite.c"; > while MSVC does not provide an "snprintf" symbol, it does provide > "_snprintf". The documentation states that it is

Re: [Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-23 Thread Brent Fulgham
Thanks for making these fixes -- they look great! I have one small suggestion regarding your update to "composite.c"; while MSVC does not provide an "snprintf" symbol, it does provide "_snprintf". To be consistent with other ports, I would propose the following change: bfulgham@bfulgham3 ~/requi

[Pixman] [PATCH 2/3] test: Fix tests for compilation on Windows

2011-02-22 Thread Andrea Canciani
The Microsoft C compiler cannot handle subobject initialization and Win32 does not provide snprintf. Work around these limitations by using normal struct initailization and directly using printf. --- test/composite.c| 48 +++--- test/fetch-test.c |