Re: [Pixman] Basic infrastructure for MIPS32r2 and DSPr1 optimizations, and patch for mips* asm exports symbols.

2014-08-23 Thread Søren Sandmann
Nemanja Lukic nemanja.lu...@rt-rk.com writes: This patch set should address all previous code review remarks. From looking at this patch set fairly briefly, - There is some confusion about the type of the new memcpy function. Does it return bool or void*? And what precisely does the return

Re: [Pixman] Basic infrastructure for MIPS32r2 and DSPr1 optimizations.

2014-04-11 Thread Søren Sandmann
Hi, Some highlevel comments on this patch set: * Most of the patches need more detail in the commit log. Generally, there should be around the level information that someone who is familiar with pixman could write the patch just based on the commit log. It's fine to say just Add

[Pixman] Basic infrastructure for MIPS32r2 and DSPr1 optimizations.

2014-03-13 Thread Nemanja Lukic
Some of the optimizations introduced in previous DSPr2 commits were not DSPr2 specific. Some of the fast-paths didn't used DSPr2 instructions at all, and rather utilized more generic MIPS32r2 instruction set or previous version of DSP instruction set (DSPr1) for optimizations. Since Pixman's