Re: [Pixman] Gradients patches

2010-10-23 Thread Andrea Canciani
On Tue, Oct 12, 2010 at 1:09 PM, Soeren Sandmann wrote: >... > > It would be useful for someone to update the Render spec to say that > the radials are PDF Type 3 Shadings, defined in section 8.7.4.5.4 of > the PDF specification, and delete the stuff about the circles being > contained in each oth

Re: [Pixman] Gradients patches

2010-10-12 Thread Soeren Sandmann
Andrea Canciani writes: > > Indeed, the code looks mostly fine to me; I couldn't find any > > functional problems with it. The main complaints I have: > > > > - In the affine case, some of the computation is done in 32.32, and > >  some in double precision. Is there any reason for this? Doing all

Re: [Pixman] Gradients patches

2010-10-10 Thread Andrea Canciani
On Mon, Oct 11, 2010 at 12:56 AM, Soeren Sandmann wrote: > Andrea Canciani writes: > >> On Mon, Oct 4, 2010 at 12:07 PM, Andrea Canciani wrote: >> > This morning I pushed >> > http://cgit.freedesktop.org/~ranma42/pixman/log/?h=radial-for-master >> > It should be ready for master since it is docu

Re: [Pixman] Gradients patches

2010-10-10 Thread Soeren Sandmann
Andrea Canciani writes: > On Mon, Oct 4, 2010 at 12:07 PM, Andrea Canciani wrote: > > This morning I pushed > > http://cgit.freedesktop.org/~ranma42/pixman/log/?h=radial-for-master > > It should be ready for master since it is documented, tested (at least > > on my laptop) and not using > > any

Re: [Pixman] Gradients patches

2010-10-05 Thread Andrea Canciani
On Mon, Oct 4, 2010 at 12:07 PM, Andrea Canciani wrote: > This morning I pushed > http://cgit.freedesktop.org/~ranma42/pixman/log/?h=radial-for-master > It should be ready for master since it is documented, tested (at least > on my laptop) and not using > any new features (so it should not be brok

[Pixman] Gradients patches

2010-10-04 Thread Andrea Canciani
This morning I pushed http://cgit.freedesktop.org/~ranma42/pixman/log/?h=radial-for-master It should be ready for master since it is documented, tested (at least on my laptop) and not using any new features (so it should not be broken on other architectures/compilers/etc). I'm reviewing the fix fo