[Pixman] [PATCH 8/8] sse2: Minor coding style cleanups.

From: Søren Sandmann Pedersen s...@redhat.com Also make pixman_fill_sse2() static. --- pixman/pixman-sse2.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/pixman/pixman-sse2.c b/pixman/pixman-sse2.c index 0509613..88287b4 100644 --- a/pixman/pixman

[Pixman] Fix

I forgot to CC pixman@lists.freedesktop.org on the following patch. The patch is necessary to make trapezoid rendering directly to X windows work and also makes the pixman_composite_trapezoids() API more similar to pixman_image_composite(). See this thread:

[Pixman] NOOP implementation

The following patches add a noop implementation, which is used as topmost in the implementation hierarchy. It is supposed to contain iterators and compositing routines that don't do anything. For example, there is a compositing fast path for the DST operator. This is useful because it allows more

[Pixman] [PATCH 1/6] Add a noop implementation.

From: Søren Sandmann Pedersen s...@redhat.com This new implementation is ahead of all other implementations in the fallback chain and is supposed to contain operations that don't require any work. For examples, it might contain a fast path for the DST operator that doesn't actually do anything

[Pixman] [PATCH 3/6] Move noop dest fetching to noop implementation

From: Søren Sandmann Pedersen s...@redhat.com It will at some point become useful to have CPU specific destination iterators. However, a problem with that is that such iterators should not be used if we can composite directly in the destination image. By moving the noop destination iterator

[Pixman] [PATCH 5/6] Move NULL iterator into pixman-noop.c

From: Søren Sandmann Pedersen s...@redhat.com Iterating a NULL image returns NULL for all scanlines. This may as well be done in the noop iterator. --- pixman/pixman-implementation.c | 12 +--- pixman/pixman-noop.c | 24 2 files changed, 17

[Pixman] [PATCH 4/6] Add a noop src iterator

From: Søren Sandmann Pedersen s...@redhat.com When the image is a8r8g8b8 and not transformed, and the fetched rectangle is within the image bounds, scanlines can be fetched by simply returning a pointer instead of copying the bits. --- pixman/pixman-noop.c | 39

[Pixman] [PATCH 01/10] pixman-cpu.c: Rename disabled to _pixman_disabled() and export it

From: Søren Sandmann Pedersen s...@redhat.com --- pixman/pixman-cpu.c | 22 +++--- pixman/pixman-private.h |2 ++ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/pixman/pixman-cpu.c b/pixman/pixman-cpu.c index aa9036f..a0d2f8c 100644 --- a/pixman/pixman

[Pixman] [PATCH 00/10] Cleanups to CPU detection

git://people.freedesktop.org/~sandmann/pixman in the branch cpudetectfiles. Hi, The following patches contains some cleanups to the CPU detection in general, and some improvements to the x86 specific parts in particular. I was looking at making use of some of the newer x86 SIMD

[Pixman] [PATCH 07/10] Simplify MIPS CPU detection

From: Søren Sandmann Pedersen s...@redhat.com There is no reason to have pixman_have_feature functions when all they do is call pixman_have_mips_feature(). Instead rename pixman_have_mips_feature() to have_feature() and call it directly from _pixman_mips_get_implementations(). Also on non-Linux

[Pixman] [PATCH 03/10] Move ARM specific CPU detection to a new file pixman-arm.c

From: Søren Sandmann Pedersen s...@redhat.com Similar to the x86 commit, this moves the ARM specific CPU detection to its own file which exports a pixman_arm_get_implementations() function that is supposed to be a noop on non-ARM. --- pixman/Makefile.sources |1 + pixman/pixman-arm.c

[Pixman] [PATCH 02/10] Move x86 specific CPU detection to a new file pixman-x86.c

From: Søren Sandmann Pedersen s...@redhat.com Extract the x86 specific parts of pixman-cpu.c and put them in their own file called pixman-x86.c which exports one function pixman_x86_get_implementations() that creates the MMX and SSE2 implementations. This file is supposed to be compiled on all

[Pixman] [PATCH 09/10] Simplifications to ARM CPU detection

From: Søren Sandmann Pedersen s...@redhat.com Organize pixman-arm.c such that each operating system/compiler exports a detect_cpu_features() function that returns a bitmask with the various features that we are interested in. A new function have_feature() then calls this function, caches

[Pixman] [PATCH 05/10] Move MIPS specific CPU detection to its own file, pixman-mips.c

From: Søren Sandmann Pedersen s...@redhat.com --- pixman/Makefile.sources |1 + pixman/pixman-cpu.c | 77 + pixman/pixman-mips.c| 110 +++ pixman/pixman-private.h |3 ++ 4 files changed, 115 insertions

[Pixman] [PATCH 06/10] Move the remaining bits of pixman-cpu into pixman-implementation.c

From: Søren Sandmann Pedersen s...@redhat.com --- pixman/Makefile.sources|1 - pixman/pixman-cpu.c| 79 pixman/pixman-implementation.c | 51 ++ 3 files changed, 51 insertions(+), 80 deletions(-) delete

[Pixman] [PATCH 04/10] Move PowerPC specific CPU detection to its own file pixman-ppc.c

From: Søren Sandmann Pedersen s...@redhat.com --- pixman/Makefile.sources |1 + pixman/pixman-cpu.c | 165 +--- pixman/pixman-ppc.c | 192 +++ pixman/pixman-private.h |3 + 4 files changed, 197

[Pixman] [PATCH 10/10] Simplify CPU detection on PPC.

From: Søren Sandmann Pedersen s...@redhat.com Get rid of the initialized and have_vmx static variables in pixman-ppc.c There is no point to them since CPU detection only happens once per process. On Linux, just read /proc/self/auxv instead of generating the filename with getpid() and don't

[Pixman] [PATCH 08/10] Cleanups and simplifications in x86 CPU feature detection

From: Søren Sandmann Pedersen s...@redhat.com A new function pixman_cpuid() is added that runs the cpuid instruction and returns the results. On GCC this function uses inline assembly that is written such that it will work on both 32 and 64 bit. Compared to the old code, the only difference

[Pixman] [RFC, PATCH 0/8] Floating point pipeline

Hi, The following patches change the 64 pipeline to use single precision floating point channels instead. The main benefit of this is that we get more range and precision so that we can support HDR image formats such as half precision floating point argb. Unlike 16 bpc, single precision floating

[Pixman] [PATCH 2/8] blitters-test: Prepare for floating point

From: Søren Sandmann Pedersen s...@redhat.com Comment out some formats in blitters-test that are going to rely on floating point in some upcoming patches. --- test/blitters-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/blitters-test.c b/test/blitters-test.c

[Pixman] [PATCH 1/8] glyph-test: Prepare for floating point

From: Søren Sandmann Pedersen s...@redhat.com In preparation for an upcoming change of the wide pipe to use floating point, comment out some formats in glyph-test that are going to be using floating point and update the CRC32 value to match. --- test/glyph-test.c | 7 +-- 1 file changed, 5

[Pixman] [PATCH 3/8] Add pixman-combine-float.c

From: Søren Sandmann Pedersen s...@redhat.com This file contains floating point implementations of combiners for all pixman operators. These combiners operate on buffers containing single precision floating point pixels stored in (a, r, g, b) order. The combiners are added

[Pixman] [PATCH 5/8] pixman-access.c: Add floating point accessor functions

From: Søren Sandmann Pedersen s...@redhat.com Three new function pointer fields are added to bits_image_t: fetch_scanline_float fetch_pixel_float store_scanline_float similar to the existing 32 and 64 bit accessors. The fetcher_info_t struct in pixman_access similarly gets

[Pixman] [PATCH] gtk-utils.c: Use cairo in show_image() rather than GdkPixbuf

From: Søren Sandmann Pedersen s...@redhat.com GdkPixbufs are not premultiplied, so when using them to display pixman images, there is some unecessary conversions going on: First the image is converted to non-premultiplied, and then GdkPixbuf premultiplies before sending the result to the X server

[Pixman] [PATCH 02/11] Add ITER_WIDE iter flag

This will be useful for putting iterators into tables where they can be looked up by iterator flags. Without this flag, wide iterators can only be recognized by the absence of ITER_NARROW, which makes testing for a match difficult. --- pixman/pixman-general.c | 20 +---

[Pixman] [PATCH 05/11] sse2: Replace the fetcher_info_t table with a pixman_iter_info_t table

Similar to the changes to noop, put all the iterators into a table of pixman_iter_info_t and then do a generic search of that table during iterator initialization. --- pixman/pixman-sse2.c | 64 1 file changed, 35 insertions(+), 29 deletions(-)

[Pixman] [PATCH 06/11] mmx: Replace the fetcher_info_t table with a pixman_iter_info_t table

Similar to the SSE2 commit, information about the iterators is stored in a table of pixman_iter_info_t. --- pixman/pixman-mmx.c | 64 + 1 file changed, 35 insertions(+), 29 deletions(-) diff --git a/pixman/pixman-mmx.c b/pixman/pixman-mmx.c

[Pixman] [PATCH 07/11] fast: Replace the fetcher_info_t table with a pixman_iter_info_t table

Similar to the SSE2 and MMX patches, this commit replaces a table of fetcher_info_t with a table of pixman_iter_info_t, and similar to the noop patch, both fast_src_iter_init() and fast_dest_iter_init() are now doing exactly the same thing, so their code can be shared in a new function called

[Pixman] [PATCH 09/11] Add _pixman_implementation_iter_init() and use instead of _src/_dest_init()

A new field, 'iter_info', is added to the implementation struct, and all the implementations store a pointer to their iterator tables in it. A new function, _pixman_implementation_iter_init(), is then added that searches those tables, and the new function is called in pixman-general.c and

[Pixman] [PATCH 11/11] Consolidate all the iter_init_bits_stride functions

The SSE2, MMX, and fast implementations all have a copy of the function iter_init_bits_stride that computes an image buffer and stride. Move that function to pixman-utils.c and share it among all the implementations. --- pixman/pixman-fast-path.c | 19 +-- pixman/pixman-mmx.c

[Pixman] [PATCH 2/2] ssse3: Add iterator for separable bilinear scaling

This new iterator uses the SSSE3 instructions pmaddubsw and pabsw to implement a fast iterator for bilinear scaling. There is a graph here recording the per-pixel time for various bilinear scaling algorithms as reported by scaling-bench:

[Pixman] [PATCHv2 0/3] SSSE3 iterator for bilinear scaling

Here is a new version of the bilinear scaler that fixes Matt's and Siarhei's comments and also uses movdqu instead of movdqa for the writes to iter-buffer. This ensures that the iterator doesn't impose new alignment restrictions that could interfere with the direct-to-destination optimizations.

[Pixman] [PATCHv2 3/3] ssse3: Add iterator for separable bilinear scaling

This new iterator uses the SSSE3 instructions pmaddubsw and pabsw to implement a fast iterator for bilinear scaling. There is a graph here recording the per-pixel time for various bilinear scaling algorithms as reported by scaling-bench:

[Pixman] [PATCHv2 1/3] general: Ensure that iter buffers are aligned to 16 bytes

At the moment iter buffers are only guaranteed to be aligned to a 4 byte boundary. SIMD implementations benefit from the buffers being aligned to 16 bytes, so ensure this is the case. V2: - Use uintptr_t instead of unsigned long - allocate 3 * SCANLINE_BUFFER_LENGTH byte on stack rather than just

[Pixman] [PATCHv2 2/3] Add empty SSSE3 implementation

This commit adds a new, empty SSSE3 implementation and the associated build system support. configure.ac: detect whether the compiler understands SSSE3 intrinsics and set up the required CFLAGS Makefile.am:Add libpixman-ssse3.la pixman-x86.c: Add X86_SSSE3 feature flag

[Pixman] [PATCH 1/3] {scaling, affine, composite-traps}-test: Use compute_crc32_for_image()

By using this function instead of compute_crc32() the alpha masking code and the call to image_endian_swap() are not duplicated. --- test/affine-test.c | 12 ++-- test/composite-traps-test.c | 11 +-- test/scaling-test.c | 12 ++-- 3 files changed, 5

[Pixman] [PATCH 3/3] test: Test negative strides

Pixman supports negative strides, but up until now they haven't been tested outside of stress-test. This commit adds testing of negative strides to blitters-test, scaling-test, affine-test, rotate-test, and composite-traps-test. --- test/affine-test.c | 22 --

[Pixman] [PATCH 2/3] test: Share the image printing code

The affine-test, blitters-test, and scaling-test all have the ability to print out the bytes of the destination image. Share this code by moving it to utils.c. At the same time make the code work correctly with negative strides. --- test/affine-test.c | 12 +---

[Pixman] [PATCH 2/3] Move generated affine fetchers into pixman-fast-path.c

From: Søren Sandmann Pedersen s...@redhat.com The generated fetchers for NEAREST, BILINEAR, and SEPARABLE_CONVOLUTION filters are fast paths and so they belong in pixman-fast-path.c --- pixman/pixman-bits-image.c | 530 pixman/pixman-fast-path.c

[Pixman] [PATCH 0/5] Some changes to Color Dodge and Color Burn

The overall goal of the following patches is to make it more obvious how the blend mode code relates to the specifications. To that end, the comment for each blend routine is updated with some math that shows how we go from specification to a formula that can deal with premultiplied alpha, and the

[Pixman] [PATCH 1/5] pixman-combine32.c: Formatting fixes

Fix a bunch of spacing issues. --- pixman/pixman-combine32.c | 112 +++--- 1 file changed, 56 insertions(+), 56 deletions(-) diff --git a/pixman/pixman-combine32.c b/pixman/pixman-combine32.c index 3ac7576..be3cfdf 100644 --- a/pixman/pixman-combine32.c

[Pixman] [PATCH 2/5] pixman-combine32: Improve documentation for blend mode operators

This commit overhauls the comments in pixman-comine32.c regarding blend modes: - Add a link to the PDF supplement that clarifies the specification of ColorBurn and ColorDodge - Clarify how the formulas for premultiplied colors are derived form the ones in the PDF specifications - Write out

[Pixman] [PATCH 4/5] Make ColorDodge code follow the math closer

Change blend_color_dodge() to follow the math in the comment more closely. Note, the new code here is in some sense worse than the old code because it can now underflow the unsigned variables when the source is superluminescent and (as - s) is therefore negative. The old code was careful to clamp

[Pixman] [PATCH 3/5] pixman-combine32: Rename a number of variable from sa/sca to as/s

There are no semantic changes, just variables renames. The motivation for these renames is so that the names are shorter and better match the one used in the comments. --- pixman/pixman-combine32.c | 199 +++--- 1 file changed, 99 insertions(+), 100

[Pixman] [PATCH 5/5] Make code for color burn follow the math more closely

For superluminescent destinations, the old code could underflow in uint32_t r = (ad - d) * as / s; when (ad - d) was negative. The new code avoids this problem (and therefore causes changes in the checksums of thread-test and blitters-test), but it is likely still buggy due to the use of

[Pixman] [PATCH] Fix comment about BILINEAR_INTERPOLATION_BITS to say 8 rather than = 8

Since a4c79d695d52c94647b1aff7 the constant BILINEAR_INTERPOLATION_BITS must be strictly less than 8, so fix the comment to say this, and also add a COMPILE_TIME_ASSERT in the bilinear fetcher in pixman-fast-path.c --- pixman/pixman-fast-path.c | 2 ++ pixman/pixman-private.h | 2 +- 2 files

[Pixman] [PATCHv2 0/3] More general reduction of BILINEAR to NEAREST

This series addresses the comments by Bill and also changes pixman-fast-path.c so that it picks NEAREST fast paths before BILINEAR. (I noticed this because the new filter-reduction-test.c failed to detect a bug that I deliberately introduced). Søren

[Pixman] [PATCHv2 2/3] Add new test of filter reduction from BILINEAR to NEAREST

leftover comment, some minor formatting fixes, use a timestamp as the PRNG seed. Signed-off-by: Søren Sandmann <soren.sandm...@gmail.com> --- test/Makefile.sources| 1 + test/filter-reduction-test.c | 112 +++ 2 files changed, 113 inse

[Pixman] [PATCH 1/2] Add new test of filter reduction from BILINEAR to NEAREST

-by: Søren Sandmann <soren.sandm...@gmail.com> --- test/Makefile.sources| 1 + test/filter-reduction-test.c | 119 +++ 2 files changed, 120 insertions(+) create mode 100644 test/filter-reduction-test.c diff --git a/test/Makefile.sources

[Pixman] More general BILINEAR to NEAREST reduction

The following two patches generalize the reduction of BILINEAR to NEAREST based on the formula mentioned here: https://lists.freedesktop.org/archives/pixman/2010-August/000321.html Søren ___ Pixman mailing list Pixman@lists.freedesktop.org

[Pixman] [PATCH 04/14] demos/scale: Compute filter size using boundary of xformed ellipse

From: Bill Spitzak Instead of using the boundary of xformed rectangle, use the boundary of xformed ellipse. This is much more accurate and less blurry. In particular the filtering does not change as the image is rotated. Signed-off-by: Bill Spitzak

[Pixman] [PATCH 06/14] demos/scale: Default to locked axis

From: Bill Spitzak <spit...@gmail.com> Signed-off-by: Bill Spitzak <spit...@gmail.com> Reviewed-by: Søren Sandmann <soren.sandm...@gmail.com> --- demos/scale.ui | 1 + 1 file changed, 1 insertion(+) diff --git a/demos/scale.ui b/demos/scale.ui index f6f6e89..d498d26 100644 --

[Pixman] [PATCH 09/14] pixman-filter: Correct Simpsons integration

: more whitespace changes Signed-off-by: Bill Spitzak <spit...@gmail.com> Reviewed-by: Oded Gabbay <oded.gab...@gmail.com> Reviewed-by: Søren Sandmann <soren.sandm...@gmail.com> --- pixman/pixman-filter.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) di

[Pixman] [PATCH 01/14] pixman-fast-path.c: Pick NEAREST affine fast paths before BILINEAR ones

When a BILINEAR filter is reduced to NEAREST, it is possible for both types of fast paths to run; in this case, the NEAREST ones should be preferred as that is the simpler filter. Signed-off-by: Soren Sandmann --- pixman/pixman-fast-path.c | 4 ++-- 1 file changed, 2

[Pixman] [PATCH 08/14] pixman-filter: reduce amount of malloc/free/memcpy to generate filter

_width function v10: Restored filter_width function but with arguments changed to match later patches v11: Removed unused arg and pointer from filter_width function Whitespace fixes. Signed-off-by: Bill Spitzak <spit...@gmail.com> Reviewed-by: Oded Gabbay <oded.gab...@gmail.com&g

[Pixman] [PATCH 10/14] pixman-filter: integral splitting is only needed for triangle filter

w code. Signed-off-by: Bill Spitzak <spit...@gmail.com> Signed-off-by: Søren Sandmann <soren.sandm...@gmail.com> Reviewed-by: Søren Sandmann <soren.sandm...@gmail.com> --- pixman/pixman-filter.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/pixman/

[Pixman] [PATCH 13/14] pixman-filter: Nested polynomial for cubic

From: Bill Spitzak v11: Restored range checks Signed-off-by: Bill Spitzak Reviewed-by: Oded Gabbay --- pixman/pixman-filter.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/pixman/pixman-filter.c

[Pixman] Bill Spitzak patches

Hi, The following patch series contains those of Bill's patches that I think are ready to be pushed to master, plus some other related changes that I also think are ready. 01-03: These are patches to do more BILINEAR->NEAREST filter reductions. They were inspired by a similar patch in

[Pixman] [PATCH 11/14] pixman-filter: Speed up BOX/BOX filter

more details in the commit message. Signed-off-by: Søren Sandmann <soren.sandm...@gmail.com> --- pixman/pixman-filter.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pixman/pixman-filter.c b/pixman/pixman-filter.c index c868723..32aaa9a 100644 --- a/pixman/pixman-fi

[Pixman] [PATCH 02/14] Add new test of filter reduction from BILINEAR to NEAREST

leftover comment, some minor formatting fixes, use a timestamp as the PRNG seed. Signed-off-by: Søren Sandmann <soren.sandm...@gmail.com> --- test/Makefile.sources| 1 + test/filter-reduction-test.c | 112 +++ 2 files changed, 113 inse

[Pixman] [PATCH 03/14] More general BILINEAR=>NEAREST reduction

at the center of a pixel so that BILINEAR becomes identical to NEAREST. V2: Address some comments by Bill Spitzak Signed-off-by: Søren Sandmann <soren.sandm...@gmail.com> --- pixman/pixman-image.c | 66 +-- 1 file changed, 38 insertions(+), 28 del

[Pixman] [PATCH 07/14] pixman-image: Added enable-gnuplot config to view filters in gnuplot

fixes Signed-off-by: Bill Spitzak <spit...@gmail.com> Signed-off-by: Søren Sandmann <soren.sandm...@gmail.com> --- configure.ac | 13 ++ pixman/pixman-filter.c | 115 + pixman/rounding.txt| 1 + 3 files changed, 129 i

[Pixman] [PATCHv2 1/3] pixman-fast-path.c: Pick NEAREST affine fast paths before BILINEAR ones

When a BILINEAR filter is reduced to NEAREST, it is possible for both types of fast paths to run; in this case, the NEAREST ones should be preferred as that is the simpler filter. Signed-off-by: Soren Sandmann --- pixman/pixman-fast-path.c | 4 ++-- 1 file changed, 2

[Pixman] [PATCHv2 3/3] More general BILINEAR=>NEAREST reduction

at the center of a pixel so that BILINEAR becomes identical to NEAREST. V2: Address some comments by Bill Spitzak Signed-off-by: Søren Sandmann <soren.sandm...@gmail.com> --- pixman/pixman-image.c | 66 +-- 1 file changed, 38 insertions(+), 28 del

<    1   2   3   4   5   6