On 01/23/10 03:31 AM, Tim Foster wrote:
On Fri, 2010-01-22 at 13:45 -0600, Shawn Walker wrote:
On 01/22/10 01:28 PM, Tim Foster wrote:
thinking that ssl_cert was being set to '""' - sorry.
Python considers "" to be False when evaluated, so that wouldn't matter
either :)
Yep, absolutely. It
On Fri, 2010-01-22 at 13:45 -0600, Shawn Walker wrote:
> On 01/22/10 01:28 PM, Tim Foster wrote:
> > thinking that ssl_cert was being set to '""' - sorry.
>
> Python considers "" to be False when evaluated, so that wouldn't matter
> either :)
Yep, absolutely. It was the os.path.isabs() check I w
Tim Foster wrote:
Hi Shawn,
On Fri, 2010-01-22 at 11:17 -0600, Shawn Walker wrote:
line 2368, 2370: instead of "if and len() > 0" just use "if
is not None" as everything else around it does
You're right, I misread the comment,
--
2353 # None is checked for here so that a client can
On 01/22/10 01:28 PM, Tim Foster wrote:
Hi Shawn,
On Fri, 2010-01-22 at 11:17 -0600, Shawn Walker wrote:
line 2368, 2370: instead of "if and len()> 0" just use "if
is not None" as everything else around it does
You're right, I misread the comment,
--
2353 # None is checked for here so tha
Hi Shawn,
On Fri, 2010-01-22 at 11:17 -0600, Shawn Walker wrote:
> line 2368, 2370: instead of "if and len() > 0" just use "if
> is not None" as everything else around it does
You're right, I misread the comment,
--
2353 # None is checked for here so that a client can unset a ssl_cert or
2354
On 01/22/10 11:05 AM, Tim Foster wrote:
Hi all,
On Wed, 2010-01-20 at 14:39 -0800, Brock Pytlik wrote:
Shawn Walker wrote:
I'd rather see us turn the relative path into an absolute path using
os.path.normpath() and the working directory that was active at
startup before the Image() or ImageInt
Hi all,
On Wed, 2010-01-20 at 14:39 -0800, Brock Pytlik wrote:
> Shawn Walker wrote:
> > I'd rather see us turn the relative path into an absolute path using
> > os.path.normpath() and the working directory that was active at
> > startup before the Image() or ImageInterface() object is construct
On 01/20/10 04:47 PM, Tim Foster wrote:
On Wed, 2010-01-20 at 14:39 -0800, Brock Pytlik wrote:
Shawn Walker wrote:
I'd rather see us turn the relative path into an absolute path using
os.path.normpath() and the working directory that was active at
startup before the Image() or ImageInterface()
On Wed, 2010-01-20 at 14:39 -0800, Brock Pytlik wrote:
> Shawn Walker wrote:
> > I'd rather see us turn the relative path into an absolute path using
> > os.path.normpath() and the working directory that was active at
> > startup before the Image() or ImageInterface() object is constructed.
> >
>
Shawn Walker wrote:
On 01/20/10 03:34 PM, Brock Pytlik wrote:
Tim Foster wrote:
Hi all,
I've got fixes for two bugs here that I'd appreciate a code review of
please:
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
they're pretty minor changes I think, but comments welcome.
cheers
On 01/20/10 03:34 PM, Brock Pytlik wrote:
Tim Foster wrote:
Hi all,
I've got fixes for two bugs here that I'd appreciate a code review of
please:
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
they're pretty minor changes I think, but comments welcome.
cheers,
tim
__
Tim Foster wrote:
Hi all,
I've got fixes for two bugs here that I'd appreciate a code review of
please:
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
they're pretty minor changes I think, but comments welcome.
cheers,
tim
_
On 01/20/10 07:07 AM, Tim Foster wrote:
Hi all,
I've got fixes for two bugs here that I'd appreciate a code review of
please:
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
they're pretty minor changes I think, but comments welcome.
I'm not certain we should make the change for b
Hi all,
I've got fixes for two bugs here that I'd appreciate a code review of
please:
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
they're pretty minor changes I think, but comments welcome.
cheers,
tim
_
14 matches
Mail list logo
