Re: [pkg-discuss] Code review request for bug 954

2008-05-30 Thread Tom Mueller
The updatetool GUI supports updating a list of (user) images so it does deal with multiple images. I wasn't aware of any other code in IPS that assumes that a single process only deals with a single image. Currently, the portable module doesn't have anything in it that knows about images or a

Re: [pkg-discuss] Code review request for bug 954

2008-05-29 Thread Danek Duvall
On Thu, May 29, 2008 at 09:08:05PM -0500, Shawn Walker wrote: > General comment: > For some reason, doing this through rename doesn't seem like the right > solution. > > However, I'm not sure what the right answer is. I'm not sure there's a better place for it. But I'd rather see the Windows c

Re: [pkg-discuss] Code review request for bug 954

2008-05-29 Thread Shawn Walker
2008/5/29 rajkumar <[EMAIL PROTECTED]>: > The following webrev has fix for the bug > > 954 : Updating the IPS using the IPS fails on windows. > http://defect.opensolaris.org/bz/show_bug.cgi?id=954 > > > webrev: > http://cr.opensolaris.org/~rajkumar/cr-954/

[pkg-discuss] Code review request for bug 954

2008-05-29 Thread rajkumar
The following webrev has fix for the bug 954 : Updating the IPS using the IPS fails on windows. http://defect.opensolaris.org/bz/show_bug.cgi?id=954 _* webrev*_: http://cr.opensolaris.org/~rajkumar/cr-954/ regards, Rajkumar

Re: [pkg-discuss] Code review request for bug 954

2008-04-15 Thread Bart Smaalders
Rajkumar Srinivasan wrote: > Please review the changes for the bug: > > *954 Updating of IPS using IPS fails* > > http://cr.opensolaris.org/~rajkumar/cr-954/ > > > The solution , while updating in windows if the file is > in use , move it to the t

Re: [pkg-discuss] Code review request for bug 954

2008-04-15 Thread Danek Duvall
You need to push all the cost here into the windows module directly. There should be no changes to image.py, os_unix.py, or file.py. Danek ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Re: [pkg-discuss] Code review request for bug 954

2008-04-15 Thread Stephen Hahn
* Rajkumar Srinivasan <[EMAIL PROTECTED]> [2008-04-15 11:45]: > Please review the changes for the bug: > > *954 Updating of IPS using IPS fails* > > http://cr.opensolaris.org/~rajkumar/cr-954/ > > > The solution , while updating in windows if the

[pkg-discuss] Code review request for bug 954

2008-04-15 Thread Rajkumar Srinivasan
Please review the changes for the bug: *954 Updating of IPS using IPS fails* http://cr.opensolaris.org/~rajkumar/cr-954/ The solution , while updating in windows if the file is in use , move it to the temporary directory inside the metadata and