Re: [pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-12-01 Thread David . Comay
>> After review by David, the set ofg changed files has been adjusted to >> just those that are in the latest (101a) build. > > What's the concern? The behavior should be the same, shouldn't it? It should but it didn't seem necessary to change all of them since we don't typically go back and chan

Re: [pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-12-01 Thread Danek Duvall
On Mon, Dec 01, 2008 at 09:34:24AM -0800, Rich Burridge wrote: > It should. Here's what David sent me: > > "Although I don't have a very strong preference here, I'd prefer that > the older versions of the import files aren't touched and that instead > you simply fix the latest versions of each one

Re: [pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-12-01 Thread Rich Burridge
Danek Duvall wrote: > On Mon, Dec 01, 2008 at 09:08:04AM -0800, Rich Burridge wrote: > > >> After review by David, the set ofg changed files has been adjusted to >> just those that are in the latest (101a) build. >> > > What's the concern? The behavior should be the same, shouldn't it? >

Re: [pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-12-01 Thread Danek Duvall
On Mon, Dec 01, 2008 at 09:08:04AM -0800, Rich Burridge wrote: > After review by David, the set ofg changed files has been adjusted to > just those that are in the latest (101a) build. What's the concern? The behavior should be the same, shouldn't it? Danek _

Re: [pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-12-01 Thread Rich Burridge
Hi all, After review by David, the set ofg changed files has been adjusted to just those that are in the latest (101a) build. These are: src/util/distro-import/00/common/SUNWgnome-system-tools src/util/distro-import/00/common/SUNWj6dev src/util/distro-import/00/common/SUNWsmf_repo src/uti

Re: [pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-11-18 Thread johansen
This looks fine to me. -j On Tue, Nov 18, 2008 at 01:59:39PM -0800, Rich Burridge wrote: > Hi all, > > (This is for post OpenSolaris 2008.11) > > I'm looking for a review of the fix for bug #4475: > > http://defect.opensolaris.org/bz/show_bug.cgi?id=4475 > importer recipes shouldn't use fr

Re: [pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-11-18 Thread Danek Duvall
On Tue, Nov 18, 2008 at 01:59:39PM -0800, Rich Burridge wrote: > http://cr.opensolaris.org/~richb/pkg-4475-v1/ Yup, looks fine. Danek ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

[pkg-discuss] Code review request for opensolaris packaging bug #4475.

2008-11-18 Thread Rich Burridge
Hi all, (This is for post OpenSolaris 2008.11) I'm looking for a review of the fix for bug #4475: http://defect.opensolaris.org/bz/show_bug.cgi?id=4475 importer recipes shouldn't use from ./* Webrev is at: http://cr.opensolaris.org/~richb/pkg-4475-v1/ Tested by doing a redist_import to