Re: [pkg-discuss] codereview for output enhancements

2008-01-21 Thread Dan Price
On Fri 18 Jan 2008 at 03:40PM, Danek Duvall wrote: > On Thu, Jan 17, 2008 at 04:40:54PM -0800, Dan Price wrote: > > > http://cr.opensolaris.org/~dp/ips-status/ > > Pretty much just a bunch of nits ... > > You're using tabs instead of spaces for indentation in many places. If > it's not

Re: [pkg-discuss] codereview for output enhancements

2008-01-18 Thread Danek Duvall
On Thu, Jan 17, 2008 at 04:40:54PM -0800, Dan Price wrote: > http://cr.opensolaris.org/~dp/ips-status/ Pretty much just a bunch of nits ... You're using tabs instead of spaces for indentation in many places. If it's not going to be too much, could you expand your tabs to eight spaces?

Re: [pkg-discuss] codereview for output enhancements

2008-01-17 Thread Stephen Hahn
* Dan Price <[EMAIL PROTECTED]> [2008-01-18 00:41]: > > Hi all, > > I've been working away to improve the command line output of various > parts of the 'pkg' command; please take a look at this wad: > > 373 design a nice default output for install/update/remove > 374 filelist sho

Re: [pkg-discuss] codereview for output enhancements

2008-01-17 Thread johansen
This looks good. The only nit I have is that you need to fix the -b option to install and image-update so that it works with the file-size changes you made. The -b option used to allow you to specify the number of files in a filelist, but since that's changed it probably makes sense to use that o

[pkg-discuss] codereview for output enhancements

2008-01-17 Thread Dan Price
Hi all, I've been working away to improve the command line output of various parts of the 'pkg' command; please take a look at this wad: 373 design a nice default output for install/update/remove 374 filelist should work in ~5MB chunks, not in 64 file increments 381 Fix s