Re: [pkg-discuss] li perf improvements webrev

2011-06-14 Thread Danek Duvall
Edward Pilatowicz wrote: > o'yeah. i updated the webrev with these changes. LGTM. Danek ___ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Re: [pkg-discuss] li perf improvements webrev

2011-06-09 Thread Brock Pytlik
On 06/09/11 21:27, Edward Pilatowicz wrote: On Thu, Jun 09, 2011 at 08:08:59PM -0700, Edward Pilatowicz wrote: On Wed, Jun 08, 2011 at 07:15:54PM -0700, Danek Duvall wrote: Edward Pilatowicz wrote: On Tue, Jun 07, 2011 at 11:57:01AM -0700, Danek Duvall wrote: Edward Pilatowicz wrote: http:

Re: [pkg-discuss] li perf improvements webrev

2011-06-09 Thread Edward Pilatowicz
On Thu, Jun 09, 2011 at 08:08:59PM -0700, Edward Pilatowicz wrote: > On Wed, Jun 08, 2011 at 07:15:54PM -0700, Danek Duvall wrote: > > Edward Pilatowicz wrote: > > > > > On Tue, Jun 07, 2011 at 11:57:01AM -0700, Danek Duvall wrote: > > > > Edward Pilatowicz wrote: > > > > > > > > > http://mcescher.

Re: [pkg-discuss] li perf improvements webrev

2011-06-09 Thread Edward Pilatowicz
On Wed, Jun 08, 2011 at 07:15:54PM -0700, Danek Duvall wrote: > Edward Pilatowicz wrote: > > > On Tue, Jun 07, 2011 at 11:57:01AM -0700, Danek Duvall wrote: > > > Edward Pilatowicz wrote: > > > > > > > http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ > > > > > > imageplan.py: > > > > > >

Re: [pkg-discuss] li perf improvements webrev

2011-06-08 Thread Danek Duvall
Edward Pilatowicz wrote: > On Tue, Jun 07, 2011 at 11:57:01AM -0700, Danek Duvall wrote: > > Edward Pilatowicz wrote: > > > > > http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ > > > > imageplan.py: > > > > - line 469: would it be any faster to just pass all of reject_list into > >

Re: [pkg-discuss] li perf improvements webrev

2011-06-07 Thread Edward Pilatowicz
On Tue, Jun 07, 2011 at 11:57:01AM -0700, Danek Duvall wrote: > Edward Pilatowicz wrote: > > > http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ > > imageplan.py: > > - line 469: would it be any faster to just pass all of reject_list into > match_user_stems() at once? > yes it would

Re: [pkg-discuss] li perf improvements webrev

2011-06-07 Thread Danek Duvall
Edward Pilatowicz wrote: > http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ imageplan.py: - line 469: would it be any faster to just pass all of reject_list into match_user_stems() at once? - line 483: "uninstalling" -> "uninstall" - line 487: "todo" -> "to do" common.py:

Re: [pkg-discuss] li perf improvements webrev

2011-06-06 Thread Brock Pytlik
On 06/06/11 18:15, Edward Pilatowicz wrote: On Mon, Jun 06, 2011 at 02:05:14PM -0700, Brock Pytlik wrote: [snip] common.py: 2229: If there's any chance of the command being run generating a copious amount of error output, then a p.communicate() is probably needed, otherwise there's a chance of

Re: [pkg-discuss] li perf improvements webrev

2011-06-06 Thread Edward Pilatowicz
On Mon, Jun 06, 2011 at 02:05:14PM -0700, Brock Pytlik wrote: > On 06/04/11 17:14, Edward Pilatowicz wrote: > >hey all, > > > >i'm looking for a review of some quick and easy linked image performance > >fixes. > > > >http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ > > > >18489 skip genera

Re: [pkg-discuss] li perf improvements webrev

2011-06-06 Thread johansen
On Mon, Jun 06, 2011 at 02:05:14PM -0700, Brock Pytlik wrote: > On 06/04/11 17:14, Edward Pilatowicz wrote: > >http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ > > > common.py: > 2229: If there's any chance of the command being run generating a > copious amount of error output, then a p.co

Re: [pkg-discuss] li perf improvements webrev

2011-06-06 Thread Brock Pytlik
On 06/04/11 17:14, Edward Pilatowicz wrote: hey all, i'm looking for a review of some quick and easy linked image performance fixes. http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ 18489 skip generating parent deps if we're running a build with parent deps 18490 sync-linked can be fa

[pkg-discuss] li perf improvements webrev

2011-06-04 Thread Edward Pilatowicz
hey all, i'm looking for a review of some quick and easy linked image performance fixes. http://mcescher.us.oracle.com/export/ws/pkg.perf2/webrev/ 18489 skip generating parent deps if we're running a build with parent deps 18490 sync-linked can be faster when there's nothing todo 18491 noop pack