On Thu, May 07, 2009 at 03:59:43PM -0700, david.co...@sun.com wrote:
> I'd appreciate a review and approval to integrate the fix for the
> following blocker
>
> 8783 Include SUNWgetting-started-l10n-extra in the repository
> http://defect.opensolaris.org/bz/show_bug.cgi?id=8783
>
> Sin
david.co...@sun.com wrote:
I'd appreciate a review and approval to integrate the fix for the
following blocker
8783 Include SUNWgetting-started-l10n-extra in the repository
http://defect.opensolaris.org/bz/show_bug.cgi?id=8783
Since the diff is straightforward, I've included it here. T
I'd appreciate a review and approval to integrate the fix for the
following blocker
8783 Include SUNWgetting-started-l10n-extra in the repository
http://defect.opensolaris.org/bz/show_bug.cgi?id=8783
Since the diff is straightforward, I've included it here. Thanks.
diff -r 0075
I'd appreciate a code review of the fix for
7793 Numerous driver actions need work
I've included the proposed fix here since it's so short. Thanks.
--- src/util/distro-import/111/common/SUNWckr Mon Mar 30 11:12:18 2009 +0100
+++ src/util/distro-import/111/common/SUNWckr Mon Mar 30
On 5/03/2009, at 8:50 PM, david.co...@sun.com wrote:
I'd appreciate a review of the fix for
7132 Visual Panels should be made available on SPARC
The fix is so short, I've included it below.
LGTM.
Glynn
___
pkg-discuss mailing list
pkg-d
I'd appreciate a review of the fix for
7132 Visual Panels should be made available on SPARC
The fix is so short, I've included it below.
Thanks.
diff -r eccb14dedf29 src/util/distro-import/109/redist_cluster
--- a/src/util/distro-import/109/redist_cluster Wed Mar 04 18:23:51 2009 -0800
> > 1. Does switching from unbuffered output to buffered output affect the
> > correctness of any operations that we're performing?
>
> Um. I highly doubt it. What kind of problems, if any, might be expected?
>
> > 2. The pkgsubprocess module used pspawn to reduce the as_dup overhead
> > when f
On Tue, Dec 09, 2008 at 02:54:26PM -0800, [EMAIL PROTECTED] wrote:
> 1. Does switching from unbuffered output to buffered output affect the
> correctness of any operations that we're performing?
Um. I highly doubt it. What kind of problems, if any, might be expected?
> 2. The pkgsubprocess mod
I guess I really have two questions:
1. Does switching from unbuffered output to buffered output affect the
correctness of any operations that we're performing?
2. The pkgsubprocess module used pspawn to reduce the as_dup overhead
when forking in low-memory situations. I'm assuming that in most
On wto, 2008-12-09 at 14:48 -0800, Danek Duvall wrote:
> On Tue, Dec 09, 2008 at 02:41:42PM -0800, [EMAIL PROTECTED] wrote:
>
> > but does it have any adverse effects elsewhere?
Hi,
The subprocess is used in the GUI code for the BE management. I will
check Tomorrow morning if this doesn't affect t
On Tue, Dec 09, 2008 at 02:41:42PM -0800, [EMAIL PROTECTED] wrote:
> but does it have any adverse effects elsewhere?
I'm not sure how to test for that. I can do an install of slim_install and
see that nothing goes awry, if that would assuage your doubts.
> Do we really need a 128k buffer for ev
> I discovered that when importing a 7z'ed package, we're reading data from
> the 7z pipe one character at a time, which slows things down a bit. I
> filed
>
> 5724 seriously suboptimal bufsize in cpiofile.py
>
> and have fixed this globally with
>
> http://cr.opensolaris.org/~dduvall/p
Dan Price wrote:
> On Tue 09 Dec 2008 at 02:33PM, Danek Duvall wrote:
>> I discovered that when importing a 7z'ed package, we're reading data from
>> the 7z pipe one character at a time, which slows things down a bit. I
>> filed
>>
>> 5724 seriously suboptimal bufsize in cpiofile.py
>>
>> and
On Tue, Dec 09, 2008 at 02:35:59PM -0800, Dan Price wrote:
> I presume we're not committing the same sin anywhere else in our code,
> correct?
We're using pkgsubprocess everywhere except in a couple places in the test
suite and in setup.py. I don't think either warrants the change, though I
coul
On 12/09/08 14:33, Danek Duvall wrote:
> I discovered that when importing a 7z'ed package, we're reading data from
> the 7z pipe one character at a time, which slows things down a bit. I
> filed
>
> 5724 seriously suboptimal bufsize in cpiofile.py
>
> and have fixed this globally with
>
>
On Tue 09 Dec 2008 at 02:33PM, Danek Duvall wrote:
> I discovered that when importing a 7z'ed package, we're reading data from
> the 7z pipe one character at a time, which slows things down a bit. I
> filed
>
> 5724 seriously suboptimal bufsize in cpiofile.py
>
> and have fixed this globally
I discovered that when importing a 7z'ed package, we're reading data from
the 7z pipe one character at a time, which slows things down a bit. I
filed
5724 seriously suboptimal bufsize in cpiofile.py
and have fixed this globally with
http://cr.opensolaris.org/~dduvall/pkg-bufsize/
by ma
LGTM
Brad Hall wrote:
> Hi,
>
> Link to webrev: http://cr.opensolaris.org/~bhall/bug-4818/
> Link to BUG: http://defect.opensolaris.org/bz/show_bug.cgi?id=4818
>
> This change corrects the lambda that is sent for the check_cancellation
> function. Basically at this point if we hit any cancellati
Hi,
Link to webrev: http://cr.opensolaris.org/~bhall/bug-4818/
Link to BUG: http://defect.opensolaris.org/bz/show_bug.cgi?id=4818
This change corrects the lambda that is sent for the check_cancellation
function. Basically at this point if we hit any cancellation points,
pkg fix will blow up an
Looks good.
One modification I would suggest: expand the IOError catch blocks around
the os.() operations to include OSError. IIRC, the os module will
sometimes raise them instead of IOErrors.
I didn't realize that os.stat returned an object. I had been using the
antiquated method of using stat
Danek Duvall wrote:
> http://cr.opensolaris.org/~dduvall/pkg-devlinks-perms/
>
> should fix
>
> 3903 driver action doesn't reset etc/devlink.tab owner/group to match
> SUNWcsd
>
> where I was writing devlinks data into a temp file and moving that into
> place, but without changing the p
http://cr.opensolaris.org/~dduvall/pkg-devlinks-perms/
should fix
3903 driver action doesn't reset etc/devlink.tab owner/group to match
SUNWcsd
where I was writing devlinks data into a temp file and moving that into
place, but without changing the perms on the temp file away from 0600 a
Looks right to me.
Danek
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
http://cr.opensolaris.org/~comay/webrev-992/
I'd appreciate a review of the above webrev - it works around a newly
identified ZFS-related issue that came into build 86 and includes the
packaging changes to include the localized Getting Started guide.
Thanks.
dsc
__
24 matches
Mail list logo
