I need a code review for:
6793 p2v support for ipkg-branded zones
There is a webrev at:
http://cr.opensolaris.org/~gjelinek/webrev.6793/
The two large files, image_install and p2v,
do not need to be fully reviewed since most of
the code is the same as what we already have with the
native brand
On Wed 05 Nov 2008 at 12:39PM, Jerry Jelinek wrote:
> Dan Price wrote:
> >Must the mountpoint be set to legacy prior to mounting the dataset to do
> >the verification step? It seems to me that if the mountpoint was
> >already 'legacy' and the dataset was already mounted (by hand on /mnt,
> >say),
Dan Price wrote:
> Must the mountpoint be set to legacy prior to mounting the dataset to do
> the verification step? It seems to me that if the mountpoint was
> already 'legacy' and the dataset was already mounted (by hand on /mnt,
> say), then this would fail... should we check to see if it is mo
On Tue 04 Nov 2008 at 03:47PM, Jerry Jelinek wrote:
> Dan,
>
> Thanks for looking at this.
>
> I'll add some additional handling around that. What
> I do when we detach a zone is leave it mounted and
> set the mount point so that it is easy to archive up
> the image for transfer to another machi
Dan Price wrote:
> On Tue 04 Nov 2008 at 01:59PM, Shawn Walker wrote:
>> Jerry Jelinek wrote:
>>> I have a fix for:
>>>
>>> 4513 need option to attach existing dataset
>>>
>>> There is a webrev at:
>>>
>>> http://cr.opensolaris.org/~gjelinek/webrev.4513/
>> src/brand/attach:
>>line 29: s/existi
On Tue 04 Nov 2008 at 01:59PM, Shawn Walker wrote:
> Jerry Jelinek wrote:
> > I have a fix for:
> >
> > 4513 need option to attach existing dataset
> >
> > There is a webrev at:
> >
> > http://cr.opensolaris.org/~gjelinek/webrev.4513/
>
> src/brand/attach:
>line 29: s/existing dataset\n/exi
Jerry Jelinek wrote:
> I have a fix for:
>
> 4513 need option to attach existing dataset
>
> There is a webrev at:
>
> http://cr.opensolaris.org/~gjelinek/webrev.4513/
src/brand/attach:
line 29: s/existing dataset\n/existing dataset.\n/
I don't feel confident enough to comment on the rest.
I have a fix for:
4513 need option to attach existing dataset
There is a webrev at:
http://cr.opensolaris.org/~gjelinek/webrev.4513/
Thanks,
Jerry
___
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pk
