Your message dated Thu, 15 Feb 2018 22:44:15 +0100
with message-id
<CANnVG6=h0qj17-xjWKyaUzrYrmmK77Hy2F_X13OHwR=9tha...@mail.gmail.com>
and subject line Re: [pkg-go] Bug#890340: Unable to checkout Grafana 4.6.3
has caused the Debian Bug report #890340,
regarding Unable to checkout Grafana 4.6.3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
890340: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890340
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dh-make-golang
Version: 0.0~git20180129.37f630a-1
Go packagers suggest using 'dh-make-golang' to create skeleton package for
software written in Go. So I tried it:
16:28 (0s) linaro@cb-r1-m1-c1n1:dh-make-golang$ dh-make-golang -git_revision
v4.6.3 github.com/grafana/grafana
2018/02/13 16:28:15 Downloading "github.com/grafana/grafana/..."
go get: 240.09 MiB2018/02/13 16:29:38 Checking out git revision "v4.6.3"
2018/02/13 16:29:38 Refreshing "github.com/grafana/grafana/..."
go get: 516.27 MiBpackage assert: unrecognized import path "assert" (import
path does not begin with hostname)
2018/02/13 16:30:43 Could not create a tarball of the upstream source: exit
status 1
Same result with version in 'stretch', 'sid' or with one built from git HEAD.
--- End Message ---
--- Begin Message ---
Thanks for the report. I can reproduce the issue with Go 1.7, Go 1.8, but
not Go 1.9:
% PATH=/usr/lib/go-1.8/bin:/usr/bin:/usr/sbin:/bin:/sbin
~/go/bin/dh-make-golang -git_revision v4.6.3 github.com/grafana/grafana
2018/02/15 21:51:35 Downloading "github.com/grafana/grafana/..."
go get: 240.40 MiB2018/02/15 21:52:36 Checking out git revision "v4.6.3"
2018/02/15 21:52:36 Refreshing "github.com/grafana/grafana/..."
go get: 516.64 MiBpackage assert: unrecognized import path "assert" (import
path does not begin with hostname)
2018/02/15 21:53:44 Could not create a tarball of the upstream source: exit
status 1
% PATH=/usr/lib/go-1.9/bin:/usr/bin:/usr/sbin:/bin:/sbin
~/go/bin/dh-make-golang -git_revision v4.6.3 github.com/grafana/grafana
2018/02/15 21:54:19 Downloading "github.com/grafana/grafana/..."
go get: 231.98 MiBwarning: ignoring symlink
/tmp/dh-make-golang898846893/src/
github.com/grafana/grafana/vendor/github.com/prometheus/procfs/fixtures/self
go get: 240.40 MiBwarning: ignoring symlink
/tmp/dh-make-golang898846893/src/
github.com/grafana/grafana/vendor/github.com/prometheus/procfs/fixtures/self
go get: 240.40 MiB2018/02/15 21:55:28 Checking out git revision "v4.6.3"
2018/02/15 21:55:28 Refreshing "github.com/grafana/grafana/..."
2018/02/15 21:55:29 Deleting upstream vendor/ directories, installing
remaining dependencies
go get: 489.58 MiB2018/02/15 21:57:24 Determining upstream version number
2018/02/15 21:57:24 Package version is "4.6.3"
2018/02/15 21:57:24 Determining dependencies
2018/02/15 21:57:31 Assuming you are packaging a program (because "
github.com/grafana/grafana/pkg/cmd/grafana-cli" defines a main package),
use -type to override
2018/02/15 21:57:35 Build-Dependency "github.com/yudai/gojsondiff" is not
yet available in Debian, or has not yet been converted to use
XS-Go-Import-Path in debian/control
2018/02/15 21:57:35 Build-Dependency "github.com/benbjohnson/clock" is not
yet available in Debian, or has not yet been converted to use
XS-Go-Import-Path in debian/control
2018/02/15 21:57:35 Build-Dependency "github.com/go-ldap/ldap" is not yet
available in Debian, or has not yet been converted to use XS-Go-Import-Path
in debian/control
2018/02/15 21:57:35 Build-Dependency "github.com/uber/jaeger-client-go" is
not yet available in Debian, or has not yet been converted to use
XS-Go-Import-Path in debian/control
2018/02/15 21:57:35 Build-Dependency "github.com/patrickmn/go-cache" is not
yet available in Debian, or has not yet been converted to use
XS-Go-Import-Path in debian/control
2018/02/15 21:57:37
2018/02/15 21:57:37 Packaging successfully created in /tmp/grafana
2018/02/15 21:57:37
2018/02/15 21:57:37 Resolve all TODOs in itp-grafana.txt, then email it out:
2018/02/15 21:57:37 sendmail -t < itp-grafana.txt
2018/02/15 21:57:37
2018/02/15 21:57:37 Resolve all the TODOs in debian/, find them using:
2018/02/15 21:57:37 grep -r TODO debian
2018/02/15 21:57:37
2018/02/15 21:57:37 To build the package, commit the packaging and use gbp
buildpackage:
2018/02/15 21:57:37 git add debian && git commit -a -m 'Initial
packaging'
2018/02/15 21:57:37 gbp buildpackage --git-pbuilder
2018/02/15 21:57:37
2018/02/15 21:57:37 To create the packaging git repository on alioth, use:
2018/02/15 21:57:37 ssh git.debian.org "/git/pkg-go/setup-repository
grafana 'Packaging for grafana'"
2018/02/15 21:57:37
2018/02/15 21:57:37 Once you are happy with your packaging, push it to
alioth using:
2018/02/15 21:57:37 git remote set-url origin git+ssh://
git.debian.org/git/pkg-go/packages/grafana.git
2018/02/15 21:57:37 gbp push
After a closer look, the issue is that dh-make-golang calls “go get -d -t
github.com/grafana/grafana/...”, and Go < 1.9 resolves the ... to
include vendor/github.com/bmizerany/assert/example/point_test.go, which
contains “import "assert"”, which just doesn’t compile.
Newer versions of grafana removed vendor/
github.com/bmizerany/assert/example/point_test.go. On top of that, Go
1.9 doesn’t include vendor/ when resolving ... anymore:
https://golang.org/doc/go1.9#vendor-dotdotdot
In general, upstream software doesn’t necessarily build with older Go
compiler versions. Some projects offer some guidance as to which versions
are supported; usually that’s the current and maybe the previous compiler
version.
I’m not entirely sure how to best address this: on the one hand, one could
add a dependency on e.g. golang-1.9 to dh-make-golang, but on the other
hand, dh-make-golang itself is agnostic of what it’s packaging — it might
be useful to use dh-make-golang with older Go compiler versions as long as
you restrict yourself to packaging software which works with the older
compiler version.
That being said, commit
https://github.com/Debian/dh-make-golang/commit/35c0dc70022fcdc6c960639706f4bcf3e8b31c21
sidesteps the problem entirely by removing the operation which tripped over
the vendor/ directory.
Hence, I’ll close the report for now. Let me know if there’s anything left
to be done.
On Tue, Feb 13, 2018 at 5:34 PM, Marcin Juszkiewicz <
marcin.juszkiew...@linaro.org> wrote:
> Package: dh-make-golang
> Version: 0.0~git20180129.37f630a-1
>
> Go packagers suggest using 'dh-make-golang' to create skeleton package for
> software written in Go. So I tried it:
>
> 16:28 (0s) linaro@cb-r1-m1-c1n1:dh-make-golang$ dh-make-golang
> -git_revision v4.6.3 github.com/grafana/grafana
> 2018/02/13 16:28:15 Downloading "github.com/grafana/grafana/..."
> go get: 240.09 MiB2018/02/13 16:29:38 Checking out git revision "v4.6.3"
> 2018/02/13 16:29:38 Refreshing "github.com/grafana/grafana/..."
> go get: 516.27 MiBpackage assert: unrecognized import path "assert"
> (import path does not begin with hostname)
> 2018/02/13 16:30:43 Could not create a tarball of the upstream source:
> exit status 1
>
>
> Same result with version in 'stretch', 'sid' or with one built from git
> HEAD.
>
> _______________________________________________
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
>
--
Best regards,
Michael
--- End Message ---
_______________________________________________
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
