Your message dated Wed, 07 Oct 2020 10:19:16 +0000
with message-id <e1kq6xu-00042r...@fasolo.debian.org>
and subject line Bug#968681: fixed in nodejs 12.19.0~dfsg-1
has caused the Debian Bug report #968681,
regarding nodejs: regresses in ppc64el ( node-create-hash,
node-crypto-browserify, node-sha.js)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
968681: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968681
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: nodejs
Version: 12.18.2~dfsg-1
Severity: serious
Hello, looks like node-create-hask, node-crypto-browserify, node-sha.js have
autopkgtests failures on ppc64el.
there might be an upstream patch according to Ubuntu bug [1] and v8 commits
https://ci.debian.net/data/autopkgtest/unstable/ppc64el/n/node-crypto-browserify/6740061/log.gz
https://ci.debian.net/data/autopkgtest/unstable/ppc64el/n/node-sha.js/6740057/log.gz
https://ci.debian.net/data/autopkgtest/unstable/ppc64el/n/node-create-hash/6738537/log.gz
the attached diff (based on upstream changes) might help in fixing the failures.
[1] https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144
I just uploaded in Ubuntu, will see in 24h or so if the problem is fixed or not.
G.
diff -Nru nodejs-12.18.2~dfsg/debian/changelog
nodejs-12.18.2~dfsg/debian/changelog
--- nodejs-12.18.2~dfsg/debian/changelog 2020-07-28 15:12:12.000000000
+0200
+++ nodejs-12.18.2~dfsg/debian/changelog 2020-08-19 20:47:23.000000000
+0200
@@ -1,3 +1,12 @@
+nodejs (12.18.2~dfsg-1ubuntu2) groovy; urgency=medium
+
+ * debian/patches/3f071e3.patch:
+ * debian/patches/1a9c676a141b32483b48884f8cc0330e64c8e17f.patch:
+ - cherry-pick two upstream changes in v8 to fix a testsuite failure on
+ ppc64el for some sha1 calculation errors (LP: #1887144)
+
+ -- Gianfranco Costamagna <locutusofb...@debian.org> Wed, 19 Aug 2020
20:47:23 +0200
+
nodejs (12.18.2~dfsg-1ubuntu1) groovy; urgency=medium
* Merge from Debian (LP: #1882185). Remaining changes:
diff -Nru
nodejs-12.18.2~dfsg/debian/patches/1a9c676a141b32483b48884f8cc0330e64c8e17f.patch
nodejs-12.18.2~dfsg/debian/patches/1a9c676a141b32483b48884f8cc0330e64c8e17f.patch
---
nodejs-12.18.2~dfsg/debian/patches/1a9c676a141b32483b48884f8cc0330e64c8e17f.patch
1970-01-01 01:00:00.000000000 +0100
+++
nodejs-12.18.2~dfsg/debian/patches/1a9c676a141b32483b48884f8cc0330e64c8e17f.patch
2020-08-19 20:47:23.000000000 +0200
@@ -0,0 +1,44 @@
+From 1a9c676a141b32483b48884f8cc0330e64c8e17f Mon Sep 17 00:00:00 2001
+From: Milad Farazmand <milad...@ca.ibm.com>
+Date: Mon, 10 Aug 2020 20:19:25 +0000
+Subject: [PATCH] PPC: clear high 32 bits from the result of mulhw.
+
+The hight 32 bits of the result of mulhw are undefined and need
+to be cleared manually.
+
+Change-Id: I0e746898aa26a7970ab59b89c374afd1377028ea
+Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2347208
+Reviewed-by: Junliang Yan <j...@ca.ibm.com>
+Commit-Queue: Milad Farazmand <milad...@ca.ibm.com>
+Cr-Commit-Position: refs/heads/master@{#69318}
+---
+ src/compiler/backend/ppc/code-generator-ppc.cc | 14 ++++++++++----
+ 1 file changed, 10 insertions(+), 4 deletions(-)
+
+diff --git a/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
b/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
+index 337cd795ede..c18500f6e3b 100644
+--- a/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
++++ b/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
+@@ -1480,12 +1480,18 @@ CodeGenerator::CodeGenResult
CodeGenerator::AssembleArchInstruction(
+ }
+ break;
+ case kPPC_MulHigh32:
+- __ mulhw(i.OutputRegister(), i.InputRegister(0), i.InputRegister(1),
+- i.OutputRCBit());
++ __ mulhw(ip, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
++ // High 32 bits are undefined and need to be cleared.
++ __ li(r0, Operand(-1));
++ __ clrldi(r0, r0, Operand(32));
++ __ and_(i.OutputRegister(), ip, r0);
+ break;
+ case kPPC_MulHighU32:
+- __ mulhwu(i.OutputRegister(), i.InputRegister(0), i.InputRegister(1),
+- i.OutputRCBit());
++ __ mulhwu(ip, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
++ // High 32 bits are undefined and need to be cleared.
++ __ li(r0, Operand(-1));
++ __ clrldi(r0, r0, Operand(32));
++ __ and_(i.OutputRegister(), ip, r0);
+ break;
+ case kPPC_MulDouble:
+ ASSEMBLE_FLOAT_BINOP_RC(fmul, MiscField::decode(instr->opcode()));
diff -Nru nodejs-12.18.2~dfsg/debian/patches/3f071e3.patch
nodejs-12.18.2~dfsg/debian/patches/3f071e3.patch
--- nodejs-12.18.2~dfsg/debian/patches/3f071e3.patch 1970-01-01
01:00:00.000000000 +0100
+++ nodejs-12.18.2~dfsg/debian/patches/3f071e3.patch 2020-08-19
20:47:23.000000000 +0200
@@ -0,0 +1,39 @@
+From 3f071e3e7e15af187267af6c3b369029e27c8cf5 Mon Sep 17 00:00:00 2001
+From: Milad Farazmand <milad...@ca.ibm.com>
+Date: Tue, 11 Aug 2020 17:57:09 +0000
+Subject: [PATCH] PPC: Optimize clearing higher bits of mulhw/mulhwu
+
+Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca
+Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468
+Reviewed-by: Junliang Yan <j...@ca.ibm.com>
+Commit-Queue: Milad Farazmand <milad...@ca.ibm.com>
+Cr-Commit-Position: refs/heads/master@{#69343}
+---
+
+diff --git a/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
b/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
+index c18500f..59cef69 100644
+--- a/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
++++ b/deps/v8/src/compiler/backend/ppc/code-generator-ppc.cc
+@@ -1480,18 +1480,14 @@
+ }
+ break;
+ case kPPC_MulHigh32:
+- __ mulhw(ip, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
++ __ mulhw(r0, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
+ // High 32 bits are undefined and need to be cleared.
+- __ li(r0, Operand(-1));
+- __ clrldi(r0, r0, Operand(32));
+- __ and_(i.OutputRegister(), ip, r0);
++ __ clrldi(i.OutputRegister(), r0, Operand(32));
+ break;
+ case kPPC_MulHighU32:
+- __ mulhwu(ip, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
++ __ mulhwu(r0, i.InputRegister(0), i.InputRegister(1), i.OutputRCBit());
+ // High 32 bits are undefined and need to be cleared.
+- __ li(r0, Operand(-1));
+- __ clrldi(r0, r0, Operand(32));
+- __ and_(i.OutputRegister(), ip, r0);
++ __ clrldi(i.OutputRegister(), r0, Operand(32));
+ break;
+ case kPPC_MulDouble:
+ ASSEMBLE_FLOAT_BINOP_RC(fmul, MiscField::decode(instr->opcode()));
diff -Nru nodejs-12.18.2~dfsg/debian/patches/series
nodejs-12.18.2~dfsg/debian/patches/series
--- nodejs-12.18.2~dfsg/debian/patches/series 2020-07-28 15:11:48.000000000
+0200
+++ nodejs-12.18.2~dfsg/debian/patches/series 2020-08-19 20:47:23.000000000
+0200
@@ -17,3 +17,5 @@
ppc64.patch
test-lowerseclevel.patch
python2.patch
+1a9c676a141b32483b48884f8cc0330e64c8e17f.patch
+3f071e3.patch
--- End Message ---
--- Begin Message ---
Source: nodejs
Source-Version: 12.19.0~dfsg-1
Done: =?utf-8?b?SsOpcsOpbXkgTGFs?= <kapo...@melix.org>
We believe that the bug you reported is fixed in the latest version of
nodejs, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 968...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jérémy Lal <kapo...@melix.org> (supplier of updated nodejs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 07 Oct 2020 00:32:42 +0200
Source: nodejs
Architecture: source
Version: 12.19.0~dfsg-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers
<pkg-javascript-devel@alioth-lists.debian.net>
Changed-By: Jérémy Lal <kapo...@melix.org>
Closes: 968681
Changes:
nodejs (12.19.0~dfsg-1) unstable; urgency=medium
.
* New upstream version 12.19.0~dfsg (Closes: #968681)
* Refresh patches
Checksums-Sha1:
dbddeab7d161f7accd1e86c630d8a797556ac013 3161 nodejs_12.19.0~dfsg-1.dsc
5abc562fb241aa3b45da229afa0e57275abc2eca 18498832
nodejs_12.19.0~dfsg.orig.tar.xz
44e1d84d931728e383a3a7eae646a51f4ae45682 133476
nodejs_12.19.0~dfsg-1.debian.tar.xz
16b5c6672309efc71bbe8669983bd66eeeae3fce 8961
nodejs_12.19.0~dfsg-1_source.buildinfo
Checksums-Sha256:
26e7863edce793513317b144574ea85794b5e0f21b719d3cb6d48a2cc43be903 3161
nodejs_12.19.0~dfsg-1.dsc
630bb62f1ade01fca6a1667e7ffd5bc0396c2a6a9203809ee5e4ae0779bb7193 18498832
nodejs_12.19.0~dfsg.orig.tar.xz
7dcccd5a16d97e096a9355fa2d40e3b2b317cb38f511f543eb9c5093f3f69189 133476
nodejs_12.19.0~dfsg-1.debian.tar.xz
0657c320faed10ef218d0ef2d3b81b59711dba10b4bb74907fcca0d4c708ad70 8961
nodejs_12.19.0~dfsg-1_source.buildinfo
Files:
019df15336c8f2edb9861072f414d55e 3161 javascript optional
nodejs_12.19.0~dfsg-1.dsc
2157c7aa11121c9a27f43f6f00edbb67 18498832 javascript optional
nodejs_12.19.0~dfsg.orig.tar.xz
e091ecafcb90aabc22c766e5989ab229 133476 javascript optional
nodejs_12.19.0~dfsg-1.debian.tar.xz
3e944d2c9a1b8143826abc507c2a0b93 8961 javascript optional
nodejs_12.19.0~dfsg-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEEA8Tnq7iA9SQwbkgVZhHAXt0583QFAl99k50SHGthcG91ZXJA
bWVsaXgub3JnAAoJEGYRwF7dOfN05ikP/3yG4jVgun2SQorQKI6G2+dzWvKW2QEh
JygCvuer3PgtW/Or8lV3BdPb2x1VHFmqSfjPkyH+jMwKOMKNWI+diBgtShnrGQBm
qfDtugxT3su7Dd/sy+a7bnDkP8sscU51PW+8mjjVHV7YQ4AwOA7tRrRJrnU3a9iQ
73up+MoUNaJoD/Z98QaFGnPxhIn+l9rSajyaXqh1waHraNxyvSHVRZtq7dhQjdco
ZuRgon6IBJaHtr+ZOSYDSG8jwH0bGMJlEyVL/fflLPZF297UKBYGntNekZQO7vCY
6wD2HSa3Sb1KShMILCJUeg6u9o6VYangP7mTh0SK/Zd54LoZm8eqqVjIRXLhMasT
cVVg16hjM9lYQxyHgR/xtE8JN0yeaJyfhy2ea6KzALlZAEZI/mAVRN8pBd204rhI
8PkCd8HbTHKA8Qt/mckJM+Ajz3q4CQc97LGzFjdrEdlAM2HTgpA5d65Q7vO+EMJx
VBroBhhQkPrxdZIBpaVx+Cmo1H7110mowcCQaFlD/MXo+zy32S8Hymoi+RIu7A5J
Vxn2hcFbPT7vWx0oHqi+MVDhCif2MyTpi7uaD2P3G8M2ejwucdYndXhlK0Kzrjh5
dJ4bLc2kc/R3iltwANEbPGhew7eCY24GVgqMWssEAzJ+GWGRIzl4ARXRfD3z9lb/
rVYgJDO+Ihop
=DYel
-----END PGP SIGNATURE-----
--- End Message ---
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
