Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-24 Thread Diego Biurrun
On Fri, Apr 23, 2010 at 05:31:29PM +0200, Petr Salinger wrote: > > --- trunk/libvo/vo_directfb2.cThu Apr 22 16:02:20 2010(r31057) > +++ trunk/libvo/vo_directfb2.cFri Apr 23 12:04:56 2010(r31058) > @@ -35,9 +35,9 @@ > > #ifdef __linux__ > -#include > -#else > #incl

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-23 Thread Petr Salinger
Modified: trunk/libvo/vo_directfb2.c == --- trunk/libvo/vo_directfb2.c Thu Apr 22 16:02:20 2010(r31057) +++ trunk/libvo/vo_directfb2.c Fri Apr 23 12:04:56 2010(r31058) @@ -35,9 +35,9 @@ #include #ifd

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-23 Thread Petr Salinger
I can understand your position if you are only a porter and not a direct maintainer of a package. However, I have seen package maintainers in different distros duplicate each other's work and add hacks to their packages that I could have fixed quicker and cleaner if somebody had shared their prob

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-23 Thread Diego Biurrun
On Fri, Apr 23, 2010 at 12:57:33PM +0200, Petr Salinger wrote: > >> That was helpful, fixed upstream. >> >> I once again reiterate my suggestion to pass problems to upstream first >> before attempting to work around them locally in the packaging >> infrastructure of a single distribution. > > The e

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-23 Thread Reinhard Tartler
On Fri, Apr 23, 2010 at 12:57:33 (CEST), Petr Salinger wrote: > The build for mplayer from current SVN snapshot, without any flags > passed to configure on kfreebsd-amd64: > > cc .. -c -o libvo/vo_dfbmga.o libvo/vo_dfbmga.c > libvo/vo_dfbmga.c: In function 'get_image': > libvo/vo_dfbmga.c:1352: w

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-23 Thread Petr Salinger
Hi. That was helpful, fixed upstream. I once again reiterate my suggestion to pass problems to upstream first before attempting to work around them locally in the packaging infrastructure of a single distribution. The expected workflow is a different one. Let the package does not build on a

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-22 Thread Diego Biurrun
On Wed, Apr 21, 2010 at 04:50:59PM +0200, Petr Salinger wrote: >>> the current version fails to build on kfreebsd-amd64. >>> it suffices to disable vidix support in debian/rules > >> Bad solution, this will only work for Debian. You should fix configure >> instead of adding workarounds to the loca

Bug#578622: mplayer: FTBFS on kfreebsd-amd64

2010-04-21 Thread Diego Biurrun
On Wed, Apr 21, 2010 at 04:22:16PM +0200, Petr Salinger wrote: > > please also change configure as shown bellow. > Otherwise the memalign() is without prototype, > which on 64 bit platform leads to segfaults > for some videos. Fixed upstream. Why don't you submit your patches directly to MPlayer

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-21 Thread Petr Salinger
the current version fails to build on kfreebsd-amd64. it suffices to disable vidix support in debian/rules Bad solution, this will only work for Debian. You should fix configure instead of adding workarounds to the local packaging infrastructure. What are the error messages? The full build

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-21 Thread Diego Biurrun
On Wed, Apr 21, 2010 at 02:10:31PM +0200, Petr Salinger wrote: > > the current version fails to build on kfreebsd-amd64. > it suffices to disable vidix support in debian/rules > to get working mplayer. > > ifeq ($(DEB_HOST_ARCH),kfreebsd-amd64) > with_real_and_xanim = true > DEB_BUILD_CONFIGURE

Bug#578622: mplayer: FTBFS on kfreebsd-amd64

2010-04-21 Thread Petr Salinger
Hi, please also change configure as shown bellow. Otherwise the memalign() is without prototype, which on 64 bit platform leads to segfaults for some videos. Petr --- configure +++ configure @@ -3166,7 +3166,7 @@ def_malloc_h='#define HAVE_MALLOC_H 0' fi # malloc.h emits a warning in Free

Bug#578622: mplayer: FTBFS on kfreebsd-amd64 (vidix disable needed)

2010-04-21 Thread Petr Salinger
Package: mplayer Version: 1.0~rc3+svn20090405-1 Severity: important Tags: patch User: debian-...@lists.debian.org Usertags: kfreebsd Hi, the current version fails to build on kfreebsd-amd64. it suffices to disable vidix support in debian/rules to get working mplayer. Petr ifeq ($(DEB_HOST_AR