Your message dated Tue, 08 Sep 2015 13:35:42 +0000
with message-id <e1zzj3m-00085t...@franck.debian.org>
and subject line Bug#792672: fixed in x42-plugins 20150702-2
has caused the Debian Bug report #792672,
regarding Assertion error in meters.lv2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
792672: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792672
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: x42-plugins
Version: 20150702-1
Hello:
Someone at the #debian-multimedia channel dropped this report
<olinuxx> Hi guys, I've a bug to report against x42-plugins
<olinuxx> the meters, both as LV2 or standalone app (x42-meter) who
are normaly displaying a needle are segfaulting
<olinuxx> using them in ardour crash it
<olinuxx> the error log is : x42-meter: ./gui/needle.c:118: void
img2surf(const MyGimpImage*, cairo_surface_t**, unsigned char**):
Assertion `ys + xs < (img->width * img->height +
img->bytes_per_pixel)' failed.
<olinuxx> (you can get it trying "x42-meter 6" as an example)
<olinuxx> this is the case with a fresh Jessie install with the
backport from stretch, as well as a fresh Stretch install
<olinuxx> I didn't looked deep yet into BTS reporting, so I'm putting
that here, hopefully, someone will pick it up
I looked at the source and the fix is trivial. It should be "*" and
not "+" as in:
-assert (ys + xs < (img->width * img->height + img->bytes_per_pixel));
+assert (ys + xs < (img->width * img->height * img->bytes_per_pixel));
ys + xs is a sequence that accumulates the total number of bytes and it goes
img->bytes_per_pixel, img->bytes_per_pixel*1, img->bytes_per_pixel*2, ...
img->bytes_per_pixel*(img->width * img->height -1)
It seems upstream wanted to bound ys + xs by the next value in the
sequence which is (img->width * img->height * img->bytes_per_pixel).
This makes the assertion always true since it will be short of the
upper bound by at least img->bytes_per_pixel.
Upstream's commit suggest that there may be another issue
https://github.com/x42/meters.lv2/commit/70497bb8b77aa5ddf13801b0a1472525cfbe42e7
with array boundaries but that is independent of this report.
I have never run or compiled these plugins but the math seems to add
up. Hope my pseudo-patch helps.
Cheers,
Miguel
--- End Message ---
--- Begin Message ---
Source: x42-plugins
Source-Version: 20150702-2
We believe that the bug you reported is fixed in the latest version of
x42-plugins, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 792...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jaromír Mikeš <mira.mi...@seznam.cz> (supplier of updated x42-plugins package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 08 Sep 2015 14:40:31 +0200
Source: x42-plugins
Binary: x42-plugins
Architecture: source amd64
Version: 20150702-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers
<pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Jaromír Mikeš <mira.mi...@seznam.cz>
Description:
x42-plugins - Collection of LV2 plugins
Closes: 792672 794356
Changes:
x42-plugins (20150702-2) unstable; urgency=medium
.
* Added patch to to fix ebur128. (Closes: #794356)
* Added patch to to fix assertion. (Closes: #792672)
* Remove fast-math optimalization .
* Enable parallel build.
* Enable sse and sse2 opt on amd64.
Checksums-Sha1:
87c9a4ee11b544d5747b4b9f6be4feb6334a6aab 2270 x42-plugins_20150702-2.dsc
eb9900f7239ece339842189160f78473696d1cf2 4204
x42-plugins_20150702-2.debian.tar.xz
1c0461143f27f3c24376e21a84c962182e162bda 2127350
x42-plugins_20150702-2_amd64.deb
Checksums-Sha256:
b520510f7591c781fc32355207fbc50fa0fc3e5e82df63c3e4f5766b2aeb6724 2270
x42-plugins_20150702-2.dsc
ceb2805b81df03fb8708b8add7368dcc60acd411c340b9d520fb5a491c561e58 4204
x42-plugins_20150702-2.debian.tar.xz
33b5199fbe4d3512c480606778c372bc64922d2be1c86ef3f3cced87cf0d1f64 2127350
x42-plugins_20150702-2_amd64.deb
Files:
0485301a74456d8b342001c0bcc0b0d3 2270 sound optional x42-plugins_20150702-2.dsc
14a36f87c5d001df948b6ecb2e801d2b 4204 sound optional
x42-plugins_20150702-2.debian.tar.xz
09d3146c9b06c44ef4a5ced4f78d348a 2127350 sound optional
x42-plugins_20150702-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJV7uIQAAoJEFsBlFXiuE+l0uUP/Ra3W5gfEI7/uolEUUcqz+g6
S/tMEzdVWUV8m8PMTgRMW51DVPI2YLyV4lmlMVjHMTHu7HECahKf0pVncn4iikKT
MA/oiZV1ZT+mjb0gxtgdYWXtbcCwhp0huAelrEtKwDdbzpe9srGv075cxAYJh7/t
+kQo+qkOA08hd5Ycn9tLVdZXrB50oXVeF/vNU9VJE9gAoGhAa+3OrfQnpxB8AY9w
wxQ1t19z4oQieEhir8BA+RRkZMRMz1n0t0u8573BVIdL9EUYP+NhwWn3cQIBGb8I
7A2l83UJJFKr5x1uYJHmEesmkoJmJGbJQgoGzP18xr33nh5FNfayBssSKYh8wurz
gATEzGxN/ZiCLJMqJ43j8jLzzWBKm7cUNxP3gV4B/M+InNMpEdU3+sH4uzPbHTCs
8KoU0ONr8z0/0axluU1D9qRJa5x11TAROg7P0/CRzKeaxohV7/HGrbb/2vZbwKJd
sXEacNV4XWXDC5v22wyMBrDCKpwQQ1AogmktzOeoSO6KyqWppJaYYeJFXDRhCf/P
gnXonBJEqoFIb3mFAq59H4VWLx9U/itLAwuloRIt3/YRNUYalPzNqOB323D/GQQv
mT87CvD1+hAgGbodJgAaKKX9DHsni9/HtN8vjp5vQuc68U6kjNrfEx7BINBe10mI
TChNlkQoQsSQdLiAHc0P
=OhbW
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
