Your message dated Thu, 22 Sep 2022 13:39:50 -0700
with message-id <87zgeri1nt.fsf@contorta>
and subject line Bug#791423: linuxtv-dvb-apps: please make the build
reproducible
has caused the Debian Bug report #791423,
regarding linuxtv-dvb-apps: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
791423: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791423
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: linuxtv-dvb-apps
Version: 1.1.1+rev1500-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org
Hi!
While working on the "reproducible builds" effort [1], we have noticed
that linuxtv-dvb-apps could not be built reproducibly.
During build a header file is generated whose elements are sorted
differently depending on the configured locale.
The attached patch fixes this by setting LC_ALL to C before sorting.
Regards,
Reiner
[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..d87a1f4
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,28 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Sort items in header file locale-independent
+ The order of items in the generated header file can differ
+ depending on the currently configured locale.
+ Sort them with LC_ALL set to C to get a reproducible result.
+
+Index: linuxtv-dvb-apps-1.1.1+rev1500/util/av7110_loadkeys/generate-keynames.sh
+===================================================================
+--- linuxtv-dvb-apps-1.1.1+rev1500.orig/util/av7110_loadkeys/generate-keynames.sh
++++ linuxtv-dvb-apps-1.1.1+rev1500/util/av7110_loadkeys/generate-keynames.sh
+@@ -20,7 +20,7 @@ echo >> $1
+ echo "static struct input_key_name key_name [] = {" >> $1
+ for x in $(cat /usr/include/linux/input.h input_fake.h | \
+ egrep "#define[ \t]+KEY_" | grep -v KEY_MAX | \
+- cut -f 1 | cut -f 2 -d " " | sort -u) ; do
++ cut -f 1 | cut -f 2 -d " " | LC_ALL=C sort -u) ; do
+ echo " { \"$(echo $x | cut -b 5-)\", $x }," >> $1
+ done
+ echo "};" >> $1
+@@ -28,7 +28,7 @@ echo >> $1
+ echo "static struct input_key_name btn_name [] = {" >> $1
+ for x in $(cat /usr/include/linux/input.h input_fake.h | \
+ egrep "#define[ \t]+BTN_" | \
+- cut -f 1 | cut -f 2 -d " " | sort -u) ; do
++ cut -f 1 | cut -f 2 -d " " | LC_ALL=C sort -u) ; do
+ echo " { \"$(echo $x | cut -b 5-)\", $x }," >> $1
+ done
+ echo "};" >> $1
diff --git a/debian/patches/series b/debian/patches/series
index 37b732b..4c5c718 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -7,3 +7,4 @@ apps_manpages.patch
alevt.patch
dbug606728.diff
use-ldflags.patch
+reproducible_build.patch
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
On 2015-07-04, Reiner Herrmann wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that linuxtv-dvb-apps could not be built reproducibly.
> During build a header file is generated whose elements are sorted
> differently depending on the configured locale.
>
> The attached patch fixes this by setting LC_ALL to C before sorting.
The locales tested on tests.reproducible-builds.org do not appear to
trigger this, as the builds for bookworm and bullseye both vary locales,
but do not appear to trigger the issue:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/linuxtv-dvb-apps.html
I was also unable to reproduce the issue with reprotest.
Marking as done.
live well,
vagrant
signature.asc
Description: PGP signature
--- End Message ---
_______________________________________________
pkg-vdr-dvb-devel mailing list
pkg-vdr-dvb-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-vdr-dvb-devel
