Your message dated Sun, 26 Jul 2020 18:38:54 +0000
with message-id <e1jzlxy-0002yb...@fasolo.debian.org>
and subject line Bug#964220: fixed in vdr 2.4.1-4.1
has caused the Debian Bug report #964220,
regarding vdr: FTBFS with glibc 2.31 (uses removed stime function)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
964220: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964220
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: vdr
Version: 2.4.1-4
Severity: important
Tags: patch upstream

Dear maintainer,

vdr fail to build from source with glibc 2.31:

| g++ -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat 
-Werror=format-security -fPIC -c -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DREMOTE_KBD -DSDNOTIFY 
-DLIRC_DEVICE=\"/var/run/lirc/lircd\" -DVIDEODIR=\"/var/lib/video\" 
-DCONFDIR=\"/var/lib/vdr\" -DARGSDIR=\"/etc/vdr/conf.d\" 
-DCACHEDIR=\"/var/cache/vdr\" -DRESDIR=\"/usr/share/vdr\" 
-DPLUGINDIR=\"/usr/lib/vdr/plugins\" -DLOCDIR=\"/usr/share/locale\" 
-I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16   -o 
eitscan.o eitscan.c
| eit.c: In constructor ‘cTDT::cTDT(const u_char*)’:
| eit.c:394:13: error: ‘stime’ was not declared in this scope; did you mean 
‘ctime’?
|   394 |         if (stime(&dvbtim) == 0)
|       |             ^~~~~
|       |             ctime
| make[2]: *** [Makefile:135: eit.o] Error 1
| make[2]: *** Waiting for unfinished jobs....
| make[2]: Leaving directory '/<<PKGBUILDDIR>>'
| dh_auto_build: error: make -j4 "INSTALL=install --strip-program=true" 
PREFIX=/usr VIDEODIR=/var/lib/video LIBDIR=/usr/lib/vdr/plugins SDNOTIFY=1 
VERBOSE=1 returned exit code 2
| make[1]: *** [debian/rules:17: override_dh_auto_build] Error 25
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| make: *** [debian/rules:14: build] Error 2
| dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

The full build log is available there:
http://qa-logs.debian.net/2020/06/24/vdr_2.4.1-4_unstable_glibc-exp.log

The stime function has been marked as obsolete for some time, and since
glibc 2.31 it is no longer available to newly linked binaries. The
clock_settime function should be used instead.

You will find attached a patch fixing that. It would be nice if it can
be fixed relatively soon so that we can start the transition.

Regards,
Aurelien
diff -Nru vdr-2.4.1/debian/patches/glibc-stime.patch 
vdr-2.4.1/debian/patches/glibc-stime.patch
--- vdr-2.4.1/debian/patches/glibc-stime.patch  1970-01-01 00:00:00.000000000 
+0000
+++ vdr-2.4.1/debian/patches/glibc-stime.patch  2020-07-03 18:47:22.000000000 
+0000
@@ -0,0 +1,15 @@
+The obsolete function stime is no longer available to newly linked binaries
+since glibc 2.31. Replace it by clock_settime.
+
+--- a/eit.c
++++ b/eit.c
+@@ -391,7 +391,8 @@ cTDT::cTDT(const u_char *Data)
+   if (abs(diff) > MAX_TIME_DIFF) {
+      mutex.Lock();
+      if (abs(diff) > MAX_ADJ_DIFF) {
+-        if (stime(&dvbtim) == 0)
++        struct timespec ts = { .tv_sec = dvbtim };
++        if (clock_settime(CLOCK_REALTIME, &ts) == 0)
+            isyslog("system time changed from %s (%ld) to %s (%ld)", 
*TimeToString(loctim), loctim, *TimeToString(dvbtim), dvbtim);
+         else
+            esyslog("ERROR while setting system time: %m");
diff -Nru vdr-2.4.1/debian/patches/series vdr-2.4.1/debian/patches/series
--- vdr-2.4.1/debian/patches/series     2019-11-01 12:11:11.000000000 +0000
+++ vdr-2.4.1/debian/patches/series     2020-07-03 18:45:29.000000000 +0000
@@ -6,3 +6,4 @@
 allow-verbose-libsi-build.patch
 use-cpp-flags.patch
 configurable-pkg-config.patch
+glibc-stime.patch

--- End Message ---
--- Begin Message ---
Source: vdr
Source-Version: 2.4.1-4.1
Done: Aurelien Jarno <aure...@debian.org>

We believe that the bug you reported is fixed in the latest version of
vdr, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 964...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurelien Jarno <aure...@debian.org> (supplier of updated vdr package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 19 Jul 2020 19:22:51 +0200
Source: vdr
Architecture: source
Version: 2.4.1-4.1
Distribution: unstable
Urgency: medium
Maintainer: Debian VDR Team <pkg-vdr-dvb-de...@lists.alioth.debian.org>
Changed-By: Aurelien Jarno <aure...@debian.org>
Closes: 964220
Changes:
 vdr (2.4.1-4.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Add a patch to replace the obsolete stime function (removed in glibc 2.31)
     by clock_settime. (Closes: #964220)
Checksums-Sha1:
 52e33215d67278e5588d7ea1d007fbe9ae5e59a3 2204 vdr_2.4.1-4.1.dsc
 42e7dbdebfc8d2a273d9bf864bd4a9ac9840380f 51808 vdr_2.4.1-4.1.debian.tar.xz
 aef12aaffa1899de01c808cb7cd527396c06a5db 6036 vdr_2.4.1-4.1_source.buildinfo
Checksums-Sha256:
 ce9c731e49af07382b3d9fb300d529f6ae1c81909667b54e777a6db0a680932d 2204 
vdr_2.4.1-4.1.dsc
 38e79e32ccd7b48070f3c1a355a415e7c92afd3b13e555590fca83bdc8ad21b7 51808 
vdr_2.4.1-4.1.debian.tar.xz
 7680a68cfac5a4eccb4dc9ee58994c7937b9b3f352262c74f06b83e4587024a1 6036 
vdr_2.4.1-4.1_source.buildinfo
Files:
 ae5830cc8e682611a1a0a97f9da691e4 2204 video optional vdr_2.4.1-4.1.dsc
 80ccbc329de101a8ce2ea32411efbe1c 51808 video optional 
vdr_2.4.1-4.1.debian.tar.xz
 e7823d6ddda3c10eb8660bd4c8f42833 6036 video optional 
vdr_2.4.1-4.1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEUryGlb40+QrX1Ay4E4jA+JnoM2sFAl8UhtUACgkQE4jA+Jno
M2tykw/7BbFxzbcZYN53uZgQWNeAM5ziAWhXdb5DVsAU8zItwDt/XByf4eGVajXn
kh4MojosqlfR8wVGeqchlttUniGqaao450R/s5W6YxFsesqHSgc6kSZHrFNFg+4m
GPaTMMFM2pLLQcSfUOiroufUq+emCLsCwDf1gmFTyNvLIH/f3m+NxXn2eB9JJGiK
f033/CxZY4fkYGS47gnQGOfwSkRlCisvzcmQBShdVqFt/4NVyWVJSvIruNIKpsVq
Z/v0McWQxxH2SG0diVk1jWPrpudnY/dEc/2H70birJUWvdJmDp5d0aLLUObj3z0r
qF2nv9ISKA+K0KdkBVbS8Ui9uid9q3/oPKlEb4Rt7Y2gerVRmmdlpF2PKk8zJIO9
wvS/rilyMvBioRTz7wmM9xMCkm9NFFvMRyCKJgDd4PLRa1Gg0kdou24wg0qjRwdk
GOs56CAMWeqjso32WOf+tSugwcmAgtGCAd/SAJpT92rjgGFSaE7VzfLXtzeiSXew
wJP0iVWoiytwYZGe9ylssU5csXZypDB+/1h+eJQQR2Fnhc32WHeIUe6ZkV/BaiHT
R+xo5/111gL6tLr2bizUIUf6IwgJZqooIZBbDRHCvmFkoj/dxtoC4vG9Uzzg/BSV
qkPv8vDBqbD7Gyndf8YgFbZwOwDiWxIBEJMQ3IgibJsTrFsev+I=
=7tCQ
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
pkg-vdr-dvb-devel mailing list
pkg-vdr-dvb-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-vdr-dvb-devel

Reply via email to