Re: Review Request: Analog clock painting performance

2008-11-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/290/#review274 --- hmm, strage, because rects of svgs should be cached already

Re: Review Request: Analog clock painting performance

2008-11-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/290/#review275 --- hm. that seems a little suspect to me, but if grabbing the cached

Re: Review Request: zoomed out toolbox outside of containments

2008-11-30 Thread Aaron J. Seigo
On Saturday 29 November 2008, Marco Martin wrote: edit: another problem: toolbox is too wide for smaller screen resolutions, in that screenshot a 1680 screen is almost filled with toolbox width so what to do? trying to manually layout the tools in two lines disabling text when it's too wide or

Re: Review Request: Bugfix for Folderview bug #175191

2008-11-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/288/#review276 --- Ship it! yes, that's probably sensible.

Re: Systray Notifications

2008-11-30 Thread Matthias Fuchs
On Samstag 29 November 2008 15:15:58 Rob Scheepmaker wrote: Well, with more notifications then space available stuff will obviously be suboptimal. The question is how often this situation arises. I'm using these notifications in the systray for some time now, and the amount of simultaneous

Re: Review Request: Analog clock painting performance

2008-11-30 Thread Alain Boyer
On 2008-11-30 09:01:20, Aaron Seigo wrote: hm. that seems a little suspect to me, but if grabbing the cached rects is really that slow, then Theme::findInRectsCache is probably what needs to be optimized. can you post the cachegrind output somewhere, along with the clock

Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/ --- Review request for Plasma. Summary --- A patch that makes the Battery

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/ --- (Updated 2008-11-30 16:50:43.740914) Review request for Plasma. Summary

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/#review280 --- hm. i actually take that Ship it! back .. i don't think it makes