Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Aaron Seigo
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
> On 2009-07-02 13:09:12, Chani wrote: > > trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 117 > > > > > > that if statement is getting awfully long. perhaps for the sake of > > readability you could split it up a

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/926/#review1442 --- trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp

Re: Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/926/#review1439 --- Ship it! - Aaron On 2009-07-02 09:15:41, Shantanu Tushar Jha wrote:

Review Request: Fix Open Picture.... menu behavior in Picture Frame applet

2009-07-02 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/926/ --- Review request for Plasma. Summary --- Picture Frame didn't have Open Pictur

Re: user interface for mouse actions configuration

2009-07-02 Thread Chani
> > Anyway, I made a little mockup, of the configuration dialog, that I > seemed to be able to grok much easier. What do you think? > http://skitch.com/michaelrudolph/bsrix/configuredesktopactions > I spent a couple of weeks working on the dialog and rewrote it several times; I need to work on so