Re: Bugs in signalplotter.cpp

2009-09-22 Thread John Tapsell
2009/9/21 Aaron J. Seigo ase...@kde.org: On September 21, 2009, John Tapsell wrote: 2009/9/20 Albert Astals Cid aa...@kde.org: Hi, not sure who's the responsible on that, blame says 73% of lines are from leonhard but CIA says he left KDE time ago, copyright mentions John so i'm mailing for

Re: pervirtualdesktopviews=true does not work

2009-09-22 Thread WuYongbo
sorry for the email above. the configuration works!! can anybody give me a hint about the root cause of the blank desktops problems in kde4.2 ? caused by “pervirtualdesktopviews=true” ? thanks a lot ! 2009/9/22 WuYongbo wilbur.un...@gmail.com I tried the configuration after zoom out, each

Re: Bugs in signalplotter.cpp

2009-09-22 Thread Marco Martin
On 9/22/09, John Tapsell johnf...@gmail.com wrote: 2009/9/21 Aaron J. Seigo ase...@kde.org: On September 21, 2009, John Tapsell wrote: 2009/9/20 Albert Astals Cid aa...@kde.org: Hi, not sure who's the responsible on that, blame says 73% of lines are from leonhard but CIA says he left KDE

Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit

2009-09-22 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-09-22 10:30:38.640491) Review request for Plasma, Aaron Seigo and

Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit

2009-09-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review2415 --- Ship it! to me the patch it's fine (and the webbrowser plasmoid

Re: pervirtualdesktopviews=true does not work

2009-09-22 Thread Marco Martin
On Tuesday 22 September 2009, WuYongbo wrote: sorry for the email above. the configuration works!! can anybody give me a hint about the root cause of the blank desktops problems in kde4.2 ? caused by “pervirtualdesktopviews=true” ? in kde 4.2 didn't actually work, iirc was a problem in

Re: Review Request: Attempt to port KAlarm to KNotificationIcon

2009-09-22 Thread Davide Bettio
On 2009-09-22 05:12:41, David Jarvie wrote: As you say, these changes are incomplete. The way that quitting is handled (whether to quit or not, depending on which windows are open) is a very important feature in KAlarm, and looking at the patch, I'm not convinced that it handles this

Re: Review Request: Attempt to port KAlarm to KNotificationIcon

2009-09-22 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:23:39.660245) Review request for KDE PIM and Plasma.

Re: Review Request: Attempt to port KAlarm to KNotificationIcon

2009-09-22 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/ --- (Updated 2009-09-22 19:24:27.885530) Review request for KDE PIM, Plasma and

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-22 Thread Davide Bettio
On 2009-09-21 13:41:29, Thorsten Staerk wrote: Good to see you working on my baby ktimetracker. Let's have a discussion on irc. ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You can find me in #plasma. - Davide

Re: Review Request: Attempt to port KAlarm to KNotificationIcon

2009-09-22 Thread Marco Martin
On 2009-09-22 05:12:41, David Jarvie wrote: /trunk/KDE/kdepim/kalarm/kalarmapp.cpp, line 753 http://reviewboard.kde.org/r/1655/diff/1/?file=11686#file11686line753 This line shouldn't be removed unless there's some alternative mechanism for showing the window. wrote: you

Re: Review Request: Attempt to port KAlarm to KNotificationIcon

2009-09-22 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/#review2422 --- Yes, KAlarm can run with or without the system tray icon. - David

Re: Review request: Container plasma applet

2009-09-22 Thread alan moore
Anyway, with your last sentence you was saying that I could have done a similar thing working directly on containments? yes, and that's really probably the way to go about it. use cases would probably help define what direction to actually take. I was actually a bit excited when I saw

Re: Review request: Container plasma applet

2009-09-22 Thread Aaron J. Seigo
On September 22, 2009, alan moore wrote: My thinking for the solution was to create a sub-containment that would and improving the panel and/or the widgets wasn't a possibility? :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE